Page MenuHomePhabricator
Create Task
Maniphest T315479

InvalidArgumentException: WikiPage constructed on a Title that cannot exist as a page: Especial:MobileDiff/17544
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   InvalidArgumentException: WikiPage constructed on a Title that cannot exist as a page: Especial:MobileDiff/17544
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.25/includes/page/WikiPage.php(173)
#0 /srv/mediawiki/php-1.39.0-wmf.25/extensions/FlaggedRevs/backend/FlaggableWikiPage.php(75): WikiPage->__construct(Title)
#1 /srv/mediawiki/php-1.39.0-wmf.25/extensions/FlaggedRevs/backend/FlaggableWikiPage.php(67): FlaggableWikiPage->__construct(Title)
#2 /srv/mediawiki/php-1.39.0-wmf.25/extensions/FlaggedRevs/backend/FlaggableWikiPage.php(56): FlaggableWikiPage::newInstance(Title)
#3 /srv/mediawiki/php-1.39.0-wmf.25/extensions/FlaggedRevs/frontend/FlaggedRevsUIHooks.php(17): FlaggableWikiPage::getTitleInstance(Title)
#4 /srv/mediawiki/php-1.39.0-wmf.25/extensions/FlaggedRevs/frontend/FlaggedRevsUIHooks.php(907): FlaggedRevsUIHooks::injectStyleAndJS(OutputPage)
#5 /srv/mediawiki/php-1.39.0-wmf.25/includes/HookContainer/HookContainer.php(338): FlaggedRevsUIHooks::onDifferenceEngineViewHeader(DifferenceEngine)
#6 /srv/mediawiki/php-1.39.0-wmf.25/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#7 /srv/mediawiki/php-1.39.0-wmf.25/includes/HookContainer/HookRunner.php(1441): MediaWiki\HookContainer\HookContainer->run(string, array)
#8 /srv/mediawiki/php-1.39.0-wmf.25/includes/diff/DifferenceEngine.php(655): MediaWiki\HookContainer\HookRunner->onDifferenceEngineViewHeader(DifferenceEngine)
#9 /srv/mediawiki/php-1.39.0-wmf.25/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php(189): DifferenceEngine->showDiffPage(boolean)
#10 /srv/mediawiki/php-1.39.0-wmf.25/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php(143): SpecialMobileDiff->displayDiffPage()
#11 /srv/mediawiki/php-1.39.0-wmf.25/extensions/MobileFrontend/includes/specials/MobileSpecialPage.php(70): SpecialMobileDiff->executeWhenAvailable(string)
#12 /srv/mediawiki/php-1.39.0-wmf.25/includes/specialpage/SpecialPage.php(690): MobileSpecialPage->execute(string)
#13 /srv/mediawiki/php-1.39.0-wmf.25/includes/specialpage/SpecialPageFactory.php(1426): SpecialPage->run(string)
#14 /srv/mediawiki/php-1.39.0-wmf.25/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#15 /srv/mediawiki/php-1.39.0-wmf.25/includes/MediaWiki.php(905): MediaWiki->performRequest()
#16 /srv/mediawiki/php-1.39.0-wmf.25/includes/MediaWiki.php(562): MediaWiki->main()
#17 /srv/mediawiki/php-1.39.0-wmf.25/index.php(50): MediaWiki->run()
#18 /srv/mediawiki/php-1.39.0-wmf.25/index.php(46): wfIndexMain()
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}
Notes

Errors like the above started occurring when .25 was rolled to group1. The page title varies each request.

We rolled back. Please advise!

Details

Request URL
https://pt.wikinews.org/wiki/Especial:MobileDiff/17544
SubjectRepoBranchLines +/-
Do not attempt to create a FlaggableWikiPage when the title can't existmediawiki/extensions/FlaggedRevsmaster+3 -0
Do not attempt to create a FlaggableWikiPage when the title can't existmediawiki/extensions/FlaggedRevswmf/1.39.0-wmf.25+3 -0
Customize query in gerrit

Event Timeline

dancy triaged this task as Unbreak Now! priority.Aug 17 2022, 7:05 PM
dancy created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2022, 7:05 PM
dancy added a parent task: T314186: 1.39.0-wmf.25 deployment blockers.Aug 17 2022, 7:07 PM
Ladsgroup added subscribers: Krinkle, Ladsgroup.Aug 17 2022, 7:07 PM

It's probably related to a couple of patches we did. @Krinkle

Ladsgroup added a comment.Aug 17 2022, 7:13 PM

The https://www.mediawiki.org/wiki/MediaWiki_1.39/wmf.25 page says there is any change on FR but I think it's lying because we had changes last week but train is cancelled. I think I04fdbd497b835f19436de5454000126c24824256 is probably the culprit, I'll try to see if I can reproduce this and fix it.

Ladsgroup added a comment.Aug 17 2022, 7:15 PM

Reproduced, let me see how can I fix it.

gerritbot added a comment.Aug 17 2022, 7:19 PM

Change 824270 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@master] Do not attempt to create a FlaggableWikiPage when the title can't exist

https://gerrit.wikimedia.org/r/824270

gerritbot added a project: Patch-For-Review.Aug 17 2022, 7:19 PM
gerritbot added a comment.Aug 17 2022, 8:08 PM

Change 824270 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Do not attempt to create a FlaggableWikiPage when the title can't exist

https://gerrit.wikimedia.org/r/824270

gerritbot added a comment.Aug 17 2022, 8:09 PM

Change 824169 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@wmf/1.39.0-wmf.25] Do not attempt to create a FlaggableWikiPage when the title can't exist

https://gerrit.wikimedia.org/r/824169

Jdlrobson edited projects, added MobileFrontend (Tracking); removed MobileFrontend.Aug 17 2022, 8:23 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 17 2022, 9:01 PM
gerritbot added a comment.Aug 17 2022, 9:06 PM

Change 824169 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@wmf/1.39.0-wmf.25] Do not attempt to create a FlaggableWikiPage when the title can't exist

https://gerrit.wikimedia.org/r/824169

Stashbot added a comment.Aug 17 2022, 9:13 PM

Mentioned in SAL (#wikimedia-operations) [2022-08-17T21:13:03Z] <ladsgroup@deploy1002> Synchronized php-1.39.0-wmf.25/extensions/FlaggedRevs/frontend/FlaggedRevsUIHooks.php: Backport: [[gerrit:824169|Do not attempt to create a FlaggableWikiPage when the title can't exist (T315479)]] (duration: 03m 26s)

Ladsgroup closed this task as Resolved.Aug 17 2022, 9:22 PM
Ladsgroup claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Aug 17 2022, 9:29 PM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.25; 2022-08-15); removed MW-1.39-notes (1.39.0-wmf.26; 2022-08-22).Aug 17 2022, 10:00 PM
dancy removed a parent task: T314186: 1.39.0-wmf.25 deployment blockers.Aug 17 2022, 10:55 PM
Krinkle moved this task from Untriaged to Aug 2022 on the Wikimedia-production-error board.Aug 25 2022, 11:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL