Page MenuHomePhabricator

Improve how DiscussionTools search handles capitalization
Open, Needs TriagePublic

Description

I recently tried tagging User:PerfectSoundWhatever using the @ tagging function of the Reply Tool. The user had already been mentioned earlier in the discussion, so they should have shown up as a suggested tag, but since they didn't, I had to type out their name. I typed out "perfectsou", but they didn't show up as expected, so I had to go back and try again using "PerfectSou" to get them to show up. The suggested users to tag function should be improved so that it's not so picky about capitalization.

Event Timeline

That should already work -- could you link to the specific discussion where you experienced this?

@DLynch, it was here. Thanks for looking into this!

Ah, got it. Okay, the issue is twofold:

  1. Only users who have participated in the discussion already get added to the completions. That means they need to have actually left a comment, not just been mentioned.
  2. Searching for users who haven't participated is handled by using the Allusers API which is unfortunately case-sensitive.

The latter isn't something we can easily do much about -- presumably the API is case-sensitive for performance reasons. There's an existing ticket for this as it applies to the same API being used in Flow -- T101254.

That said, the former could be addressed so we also pull in linked usernames from the local page. We have a task for improving the completion results which this might get folded into -- T295507.

That said, the former could be addressed so we also pull in linked usernames from the local page. We have a task for improving the completion results which this might get folded into -- T295507.

Good spot, @DLynch. I'm going to add this issue to the table within T295507.