Page MenuHomePhabricator
Create Task
Maniphest T316377

Suggested Edits Help "?" icon: incorrectly displaying on printable version of articles
Closed, ResolvedPublicBUG REPORT
Actions

Description

As a newcomer viewing an article with a Suggested Edit, I want to be able to print the page without content being covered up by the help icon.

Steps to replicate the issue (include links if applicable):

  • Navigate to newcomer homepage
  • Select a Suggested Edit
  • Click on "Printable version"

What happens?:
The Help "?" icon shows on the printable version. The icon overlaps and sometimes hides content.

What should have happened instead?:
The Help "?" icon should not appear in printable versions of the page.

Other information

  • Originally reported by @Dyolf77_WMF (testing on arwiki)
  • Reproduced on enwiki, Chrome 104 / whatsmybrowser.org/b/5XLGA

Example:

Screen Shot 2022-08-26 at 9.27.18 AM.png (1×1 px, 1 MB)

Details

SubjectRepoBranchLines +/-
Don't show help panel or its button in printable version of pagemediawiki/extensions/GrowthExperimentsmaster+8 -0
Customize query in gerrit

Event Timeline

KStoller-WMF created this task.Aug 26 2022, 4:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2022, 4:35 PM
KStoller-WMF updated the task description. (Show Details)Aug 26 2022, 4:37 PM
KStoller-WMF added a subscriber: Dyolf77_WMF.
gerritbot added a comment.Aug 31 2022, 9:25 AM

Change 828480 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Don't show help panel button in printable version of page

https://gerrit.wikimedia.org/r/828480

gerritbot added a project: Patch-For-Review.Aug 31 2022, 9:25 AM
kostajh claimed this task.Aug 31 2022, 9:25 AM
kostajh triaged this task as Medium priority.
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 2 2022, 11:42 AM
gerritbot added a comment.Sep 2 2022, 12:10 PM

Change 828480 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Don't show help panel or its button in printable version of page

https://gerrit.wikimedia.org/r/828480

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2022, 12:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05).Sep 2 2022, 1:00 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.EditedSep 2 2022, 9:14 PM
Etonkovidova subscribed.

Checked in betalabs - an article's printable version doesn't show the Help panel button. Betalabs (enwiki) doesn't display Print/export options in the site menu, but the functionality/display is the same as with a browser printing options.

Testing notes (to check in production):

  • enwiki has two options in the side menu Print/export - Download as PDF and Printable version. Download as PDF doesn't show the help panel button (checked in wmf.27).
Etonkovidova added a comment.Sep 6 2022, 10:32 PM
Checked in testwiki wmf.28 - the issue is not present anymore.



@KStoller-WMF - the issue was reported for a Suggested Edit. Should we also remove collapsed Link inspector (Image Inspector) from printed copies? Presently, the collapsed add link/ add image inspector will show if a user goes to browsers Print options. 
Screen Shot 2022-09-06 at 3.27.12 PM.png (1×2 px, 1 MB)
KStoller-WMF added a comment.Sep 6 2022, 10:55 PM


In T316377#8216210, @Etonkovidova wrote:


Should we also remove collapsed Link inspector (Image Inspector) from printed copies? Presently, the collapsed add link/ add image inspector will show if a user goes to browsers Print options. 
Screen Shot 2022-09-06 at 3.27.12 PM.png (1×2 px, 1 MB)





Yes, I think? Ideally we aren't ever covering article text like this.  That being said, I'm not sure how high priority this is, but it seems like something we should fix if it's easy.
Etonkovidova added a comment.Sep 9 2022, 12:42 AM


In T316377#8216254, @KStoller-WMF wrote:




In T316377#8216210, @Etonkovidova wrote:


Should we also remove collapsed Link inspector (Image Inspector) from printed copies? Presently, the collapsed add link/ add image inspector will show if a user goes to browsers Print options. 
Screen Shot 2022-09-06 at 3.27.12 PM.png (1×2 px, 1 MB)





Yes, I think? Ideally we aren't ever covering article text like this.  That being said, I'm not sure how high priority this is, but it seems like something we should fix if it's easy.





Thank you, @KStoller-WMF. Technically,  when the add link inspector is present, an article is in Suggested edit mode, not in Read mode. There won't be Print/export options on the side menu. So, probably it's not worth to accommodate the case when a user decides to print an article in non-Read mode via browser option option?
KStoller-WMF added a comment.Sep 9 2022, 4:51 PM
Ah, thanks for the clarification.  Yes, that indeed seems like an edge case and perhaps not necessary to accommodate.
Etonkovidova closed this task as Resolved.Sep 9 2022, 6:22 PM


In T316377#8225284, @KStoller-WMF wrote:


Ah, thanks for the clarification.  Yes, that indeed seems like an edge case and perhaps not necessary to accommodate.





Agree  - closing as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits