I have encountered users who incorrectly did not make it onto the 2022 Board Election voter list because the script thought they didn't have enough edits, but if you counted Flow edits, then they pass the 300 threshold. Flow posts should count the same as edits do.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| populateEditCount: Count flow revisions if applicable | mediawiki/extensions/SecurePoll | master | +64 -3 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Can we just count flow_revision in the same way? Or does that not work as you can edit a post, so potentially inflating the edit count (which of course you can do with normal revision anyway)..
Comment Actions
I think we should count Flow edits as they appear on Special:Contributions. Anything that generates a row there should count as 1 edit. That seems like the most logical equivalence.
Comment Actions
Change 827014 had a related patch set uploaded (by Reedy; author: Reedy):
[mediawiki/extensions/SecurePoll@master] populateEditCount: Count flow revisions if applicable
Comment Actions
Sounds good for future elections. We cannot re-run the scripts even with a patch, this year - I would recommend that those who aren't able to vote email the Elections Committee directly.
Comment Actions
How do we go about getting someone from the Growth Team to do some CR on at least the basic SQL queries in the attached patch?
Comment Actions
I think most engineers who work with MediaWiki could review the patch as well as anyone on the Growth team. The engineers who worked with Flow in depth have not been on the Growth team for some time. Flow is in "passive maintenance" by our team, meaning "Bugs and issues coming up on this projects will ONLY receive attention if the issue is urgent, affects a large number of users and needs to be unbroken immediately". I'm not sure this task meets those criteria, but if you think it does then we can try to find time for it–just comment here and we'll discuss it (cc @DMburugu). Glancing at the patch, I personally would need to spend a fair amount of time to read through Flow code to get enough context to review meaningfully.
Comment Actions
Change 827014 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] populateEditCount: Count flow revisions if applicable