Use icon-opacity-subtle variable for popup button
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Aug 30 2022, 12:50 PM

Description

The IPInfo popup button looks heavy following the info icon redesign:

In T309828, the variable icon-opacity-subtle is introduced (code). Use this for the popup button.

Acceptance criteria

The popup buttons have an opacity of 0.67 on every page where they are displayed.

Notes

The popup buttons are OO.ui.PopupButtonWidgets, added in popup/init.js

Details

	Subject	Repo	Branch	Lines +/-
	Use icon-opacity-subtle variable for popup button	mediawiki/extensions/IPInfo	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: T318405: IP Info Help popups aren't fully opaque
T309828: Update IP info colors based on design systems recommendations
Mentioned Here: rEIPI84c0bb99ab12: Use icon-opacity-subtle variable for popup button
T309828: Update IP info colors based on design systems recommendations

Event Timeline

Tchanders created this task.Aug 30 2022, 12:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2022, 12:50 PM

Tchanders attached a referenced file: F35490948: image.png. (Show Details)Aug 30 2022, 12:50 PM

Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.

Tchanders mentioned this in T309828: Update IP info colors based on design systems recommendations.

ARamirez_WMF moved this task from Triage/To be Estimated to AHaT Sprint 15: The Gandhi Cap on the Anti-Harassment board.Aug 30 2022, 4:20 PM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 15: The Gandhi Cap); removed Anti-Harassment.

Tchanders set the point value for this task to 1.Aug 30 2022, 5:23 PM

Cyndymediawiksim claimed this task.Aug 31 2022, 2:04 PM

Cyndymediawiksim moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 15: The Gandhi Cap) board.

Change 829019 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/IPInfo@master] Use icon-opacity-subtle variable for popup button

https://gerrit.wikimedia.org/r/829019

gerritbot added a project: Patch-For-Review.Sep 1 2022, 2:36 PM

Cyndymediawiksim moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 15: The Gandhi Cap) board.Sep 1 2022, 2:41 PM

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 15: The Gandhi Cap) board.Sep 1 2022, 4:24 PM

Change 829019 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Use icon-opacity-subtle variable for popup button

https://gerrit.wikimedia.org/r/829019

Maintenance_bot removed a project: Patch-For-Review.Sep 1 2022, 4:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05).Sep 1 2022, 5:00 PM

According to Firefox's colour picker, the icon's colour is #545454.

On the infobox, the (i) icons are #6a6a6a (which we are discussing in T309828#8207564).

Test Environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (84c0bb9) 14:31, 1 September 2022.

• Prtksxna moved this task from Backlog to In Progress on the IP Info board.Sep 5 2022, 3:34 PM

• Prtksxna moved this task from Design Review 🔬 to Done Q1 2022-2023 on the Anti-Harassment (AHaT Sprint 15: The Gandhi Cap) board.Sep 6 2022, 8:50 AM

• Prtksxna closed this task as Resolved.Sep 22 2022, 3:21 PM

• Prtksxna mentioned this in T318405: IP Info Help popups aren't fully opaque.Sep 23 2022, 11:39 AM

• Prtksxna moved this task from In Progress to Closed on the IP Info board.Oct 7 2022, 4:51 AM

Use icon-opacity-subtle variable for popup buttonClosed, ResolvedPublic1 Estimated Story PointsActions