| Daimona | |
| Sep 12 2022, 9:10 PM |
| F35527565: remove and add back in address.gif | |
| Sep 21 2022, 10:18 PM |
| F35527562: enable event add and edit address.gif | |
| Sep 21 2022, 10:18 PM |
The new ce_address table should have its own abstraction, which is responsible for reads and writes. For now we only really need the "writes" part, since addresses are only read when looking up events, and for performance this should happen in a single query within EventStore. Potential interface:
interface AddressStore { /** * Given a full address, returns its ID in the ce_address table, creating a new record if necessary. */ public function acquireFullAddressID( string $address ): int; }
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add an abstraction for the ce_address table | mediawiki/extensions/CampaignEvents | master | +139 -38 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T362881 [EPIC] Improvements to Event List | |||
| Open | None | T362887 Add location filter of in person events to Event List | |||
| Open | None | T316126 [EPIC] Attach programmatic geolocation to campaign events | |||
| Resolved | Daimona | T317581 Add an abstraction for the ce_address table |
Change 833105 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Add an abstraction for the ce_address table
Change 833105 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Add an abstraction for the ce_address table
@vaughnwalters I think there isn't much for you to test here. Essentially, just make sure that if you create or edit an event, you can add, change, and remove the address without crashes or other obvious bugs. Just a quick test should suffice.
✅ This is functioning correctly. Sending to product sign off.
Enable event, add address and edit address:
Remove address and add address back in
As shown in the tests done by Vaughn, this work did not lead to crashes or bugs, and there is no other directly user-facing work to test, so I'm marking this work as Done.