ffmpeg stderr Capture area 1920x1080 at position 0.0 outside the screen size 1280x1024
Closed, ResolvedPublic
Actions

Description

jobs: selenium-daily-beta-MediaWiki and selenium-daily-betacommons-MediaWiki
error in the console output:

[0-0] ffmpeg stderr: [x11grab @ 0x5558b9aa9300] Capture area 1920x1080 at position 0.0 outside the screen size 1280x1024
[0-0] ffmpeg stderr: :94: Invalid argument
[0-2] ffmpeg stderr: [x11grab @ 0x56196e0c6300] Capture area 1920x1080 at position 0.0 outside the screen size 1280x1024
[0-2] ffmpeg stderr: :94: Invalid argument

caused by 818403
the biggest problem is that the videos of test runs are not created
the last build with videos is 1178
the first build without videos is 1179
not only daily jobs are affected, for example a recent core patch 831231 also has the same error message (wmf-quibble-selenium-php72-docker/169397)

Details

Subject	Repo	Branch	Lines +/-
wdio-mediawiki: Release 2.3.0	mediawiki/core	master	+10 -1
Revert "selenium: Default to larger window size"	mediawiki/core	master	+2 -5
selenium: Fix video recording	mediawiki/extensions/CampaignEvents	master	+8 -8
WIP selenium: ffmpeg stderr Capture area 1920x1080 at position 0.0 outside the screen size 1280x1024	mediawiki/core	master	+0 -1

Customize query in gerrit

Related Objects

Mentioned In: rUCAM7b3bda17126a: selenium: Fix video recording
T314115: selenium: Default to larger window size

Event Timeline

zeljkofilipin created this task.Sep 15 2022, 1:26 PM

zeljkofilipin moved this task from Inbox to Selenium on the MediaWiki-Core-Tests board.

zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.

zeljkofilipin updated the task description. (Show Details)Sep 15 2022, 1:29 PM

zeljkofilipin updated the task description. (Show Details)Sep 15 2022, 1:41 PM

zeljkofilipin updated the task description. (Show Details)Sep 15 2022, 1:44 PM

zeljkofilipin updated the task description. (Show Details)Sep 15 2022, 1:47 PM

Well done on spotting the root cause ( https://gerrit.wikimedia.org/r/c/mediawiki/core/+/818403/4/tests/selenium/wdio-mediawiki/index.js ) which does:

tests/selenium/wdio-mediawiki/index.js

		ffmpeg = spawn( 'ffmpeg', [
			'-f', 'x11grab', //  grab the X11 display
-			-video_size', '1280x1024', // video size
+			'-video_size', '1920x1080', // video size

Which got released in wdio-mediawiki 2.2.0.

Xvfb default is:

-screen screennum WxHxD
    This option creates screen screennum and sets its width, height, and depth to W,
    H,  and D respectively.  By default, only screen 0 exists and has the dimensions
    1280x1024x24.

Our CI images in integration/config either use those default or have it explicitly mentioned:

$ git grep Xvfb.*-screen
dockerfiles/node12-test-browser/run-with-xvfb.sh:/usr/bin/Xvfb "$DISPLAY" -screen 0 1280x1024x24 -ac -nolisten tcp &
dockerfiles/node14-test-browser/run-with-xvfb.sh:/usr/bin/Xvfb "$DISPLAY" -screen 0 1280x1024x24 -ac -nolisten tcp &
dockerfiles/node16-test-browser/run-with-xvfb.sh:/usr/bin/Xvfb "$DISPLAY" -screen 0 1280x1024x24 -ac -nolisten tcp &

So for the affected repo you could revert the wdio-mediawiki 2.2.0 upgrade.

A potential way to fix it is to have the lib capture the full screen and thus drop -video_size 1920x1080 entirely.

Note the size is also mentioned at:

tests/selenium/README.md:    Xvfb "$DISPLAY" -screen 0 1920x1080x24 &

zeljkofilipin moved this task from Deep work 🌊 to Q4 👔 on the User-zeljkofilipin board.Sep 30 2022, 8:30 AM

zeljkofilipin claimed this task.Oct 19 2022, 4:16 PM

zeljkofilipin triaged this task as High priority.

zeljkofilipin moved this task from Q4 👔 to Deep work 🌊 on the User-zeljkofilipin board.

Change 849060 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] WIP selenium: ffmpeg stderr Capture area 1920x1080 at position 0.0 outside the screen size 1280x1024

https://gerrit.wikimedia.org/r/849060

gerritbot added a project: Patch-For-Review.Oct 25 2022, 12:25 PM

In T317879#8240762, @hashar wrote:

A potential way to fix it is to have the lib capture the full screen and thus drop -video_size 1920x1080 entirely.

I've tried this in 849060 and the video is indeed recorded again, but unfortunately only in 640 × 480.

Example:

BlankPage-should-have-its-title-%40daily-2022-10-25T12-27-35-578Z.mp425 KBDownload

Change 849060 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: ffmpeg stderr Capture area 1920x1080 at position 0.0 outside the screen size 1280x1024

Reason:

https://gerrit.wikimedia.org/r/849060

Looks like wdio-mediawiki v2.2.0 is used only in core and CampaignEvents.

Change 849087 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/extensions/CampaignEvents@master] selenium: Fix video recording

https://gerrit.wikimedia.org/r/849087

zeljkofilipin added subscribers: kostajh, vaughnwalters.Oct 25 2022, 12:43 PM

Change 849073 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] Revert "selenium: Default to larger window size"

https://gerrit.wikimedia.org/r/849073

zeljkofilipin added a subscriber: pwangai.Oct 25 2022, 12:51 PM

zeljkofilipin mentioned this in T314115: selenium: Default to larger window size.Oct 25 2022, 12:55 PM

Change 849087 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] selenium: Fix video recording

https://gerrit.wikimedia.org/r/849087

zeljkofilipin mentioned this in rUCAM7b3bda17126a: selenium: Fix video recording.Oct 25 2022, 1:03 PM

zeljkofilipin changed the task status from Open to In Progress.Oct 25 2022, 1:11 PM

Change 849073 merged by jenkins-bot:

[mediawiki/core@master] Revert "selenium: Default to larger window size"

https://gerrit.wikimedia.org/r/849073

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2022, 1:30 PM

zeljkofilipin closed this task as Resolved.Oct 25 2022, 1:46 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 25 2022, 2:00 PM

Change 959812 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/core@master] wdio-mediawiki: Release 2.3.0

https://gerrit.wikimedia.org/r/959812

gerritbot added a project: Patch-For-Review.Sep 21 2023, 5:09 PM

Change 959812 merged by jenkins-bot: