Page MenuHomePhabricator
Create Task
Maniphest T318462

IP Info shouldn't be aware of revision if user doesn't have access to it
Closed, ResolvedPublicBUG REPORT
Actions

Description

from T309366: Investigate: IP info not shown when all IP's edits are deleted

Related Objects

Event Timeline

• Prtksxna created this task.Sep 24 2022, 5:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2022, 5:39 AM
• Prtksxna mentioned this in T309366: Investigate: IP info not shown when all IP's edits are deleted.Sep 24 2022, 5:53 AM
• Prtksxna triaged this task as High priority.Nov 1 2022, 3:57 AM
Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Nov 7 2022, 1:48 PM
Cyndymediawiksim claimed this task.Nov 22 2022, 6:16 AM
Cyndymediawiksim moved this task from Triage/To be Estimated to AHaT Sprint 19: The Sanbenito on the Anti-Harassment board.
Cyndymediawiksim edited projects, added Anti-Harassment (AHaT Sprint 19: The Sanbenito); removed Anti-Harassment.
Cyndymediawiksim moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 19: The Sanbenito) board.
ARamirez_WMF edited projects, added Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat); removed Anti-Harassment (AHaT Sprint 19: The Sanbenito).Nov 22 2022, 6:26 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat) board.
Tchanders moved this task from In Progress 💪 to Needs Design/Product 🎨 on the Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat) board.Nov 23 2022, 4:56 PM
Tchanders subscribed.

@Prtksxna I was talking with @Cyndymediawiksim about pinning down the requirements for this task, and came across a couple of things I wanted to ask about. (Also @STran may have a bit more context here.)

My understanding is that this task is to fix what was found in the original investigation (the bug is in the final bullet point):

In T309366#8153456, @STran wrote:

Tested with the following scenario:

  1. Made an edit with an IP that has never contributed to the wiki otherwise
  2. Confirmed that the revision shows up on the Special:Contributions page for the IP
  3. Reverted the edit (so that it's no longer the current revision) and deleted the revision, hiding every piece of information about it but not from admins

Confirmed that:

  • The admin who deleted the revision can still see IPInfo from the Special:Contributions page
  • Another admin could view IPInfo from the Special:Contributions page
  • Calling the API directly successfully returned data from both users
  • The revision is not considered a revision on Special:DeletedContributions
  1. Hid the edit from other admins

Confirmed that:

  • The admin who deleted the revision can still see IPInfo from the Special:Contributions page
  • Another admin could not view IPInfo from the Special:Contributions page
  • Calling the API directly successfully returned data from both users

However, I couldn't reproduce this. Was there any more to this task?

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 22: Asian Conical Hat); removed Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat).Dec 6 2022, 3:51 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Needs Design/Product 🎨 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.
ARamirez_WMF subscribed.Dec 6 2022, 6:49 PM

@STran please see if this is reproduce-able and then ping Niharika if needed.

STran closed this task as Resolved.Dec 9 2022, 3:25 AM

I attempted to reproduce this, performing the same steps as above, and was unable to. I checked which error it was triggering and for the non-suppressing admin it's throwing the ipinfo-rest-revision-no-author, which has been included in the extension for quite some time. I'm not sure if I didn't refresh my cached result from the API or if something changed elsewhere. In any case, this seems to require no additional work. I suppose I'll close this then, sorry!

Niharika moved this task from Up Next to Closed on the IP Info board.Dec 20 2022, 6:16 PM
JJMC89 mentioned this in T334625: Should IP Info work on temporary editors with no extant edits?.Apr 12 2023, 8:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits