Page MenuHomePhabricator

Quick View: Displaying article image in the quick view panel
Closed, ResolvedPublic

Description

This ticket is a followup of the following ticket T307058 and specifically on this discussion on the ticket: https://phabricator.wikimedia.org/T307058#8279372

AC:

  • Do not allow images to take up more height than available width / 0.85
  • Images are free to resize as needed for rendering below that maximum height
  • Taller images (than said maximum height) will be top-aligned & button will be cut off
  • The appropriate height will immediately be set, before the image is even loaded, to prevent content from jumping around
  • While image is being loaded, the soon-to-be-image space will be grey.

Event Timeline

CBogen renamed this task from Use Thumbnail on QuickView load and replace with high res when available to Use low resolution preview image on QuickView load and replace with high res when available.Oct 3 2022, 3:54 PM
CBogen updated the task description. (Show Details)

Change 837662 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/SearchVue@master] Set aspect ratio ahead of time & remove fixed heights

https://gerrit.wikimedia.org/r/837662

Sneha renamed this task from Use low resolution preview image on QuickView load and replace with high res when available to Quick View: Displaying article image in the quick view panel .Oct 5 2022, 2:35 PM
Sneha updated the task description. (Show Details)

Change 837662 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Set aspect ratio ahead of time & remove fixed heights

https://gerrit.wikimedia.org/r/837662

Etonkovidova subscribed.

Checked after deployment (wmf.17) to ruwiki, ptwiki, and idwiki - all works/looks according to the specs.

An example (gif) with a loading grey state (idwiki):

grey_state.gif (706×1 px, 437 KB)