Page MenuHomePhabricator
Create Task
Maniphest T319478

When a Tester runs for a Function's Implementations, automatically re-order the list of Implementations in correctness and speed order
Closed, ResolvedPublic
Actions

Description

See also T314539: When a Tester run fails for an Implementation, automatically de-approve said Implementation from its function.

When reordering, order first by whether there are failed tests or not, and then by speed.

This is in order to allows us to descope T314539 for now.

Details

SubjectRepoBranchLines +/-
Fix logging strings to be double-quotedmediawiki/extensions/WikiLambdamaster+9 -10
ApiPerformTest: Get $previousFirst from $attachedImplementationZidsmediawiki/extensions/WikiLambdamaster+1 -1
Add logging statements for implementation ordering codemediawiki/extensions/WikiLambdamaster+27 -5
Allow greater flexibility re: when implementation re-ranking occursmediawiki/extensions/WikiLambdamaster+93 -72
Fix logic that checks for results from cachemediawiki/extensions/WikiLambdamaster+6 -5
Add logging to monitor implementation ranking updatesmediawiki/extensions/WikiLambdamaster+15 -0
Fix code that checks for any results from the cachemediawiki/extensions/WikiLambdamaster+15 -3
Move UpdateImplementationsJob from API to Jobsmediawiki/extensions/WikiLambdamaster+9 -7
Automatically reorder implementations after performing testsmediawiki/extensions/WikiLambdamaster+814 -27
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Oct 5 2022, 9:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2022, 9:19 PM
Jdforrester-WMF added a parent task: T310199: Select fastest correct implementation.Oct 5 2022, 9:20 PM
DVrandecic renamed this task from When a Tester runs for a Function's Implementations, automatically re-order the list of Implementations in speed order to When a Tester runs for a Function's Implementations, automatically re-order the list of Implementations in correctness and speed order.Jan 9 2023, 8:47 PM
DVrandecic updated the task description. (Show Details)
DVrandecic mentioned this in T314539: When a Tester run fails for an Implementation, automatically de-approve said Implementation from its function.
Jdforrester-WMF assigned this task to DMartin-WMF.Jan 18 2023, 7:20 PM
gerritbot added a comment.Jan 20 2023, 6:48 AM

Change 881751 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Automatically reorder implementations after performing tests

https://gerrit.wikimedia.org/r/881751

gerritbot added a project: Patch-For-Review.Jan 20 2023, 6:48 AM
gerritbot added a comment.Feb 21 2023, 1:57 PM

Change 881751 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Automatically reorder implementations after performing tests

https://gerrit.wikimedia.org/r/881751

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Feb 21 2023, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 21 2023, 2:11 PM
gerritbot added a comment.Feb 23 2023, 11:14 PM

Change 891717 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Fix code that checks for any results from the cache

https://gerrit.wikimedia.org/r/891717

gerritbot added a project: Patch-For-Review.Feb 23 2023, 11:14 PM
gerritbot added a comment.Feb 24 2023, 3:16 AM

Change 891744 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Move UpdateImplementationsJob from API to Jobs

https://gerrit.wikimedia.org/r/891744

gerritbot added a comment.Feb 24 2023, 4:46 PM

Change 891744 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Move UpdateImplementationsJob from API to Jobs

https://gerrit.wikimedia.org/r/891744

gerritbot added a comment.Feb 24 2023, 5:53 PM

Change 891891 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Fix logic that checks for results from cache

https://gerrit.wikimedia.org/r/891891

gerritbot added a comment.Feb 24 2023, 6:14 PM

Change 891893 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Add logging to monitor implementation ranking updates

https://gerrit.wikimedia.org/r/891893

gerritbot added a comment.Feb 24 2023, 6:16 PM

Change 891717 abandoned by David Martin:

[mediawiki/extensions/WikiLambda@master] Fix code that checks for any results from the cache

Reason:

Resubmitting as 2 smaller patches

https://gerrit.wikimedia.org/r/891717

gerritbot added a comment.Feb 27 2023, 7:59 AM

Change 892354 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Allow greater flexibility re: when implementation re-ranking occurs

https://gerrit.wikimedia.org/r/892354

gerritbot added a comment.Mar 1 2023, 4:00 PM

Change 891891 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix logic that checks for results from cache

https://gerrit.wikimedia.org/r/891891

gerritbot added a comment.Mar 1 2023, 4:02 PM

Change 891893 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add logging to monitor implementation ranking updates

https://gerrit.wikimedia.org/r/891893

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.26; 2023-03-06); removed MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Mar 1 2023, 5:00 PM
gerritbot added a comment.Mar 3 2023, 9:26 PM

Change 892354 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Allow greater flexibility re: when implementation re-ranking occurs

https://gerrit.wikimedia.org/r/892354

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2023, 9:31 PM
Jdforrester-WMF moved this task from Ready: G3. Meta-data about calls to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Mar 3 2023, 9:31 PM
gerritbot added a comment.Mar 7 2023, 1:50 AM

Change 894755 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Add logging statements for implementation ordering code

https://gerrit.wikimedia.org/r/894755

gerritbot added a project: Patch-For-Review.Mar 7 2023, 1:50 AM
gerritbot added a comment.Mar 8 2023, 8:14 PM

Change 894755 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add logging statements for implementation ordering code

https://gerrit.wikimedia.org/r/894755

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2023, 8:30 PM
gerritbot added a comment.Mar 9 2023, 3:34 AM

Change 895900 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Fix logging strings to be double-quoted

https://gerrit.wikimedia.org/r/895900

gerritbot added a project: Patch-For-Review.Mar 9 2023, 3:34 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.27; 2023-03-13); removed MW-1.40-notes (1.40.0-wmf.26; 2023-03-06).Mar 9 2023, 9:00 PM
gerritbot added a comment.Mar 17 2023, 4:34 AM

Change 900524 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Get $previousFirst from $attachedImplementationZids

https://gerrit.wikimedia.org/r/900524

gerritbot added a comment.Mar 17 2023, 2:35 PM

Change 900524 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ApiPerformTest: Get $previousFirst from $attachedImplementationZids

https://gerrit.wikimedia.org/r/900524

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 17 2023, 3:00 PM
gerritbot added a comment.Mar 20 2023, 2:34 PM

Change 895900 abandoned by David Martin:

[mediawiki/extensions/WikiLambda@master] Fix logging strings to be double-quoted

Reason:

No longer needed; was addressed by a different patch

https://gerrit.wikimedia.org/r/895900

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2023, 3:11 PM
DVrandecic closed this task as Resolved.Mar 28 2023, 12:18 AM
Jdforrester-WMF mentioned this in T299176: Phase Theta – Root task.Apr 5 2023, 3:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits