Self-explanatory title.
When loading a huge list of results, some thumbnails may fail to load because they are not currently available in the size being requested.
The resize logic is flawed.
Caused by T306883.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Rescale images based on width alone | mediawiki/core | wmf/1.40.0-wmf.5 | +15 -9 | |
| Rescale images based on width alone | mediawiki/core | master | +15 -9 |
Related Objects
Related Objects
- Mentioned In
- T321006: Special:Search: "429 Too Many Requests" when number of returned search results set to more than 50
- Mentioned Here
- T321006: Special:Search: "429 Too Many Requests" when number of returned search results set to more than 50
T306883: [L] Searchers see thumbnails next to search results on the special:search page
Event Timeline
Comment Actions
Change 841120 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/core@master] Rescale images based on width alone
Comment Actions
Change 841120 merged by jenkins-bot:
[mediawiki/core@master] Rescale images based on width alone
Comment Actions
Change 841515 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/core@wmf/1.40.0-wmf.5] Rescale images based on width alone
Comment Actions
Change 841515 merged by jenkins-bot:
[mediawiki/core@wmf/1.40.0-wmf.5] Rescale images based on width alone
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-10-12T07:19:49Z] <mlitn@deploy1002> Started scap: Backport for [[gerrit:841515|Rescale images based on width alone (T320406)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-10-12T07:20:19Z] <mlitn@deploy1002> mlitn and mlitn: Backport for [[gerrit:841515|Rescale images based on width alone (T320406)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-10-12T07:25:09Z] <mlitn@deploy1002> Finished scap: Backport for [[gerrit:841515|Rescale images based on width alone (T320406)]] (duration: 05m 19s)
Comment Actions
I'm reporting a comment from User:Pelikana (original diff on Commons):
To see if special search works well enough, I will search for "SVG" in some combinations like svg+paris and notice that a page with a file list of 500 results may take 30 seconds to load. list 500 svg results, Svg+Paris. That's too long. A more realistic search would be 500 jpg list Here the page loads fast enough but it fails to show all thumbs in one go.
Comment Actions
Checked - wmf.5 Special:Search (cross-browser check is done too).
With the number of results set to 20 -100 - the issue is not present.
The test searches
Thanks @Sannita for reporting! I looked into the issue and filed it as a separate task - T321006: Special:Search: "429 Too Many Requests" when number of returned search results set to more than 50 . The issue reported in your comment is specific to the number of of search results set by a user and, somewhat, to the complexity of the submitted query.