Page MenuHomePhabricator

On Special:log, it is impossible to select no filters on "show additional logs"
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Default additional logs are shown, instead of showing none of them.

What should have happened instead?:

It should do what the user selects

Other information (browser name/version, screenshots, etc.):

You can manually get the correct behaviour by going to https://www.mediawiki.org/wiki/Special:Log?type=&user=&page=&wpdate=&tagfilter=&wpfilters[]= it seems like once no boxes are checked, the url parameter is removed, causing it to be treated as default.

Event Timeline

This seems like it might be a general bug with HTMLMultiSelectField when the HTMLForm has a null mFormIdentifier (Or if not bug, intentional feature that is really confusing).

Change 844427 had a related patch set uploaded (by Brian Wolff; author: Brian Wolff):

[mediawiki/core@master] Call setFormIdentifier() on LogEventsList form

https://gerrit.wikimedia.org/r/844427

Change 844427 merged by jenkins-bot:

[mediawiki/core@master] Call setFormIdentifier() on LogEventsList form

https://gerrit.wikimedia.org/r/844427

Change 845753 had a related patch set uploaded (by Legoktm; author: Brian Wolff):

[mediawiki/core@REL1_39] Call setFormIdentifier() on LogEventsList form

https://gerrit.wikimedia.org/r/845753

Change 845753 merged by jenkins-bot:

[mediawiki/core@REL1_39] Call setFormIdentifier() on LogEventsList form

https://gerrit.wikimedia.org/r/845753