Maniphest T321915

poetry is not working in tox-poetry-buster:0.0.2
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	fnegri
	Oct 28 2022, 3:58 PM

Description

Builds using poetry are breaking with the new version of the tox-poetry-buster Docker image, e.g. https://gerrit.wikimedia.org/r/c/cloud/toolforge/toolforge-cli/+/850506

16:06:49 py3-unit installed: 
16:06:49 py3-unit run-test-pre: PYTHONHASHSEED='1005314786'
16:06:49 py3-unit run-test-pre: commands[0] | poetry install
16:06:49 ERROR: InvocationError for command could not find executable poetry

$ docker run --rm -it --entrypoint= docker-registry.wikimedia.org/releng/tox-poetry-buster:0.0.2 bash
nobody@f7c790cfe011:/src$ poetry
bash: poetry: command not found
nobody@f7c790cfe011:/src$ ls -l /usr/bin/poetry
lrwxrwxrwx 1 root root 22 Oct 27 09:44 /usr/bin/poetry -> /opt/poetry/bin/poetry
nobody@f7c790cfe011:/src$ ls -l /opt/poetry/
total 36
-rw-r--r-- 1 root root 32801 Jan 10  2022 get-poetry.py

This patch will likely fix it: https://gerrit.wikimedia.org/r/c/integration/config/+/850515

Details

	Subject	Repo	Branch	Lines +/-
	jjb: update tox-poetry-docker	integration/config	master	+1 -1
	tox-poetry-buster: upgrade poetry install script and upgrade to 1.2.2	integration/config	master	+951 -1 K

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		LucasWerkmeister	T320140 Migrate wd-shex-infer from Toolforge GridEngine to Toolforge Kubernetes
Resolved		matmarex	T319707 Migrate dtcheck from Toolforge GridEngine to Toolforge Kubernetes
Resolved		Legoktm	T320062 Migrate steve-adder from Toolforge GridEngine to Toolforge Kubernetes
Resolved		Legoktm	T320011 Migrate rfa-voting-history from Toolforge GridEngine to Toolforge Kubernetes
Open		dcaro	T194332 [Epic,builds-api,components-api,webservice,jobs-api] Make Toolforge a proper platform as a service with push-to-deploy and build packs
Resolved		• Bstorm	T265684 Figure out CI solution for building buildpack-based images for Toolforge
Resolved		fnegri	T317143 [tbs] Update the tekton cli package
Resolved		None	T297789 Support bullseye/python 3.9
Resolved		jbond	T289222 Add Python 3.9 to Wikimedia CI
Resolved	BUG REPORT	dcaro	T321915 poetry is not working in tox-poetry-buster:0.0.2

Event Timeline

fnegri created this task.Oct 28 2022, 3:58 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 28 2022, 3:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

fnegri mentioned this in T317143: [tbs] Update the tekton cli package.Oct 28 2022, 4:07 PM

fnegri added a parent task: T317143: [tbs] Update the tekton cli package.

Change 850515 had a related patch set uploaded (by FNegri; author: David Caro):

[integration/config@master] tox-poetry-buster: upgrade poetry install script and upgrade to 1.2.2

https://gerrit.wikimedia.org/r/850515

gerritbot added a project: Patch-For-Review.Oct 31 2022, 11:34 AM

The Docker images uses get-poetry.py without specifying any version:

RUN python3 /opt/poetry/get-poetry.py --no-modify-path

It thus tries to install the latest version available (1.2.2) which is no more supported by the get-poetry.py script:

Retrieving Poetry metadata

Version 1.2.2 does not support this installation method. Please specify a version prior to 1.2.0a1 explicitly using the '--version' option.
Please see https://python-poetry.org/blog/announcing-poetry-1-2-0a1.html#deprecation-of-the-get-poetry-py-script for more information.

And the script unhelpfully exit 0 which lets the image being build regardless of the failure :-\

Change 850515 merged by jenkins-bot:

[integration/config@master] tox-poetry-buster: upgrade poetry install script and upgrade to 1.2.2

https://gerrit.wikimedia.org/r/850515

Change 852153 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update tox-poetry-docker

https://gerrit.wikimedia.org/r/852153

https://gerrit.wikimedia.org/r/c/cloud/toolforge/toolforge-cli/+/850506 works now!

Thank you to have gotten rid of the get-poetry.py script ;)

Change 852153 merged by jenkins-bot: