Maniphest T322080

Error 1055: 'wikidb.mw_flow_tree_revision.tree_orig_user_ip' isn't in GROUP BY
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Reedy
	Oct 31 2022, 9:20 PM

Description

[4126bf212989950746d4a880] /w/index.php?title=Special:Nuke&target=Reedy Wikimedia\Rdbms\DBQueryError: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading or after adding a new extension?

Please see https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:Upgrading and https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:How_to_debug for more information.

Error 1055: 'wikidb.mw_flow_tree_revision.tree_orig_user_ip' isn't in GROUP BY
Function: Flow\Hooks::onNukeGetNewPages
Query: SELECT MAX(r.rev_id) AS `revId`,tree_orig_user_ip AS `userIp`,tree_orig_user_id AS `userId` FROM `mw_flow_revision` `r` JOIN `mw_flow_tree_revision` ON ((r.rev_type_id=tree_rev_descendant_id)) JOIN `mw_flow_workflow` ON ((r.rev_type_id=workflow_id)) WHERE tree_parent_id IS NULL AND r.rev_type = 'post' AND workflow_wiki = 'wikidb-mw_' AND (workflow_id > ' ����\0\0\0\0\0') AND tree_orig_user_id = 1 GROUP BY r.rev_type_id

Backtrace:

from /var/www/wiki/mediawiki/core/includes/libs/rdbms/database/Database.php(1558)
#0 /var/www/wiki/mediawiki/core/includes/libs/rdbms/database/Database.php(1542): Wikimedia\Rdbms\Database->getQueryException()
#1 /var/www/wiki/mediawiki/core/includes/libs/rdbms/database/Database.php(1516): Wikimedia\Rdbms\Database->getQueryExceptionAndLog()
#2 /var/www/wiki/mediawiki/core/includes/libs/rdbms/database/Database.php(892): Wikimedia\Rdbms\Database->reportQueryError()
#3 /var/www/wiki/mediawiki/core/includes/libs/rdbms/database/Database.php(1648): Wikimedia\Rdbms\Database->query()
#4 /var/www/wiki/mediawiki/core/includes/libs/rdbms/database/DBConnRef.php(119): Wikimedia\Rdbms\Database->select()
#5 /var/www/wiki/mediawiki/core/includes/libs/rdbms/database/DBConnRef.php(338): Wikimedia\Rdbms\DBConnRef->__call()
#6 /var/www/wiki/mediawiki/extensions/Flow/includes/Hooks.php(1837): Wikimedia\Rdbms\DBConnRef->select()
#7 /var/www/wiki/mediawiki/core/includes/HookContainer/HookContainer.php(338): Flow\Hooks::onNukeGetNewPages()
#8 /var/www/wiki/mediawiki/core/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook()
#9 /var/www/wiki/mediawiki/extensions/Nuke/includes/Hooks/NukeHookRunner.php(46): MediaWiki\HookContainer\HookContainer->run()
#10 /var/www/wiki/mediawiki/extensions/Nuke/includes/SpecialNuke.php(356): MediaWiki\Extension\Nuke\Hooks\NukeHookRunner->onNukeGetNewPages()
#11 /var/www/wiki/mediawiki/extensions/Nuke/includes/SpecialNuke.php(166): MediaWiki\Extension\Nuke\SpecialNuke->getNewPages()
#12 /var/www/wiki/mediawiki/extensions/Nuke/includes/SpecialNuke.php(97): MediaWiki\Extension\Nuke\SpecialNuke->listForm()
#13 /var/www/wiki/mediawiki/core/includes/specialpage/SpecialPage.php(700): MediaWiki\Extension\Nuke\SpecialNuke->execute()
#14 /var/www/wiki/mediawiki/core/includes/specialpage/SpecialPageFactory.php(1451): SpecialPage->run()
#15 /var/www/wiki/mediawiki/core/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#16 /var/www/wiki/mediawiki/core/includes/MediaWiki.php(904): MediaWiki->performRequest()
#17 /var/www/wiki/mediawiki/core/includes/MediaWiki.php(562): MediaWiki->main()
#18 /var/www/wiki/mediawiki/core/index.php(50): MediaWiki->run()
#19 /var/www/wiki/mediawiki/core/index.php(46): wfIndexMain()
#20 {main}

Details

Subject	Repo	Branch	Lines +/-
Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY	mediawiki/extensions/Flow	REL1_43	+5 -4
Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY	mediawiki/extensions/Flow	REL1_42	+5 -4
Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY	mediawiki/extensions/Flow	REL1_39	+5 -4
Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY	mediawiki/extensions/Flow	REL1_41	+5 -4
Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY	mediawiki/extensions/Flow	master	+5 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T340453 [Epic] FY 2023-24 Growth Maintenance Work
Stalled	None	T108255 Enable MariaDB/MySQL's Strict Mode
Declined	None	T322080 Error 1055: 'wikidb.mw_flow_tree_revision.tree_orig_user_ip' isn't in GROUP BY

Event Timeline

Reedy created this task.Oct 31 2022, 9:20 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 31 2022, 9:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Nov 5 2022, 5:19 AM

Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Moving to main team board, unless this is something you think we need to deal with urgently @Tgr.

kostajh moved this task from Inbox to Needs Discussion on the Growth-Team board.Nov 10 2022, 2:48 PM

The stack trace suggests this breaks Special:Nuke functionality, probably meaning if a vandal makes any Flow edit, Nuke cannot be used to automatically revert their edits, so this is a low-level vulnerability IMO and should be fixed within a reasonable amount of time. And it's probably an easy fix, we just need to add a bunch of fields to the GROUP BY.

In T322080#8388682, @Tgr wrote:

The stack trace suggests this breaks Special:Nuke functionality, probably meaning if a vandal makes any Flow edit, Nuke cannot be used to automatically revert their edits, so this is a low-level vulnerability IMO and should be fixed within a reasonable amount of time. And it's probably an easy fix, we just need to add a bunch of fields to the GROUP BY.

Adding to our Growth maintenance epic, and @DMburugu could help decide when we want to work on this.

DMburugu edited parent tasks, added: T340453: [Epic] FY 2023-24 Growth Maintenance Work; removed: T311850: [Epic] FY 2022-23 Growth Maintenance Work.Jun 26 2023, 4:48 PM

Reedy added a parent task: T108255: Enable MariaDB/MySQL's Strict Mode.Jun 26 2023, 4:51 PM

KStoller-WMF removed a project: Growth-Team.Mar 22 2024, 5:38 PM

I just installed Flow locally and tested this for an account with both Flow edits and page creations. The flow 'page creations' do not display in the list, but no error is generated and other pages can be deleted as expected.

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptMay 4 2024, 11:27 AM

Declining per above. Please feel free to re-open if this is still an issue.

Reedy mentioned this in T377440: Error 1055: '{db}.flow_tree_revision.tree_orig_user_ip' isn't in GROUP BY.Oct 17 2024, 12:52 PM

In T322080#9770322, @Samwalton9-WMF wrote:

I just installed Flow locally and tested this for an account with both Flow edits and page creations. The flow 'page creations' do not display in the list, but no error is generated and other pages can be deleted as expected.

T377440: Error 1055: '{db}.flow_tree_revision.tree_orig_user_ip' isn't in GROUP BY as a dupe. Probably because mysql strict mode isn't enabled (as per the default) in your wiki :)

Change #1081190 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Flow@master] Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY

https://gerrit.wikimedia.org/r/1081190

gerritbot added a project: Patch-For-Review.Oct 17 2024, 3:20 PM

Change #1081190 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY

https://gerrit.wikimedia.org/r/1081190

Change #1084744 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Flow@REL1_43] Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY

https://gerrit.wikimedia.org/r/1084744

Change #1084745 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Flow@REL1_42] Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY

https://gerrit.wikimedia.org/r/1084745

Change #1084746 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Flow@REL1_41] Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY

https://gerrit.wikimedia.org/r/1084746

Change #1084747 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Flow@REL1_39] Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY

https://gerrit.wikimedia.org/r/1084747

Change #1084746 merged by jenkins-bot:

[mediawiki/extensions/Flow@REL1_41] Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY

https://gerrit.wikimedia.org/r/1084746

Change #1084747 merged by jenkins-bot:

[mediawiki/extensions/Flow@REL1_39] Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY

https://gerrit.wikimedia.org/r/1084747

Change #1084745 merged by jenkins-bot:

[mediawiki/extensions/Flow@REL1_42] Hooks::onNukeGetNewPages() Add tree_orig_user_ip to GROUP BY

https://gerrit.wikimedia.org/r/1084745

Change #1084744 merged by jenkins-bot: