Page MenuHomePhabricator
Create Task
Maniphest T322091

[S] [betalabs - mobile] "Search Result Previews" intro tour is visible with horizontal scrolling
Closed, ResolvedPublic
Actions

Description

The issue is reproducible in browser emulators and on real devices.

Steps to reproduce:

  1. As a user who's never seen the intro tour on Special:Search page, go to https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Search&fulltext=1&ns0=1&profile=default&search=cat.
  2. The search results will be displayed without thumbnails - CORRECT.
  3. Perform horizontal scrolling - the intro tour "Search Result Previews" will be displayed.

(click on the anumated gif)

intro_tour_special_search.gif (806×381 px, 568 KB)

Once dismissed, the horizontal scrolling will be gone; users will not have access to QuickView features - all works as expected.

Details

SubjectRepoBranchLines +/-
Temporary hide tutorial popup for mobile wikimediawiki/extensions/SearchVuemaster+37 -17
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Oct 31 2022, 11:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2022, 11:37 PM
Etonkovidova renamed this task from [betalabs = mobile] "Search Result Previews" intro tour is visible with horizonatl scrolling to [betalabs - mobile] "Search Result Previews" intro tour is visible with horizonatl scrolling.Oct 31 2022, 11:37 PM
Etonkovidova mentioned this in T314963: [S] Ensure that mobile search results are not affected by desktop QuickView.
Etonkovidova renamed this task from [betalabs - mobile] "Search Result Previews" intro tour is visible with horizonatl scrolling to [betalabs - mobile] "Search Result Previews" intro tour is visible with horizontal scrolling.Nov 1 2022, 2:02 AM
CBogen edited projects, added SDAW-Search-Improvements (Milestone 2: QuickView MVP), Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Nov 1 2022, 1:07 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
CBogen renamed this task from [betalabs - mobile] "Search Result Previews" intro tour is visible with horizontal scrolling to [S] [betalabs - mobile] "Search Result Previews" intro tour is visible with horizontal scrolling.Nov 2 2022, 4:44 PM
CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Nov 2 2022, 5:42 PM
SimoneThisDot added a comment.Nov 14 2022, 12:34 PM

The tutorial was not developed for Mobile yet.

There is a ticket (ready for estimation of the time of commenting): https://phabricator.wikimedia.org/T321636

SimoneThisDot added a comment.Nov 16 2022, 11:14 AM

@Etonkovidova considering my previous message, are you ok to close this?

vadim-kovalenko added a comment.Dec 8 2022, 12:55 PM

Mobile tutorial popup has been created here: https://phabricator.wikimedia.org/T321951

CBogen added a comment.Dec 8 2022, 3:41 PM

I believe the problem here is that while search preview is deployed to desktop but not yet to mobile (e.g, between Dec 12 and Jan 16), the tutorial should not be showing up at all on mobile.

vadim-kovalenko claimed this task.Dec 9 2022, 6:01 AM
vadim-kovalenko added a comment.Dec 9 2022, 6:04 AM
This comment was removed by vadim-kovalenko.
vadim-kovalenko moved this task from Ready for Development to Needs QA on the Structured-Data-Backlog (Current Work) board.Dec 9 2022, 6:05 AM
vadim-kovalenko moved this task from Needs QA to Doing on the Structured-Data-Backlog (Current Work) board.Dec 9 2022, 6:07 AM
gerritbot added a comment.Dec 9 2022, 12:18 PM

Change 866452 had a related patch set uploaded (by Vadim Kovalenko; author: Vadim Kovalenko):

[mediawiki/extensions/SearchVue@master] Temporary hide tutorial popup for mobile wiki

https://gerrit.wikimedia.org/r/866452

gerritbot added a project: Patch-For-Review.Dec 9 2022, 12:18 PM
gerritbot added a comment.Dec 9 2022, 1:05 PM

Change 866452 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Temporary hide tutorial popup for mobile wiki

https://gerrit.wikimedia.org/r/866452

SimoneThisDot mentioned this in rESVU7075e0230a85: Temporary hide tutorial popup for mobile wiki.Dec 9 2022, 1:05 PM
vadim-kovalenko moved this task from Doing to Needs QA on the Structured-Data-Backlog (Current Work) board.Dec 9 2022, 1:06 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 9 2022, 1:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 9 2022, 2:01 PM
Etonkovidova closed this task as Resolved.Dec 12 2022, 8:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL