LogicException: MentorStore::isMenteeActive was called, but GEMentorshipUseIsActiveFlag is false
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Nov 7 2022, 12:44 PM

Description

Error

mwversion: 1.40.0-wmf.8
reqId: 62b0e281-f109-4842-847a-40a3e05905fd
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   LogicException: MentorStore::isMenteeActive was called, but GEMentorshipUseIsActiveFlag is false

exception.trace

from /srv/mediawiki/php-1.40.0-wmf.8/extensions/GrowthExperiments/includes/Mentorship/Store/DatabaseMentorStore.php(261)
#0 /srv/mediawiki/php-1.40.0-wmf.8/extensions/GrowthExperiments/includes/Mentorship/Store/MentorStore.php(299): GrowthExperiments\Mentorship\Store\DatabaseMentorStore->isMenteeActiveUncached(User)
#1 /srv/mediawiki/php-1.40.0-wmf.8/includes/libs/objectcache/wancache/WANObjectCache.php(1688): GrowthExperiments\Mentorship\Store\MentorStore->GrowthExperiments\Mentorship\Store\{closure}(boolean, integer, array, NULL, array)
#2 /srv/mediawiki/php-1.40.0-wmf.8/includes/libs/objectcache/wancache/WANObjectCache.php(1521): WANObjectCache->fetchOrRegenerate(string, integer, Closure, array, array)
#3 /srv/mediawiki/php-1.40.0-wmf.8/extensions/GrowthExperiments/includes/Mentorship/Store/MentorStore.php(300): WANObjectCache->getWithSetCallback(string, integer, Closure)
#4 /srv/mediawiki/php-1.40.0-wmf.8/extensions/GrowthExperiments/includes/Mentorship/Store/DatabaseMentorStore.php(284): GrowthExperiments\Mentorship\Store\MentorStore->isMenteeActive(User)
#5 /srv/mediawiki/php-1.40.0-wmf.8/extensions/GrowthExperiments/includes/Mentorship/Hooks/MentorHooks.php(166): GrowthExperiments\Mentorship\Store\DatabaseMentorStore->markMenteeAsActive(User)
#6 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/MWCallableUpdate.php(38): GrowthExperiments\Mentorship\Hooks\MentorHooks->GrowthExperiments\Mentorship\Hooks\{closure}()
#7 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdates.php(474): MWCallableUpdate->doUpdate()
#8 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdates.php(399): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#9 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdates.php(214): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, MediaWiki\JobQueue\JobQueueGroupFactory, string)
#10 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#11 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#12 /srv/mediawiki/php-1.40.0-wmf.8/includes/deferred/DeferredUpdates.php(235): DeferredUpdatesScope->processUpdates(integer, Closure)
#13 /srv/mediawiki/php-1.40.0-wmf.8/includes/MediaWiki.php(1105): DeferredUpdates::doUpdates()
#14 /srv/mediawiki/php-1.40.0-wmf.8/includes/MediaWiki.php(839): MediaWiki->restInPeace()
#15 /srv/mediawiki/php-1.40.0-wmf.8/api.php(125): MediaWiki->doPostOutputShutdown()
#16 /srv/mediawiki/php-1.40.0-wmf.8/api.php(45): wfApiMain()
#17 /srv/mediawiki/w/api.php(3): require(string)
#18 {main}

Impact

None, logspam.

Notes

Details

Request URL: https://he.wikipedia.org/w/api.php

	Subject	Repo	Branch	Lines +/-
	MentorHooks: Add missing check for GEMentorshipUseIsActiveFlag	mediawiki/extensions/GrowthExperiments	wmf/1.40.0-wmf.8	+4 -1
	MentorHooks: Add missing check for GEMentorshipUseIsActiveFlag	mediawiki/extensions/GrowthExperiments	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned In: T321382: When a mentor is removed via Speical:ManageMentors, no mentees are reassigned
Mentioned Here: T321382: When a mentor is removed via Speical:ManageMentors, no mentees are reassigned

Event Timeline

Urbanecm_WMF created this task.Nov 7 2022, 12:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2022, 12:44 PM

Change 853993 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorHooks: Add missing check for GEMentorshipUseIsActiveFlag

https://gerrit.wikimedia.org/r/853993

gerritbot added a project: Patch-For-Review.Nov 7 2022, 12:47 PM

Urbanecm_WMF changed the task status from Open to In Progress.Nov 7 2022, 12:50 PM

Urbanecm_WMF triaged this task as High priority.

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 853537 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] MentorHooks: Add missing check for GEMentorshipUseIsActiveFlag

https://gerrit.wikimedia.org/r/853537

Change 853993 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorHooks: Add missing check for GEMentorshipUseIsActiveFlag

https://gerrit.wikimedia.org/r/853993

Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Nov 7 2022, 1:15 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 7 2022, 2:00 PM

Change 853537 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] MentorHooks: Add missing check for GEMentorshipUseIsActiveFlag

https://gerrit.wikimedia.org/r/853537

Mentioned in SAL (#wikimedia-operations) [2022-11-07T14:21:54Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:853537|MentorHooks: Add missing check for GEMentorshipUseIsActiveFlag (T322538)]], [[gerrit:853955|Rename QuitMentorship to ReassignMentees (T321382)]], [[gerrit:853956|ReassignMentees: Pass the actual performer to ChangeMentor (T321382)]], [[gerrit:853957|ManageMentorsRemoveMentor: Reassign mentees to a different mentor (T321382)]]

Stashbot mentioned this in T321382: When a mentor is removed via Speical:ManageMentors, no mentees are reassigned.Nov 7 2022, 2:21 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-07T14:26:40Z] <urbanecm@deploy1002> urbanecm and urbanecm: Backport for [[gerrit:853537|MentorHooks: Add missing check for GEMentorshipUseIsActiveFlag (T322538)]], [[gerrit:853955|Rename QuitMentorship to ReassignMentees (T321382)]], [[gerrit:853956|ReassignMentees: Pass the actual performer to ChangeMentor (T321382)]], [[gerrit:853957|ManageMentorsRemoveMentor: Reassign mentees to a different mentor (T321382)]] synced to the testse

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2022, 2:30 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-07T14:36:51Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:853537|MentorHooks: Add missing check for GEMentorshipUseIsActiveFlag (T322538)]], [[gerrit:853955|Rename QuitMentorship to ReassignMentees (T321382)]], [[gerrit:853956|ReassignMentees: Pass the actual performer to ChangeMentor (T321382)]], [[gerrit:853957|ManageMentorsRemoveMentor: Reassign mentees to a different mentor (T321382)]] (duration: 14m 56s)