Page MenuHomePhabricator
Create Task
Maniphest T321382

When a mentor is removed via Speical:ManageMentors, no mentees are reassigned
Closed, ResolvedPublicBUG REPORT
Actions

Description

Split from T310292#8334610:

In T310292#8334610, @Etonkovidova wrote:

(1) On testwiki wmf.6 removing a mentor (click on Remove on Special:ManageMentors page and then Submit) doesn't re-assign mentees to another mentor.

Steps

  • Zilant18 is a mentor for Zilant1
  • Admin removed Zilant18 from the mentor list
  • Zilant18 doesn't see the Mentor dashboard (only Assign as a mentor) - this action is immediate
  • Zilant1 still sees Zilant18 as an assigned mentor after >3 hours after the action

This is an error in ManageMentorsRemoveMentor::onSubmit method; the call to reassign mentees is missing. Perhaps worth creating an abstraction above StructuredMentorWriter, which would do all the actions that are usually done on mentor removal?

For now, let's just add the missing call to ManageMentorsRemoveMentor::onSubmit.

Details

SubjectRepoBranchLines +/-
ManageMentorsRemoveMentor: Reassign mentees to a different mentormediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.8+83 -11
ReassignMentees: Pass the actual performer to ChangeMentormediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.8+29 -3
Rename QuitMentorship to ReassignMenteesmediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.8+74 -74
ManageMentorsRemoveMentor: Reassign mentees to a different mentormediawiki/extensions/GrowthExperimentsmaster+83 -11
ReassignMentees: Pass the actual performer to ChangeMentormediawiki/extensions/GrowthExperimentsmaster+29 -3
Rename QuitMentorship to ReassignMenteesmediawiki/extensions/GrowthExperimentsmaster+74 -74
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Oct 21 2022, 10:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2022, 10:09 AM
Urbanecm_WMF claimed this task.Oct 21 2022, 10:09 AM
Urbanecm_WMF triaged this task as High priority.
Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Oct 21 2022, 10:15 AM
gerritbot added a comment.Oct 21 2022, 10:19 AM

Change 845473 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] ManageMentorsRemoveMentor: Reassign mentees to a different mentor

https://gerrit.wikimedia.org/r/845473

gerritbot added a project: Patch-For-Review.Oct 21 2022, 10:19 AM
Urbanecm_WMF added a parent task: T272376: Make it possible for admin to remove a mentor when they quit/are blocked.Oct 21 2022, 10:20 AM
Trizek-WMF subscribed.Oct 21 2022, 10:40 AM
Urbanecm_WMF changed the task status from Open to In Progress.Oct 21 2022, 11:02 AM
Urbanecm_WMF mentioned this in T310292: Allow admins to forcibly set a mentor's status.
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm_WMF moved this task from Code Review to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 30 2022, 4:57 PM
gerritbot added a comment.Oct 30 2022, 5:02 PM

Change 850667 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Rename QuitMentorship to ReassignMentees

https://gerrit.wikimedia.org/r/850667

gerritbot added a comment.Oct 30 2022, 5:09 PM

Change 850668 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] ReassignMentees: Pass the actual performer to ChangeMentor

https://gerrit.wikimedia.org/r/850668

Urbanecm_WMF moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 30 2022, 7:07 PM
Urbanecm_WMF mentioned this in T321884: Remove mentees from "not-mentors" in ruwiki.Oct 31 2022, 6:35 AM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 4 2022, 4:31 AM
gerritbot added a comment.Nov 4 2022, 4:49 AM

Change 850667 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Rename QuitMentorship to ReassignMentees

https://gerrit.wikimedia.org/r/850667

gerritbot added a comment.Nov 4 2022, 4:49 AM

Change 850668 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ReassignMentees: Pass the actual performer to ChangeMentor

https://gerrit.wikimedia.org/r/850668

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 4 2022, 5:00 AM
gerritbot added a comment.Nov 4 2022, 5:11 AM

Change 845473 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ManageMentorsRemoveMentor: Reassign mentees to a different mentor

https://gerrit.wikimedia.org/r/845473

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2022, 5:30 AM
Urbanecm_WMF changed the task status from In Progress to Open.Nov 7 2022, 8:44 AM
Urbanecm_WMF moved this task from In Progress to Ready for QA on the GrowthExperiments-Mentorship board.Nov 7 2022, 8:51 AM
gerritbot added a comment.Nov 7 2022, 12:21 PM

Change 853955 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] Rename QuitMentorship to ReassignMentees

https://gerrit.wikimedia.org/r/853955

gerritbot added a project: Patch-For-Review.Nov 7 2022, 12:21 PM

Change 853956 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] ReassignMentees: Pass the actual performer to ChangeMentor

https://gerrit.wikimedia.org/r/853956

gerritbot added a comment.Nov 7 2022, 12:22 PM

Change 853957 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] ManageMentorsRemoveMentor: Reassign mentees to a different mentor

https://gerrit.wikimedia.org/r/853957

gerritbot added a comment.Nov 7 2022, 2:15 PM

Change 853955 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] Rename QuitMentorship to ReassignMentees

https://gerrit.wikimedia.org/r/853955

gerritbot added a comment.Nov 7 2022, 2:16 PM

Change 853956 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] ReassignMentees: Pass the actual performer to ChangeMentor

https://gerrit.wikimedia.org/r/853956

gerritbot added a comment.Nov 7 2022, 2:17 PM

Change 853957 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.8] ManageMentorsRemoveMentor: Reassign mentees to a different mentor

https://gerrit.wikimedia.org/r/853957

Stashbot mentioned this in T322538: LogicException: MentorStore::isMenteeActive was called, but GEMentorshipUseIsActiveFlag is false.Nov 7 2022, 2:21 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-07T14:21:54Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:853537|MentorHooks: Add missing check for GEMentorshipUseIsActiveFlag (T322538)]], [[gerrit:853955|Rename QuitMentorship to ReassignMentees (T321382)]], [[gerrit:853956|ReassignMentees: Pass the actual performer to ChangeMentor (T321382)]], [[gerrit:853957|ManageMentorsRemoveMentor: Reassign mentees to a different mentor (T321382)]]

Stashbot added a comment.Nov 7 2022, 2:26 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-07T14:26:40Z] <urbanecm@deploy1002> urbanecm and urbanecm: Backport for [[gerrit:853537|MentorHooks: Add missing check for GEMentorshipUseIsActiveFlag (T322538)]], [[gerrit:853955|Rename QuitMentorship to ReassignMentees (T321382)]], [[gerrit:853956|ReassignMentees: Pass the actual performer to ChangeMentor (T321382)]], [[gerrit:853957|ManageMentorsRemoveMentor: Reassign mentees to a different mentor (T321382)]] synced to the testse

Stashbot added a comment.Nov 7 2022, 2:36 PM

Mentioned in SAL (#wikimedia-operations) [2022-11-07T14:36:51Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:853537|MentorHooks: Add missing check for GEMentorshipUseIsActiveFlag (T322538)]], [[gerrit:853955|Rename QuitMentorship to ReassignMentees (T321382)]], [[gerrit:853956|ReassignMentees: Pass the actual performer to ChangeMentor (T321382)]], [[gerrit:853957|ManageMentorsRemoveMentor: Reassign mentees to a different mentor (T321382)]] (duration: 14m 56s)

Urbanecm_WMF added a subscriber: Iniquity.Nov 7 2022, 2:49 PM

This should now be deployed to production.

@Iniquity, FYI, this means that admins can now cause the reassignment via Special:ManageMentors. Example log entry. I think we talked about this issue on a different task, so that's why I'm pinging you here.

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.8; 2022-10-31); removed MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 7 2022, 3:00 PM
Urbanecm removed a project: Patch-For-Review.Nov 14 2022, 8:09 AM
KStoller-WMF closed this task as Resolved.Feb 10 2023, 12:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits