Page MenuHomePhabricator
Create Task
Maniphest T323046

Implement per-request timeout / resource consumption limits in the evaluator
Closed, ResolvedPublic
Actions

Description

Description

Ensure that evaluator processes die when their time is up

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • evaluator processes are given a timeout and end themselves with dignity when the timeout is reached

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task

Completion checklist

Details

SubjectRepoBranchLines +/-
ApiFunctionCall: Add example function call that times outmediawiki/extensions/WikiLambdamaster+36 -2
Add 15-second timeout to the evaluator.mediawiki/services/function-evaluatormaster+40 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

cmassaro created this task.Nov 14 2022, 4:51 PM
cmassaro added a parent task: T282913: Implement agreed security and control measures in the Wikifunctions system.Nov 14 2022, 4:55 PM
DVrandecic moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.Nov 15 2022, 7:37 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready: G6. Stable & secure on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 15 2022, 8:43 PM
DVrandecic subscribed.Dec 7 2022, 11:47 PM

Notes from task review meeting: Needs to be done before launch. Hard-coded (or config variable) 15sec (or whatever) value in the code with a setTimeout() call/etc. in the outer node evaluator (not the Python/JS executor) and return a timeout error instead of output.

James's estimated effort: 0.5 day (if whoever picks this up thinks that will take considerably longer, please check whether we agree on the task)

DVrandecic added a parent task: T318359: Enable the Re-Entrant Evaluator, Allowing for Two-Way Communication between `function-orchestrator` and `function-evaluator`.Dec 7 2022, 11:50 PM
cmassaro claimed this task.Dec 19 2022, 7:24 PM
gerritbot added a comment.Dec 19 2022, 8:25 PM

Change 869290 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-evaluator@master] Adds 15-second timeout to the evaluator.

https://gerrit.wikimedia.org/r/869290

gerritbot added a project: Patch-For-Review.Dec 19 2022, 8:26 PM
gerritbot added a comment.Jan 5 2023, 2:16 PM

Change 869289 had a related patch set uploaded (by Jforrester; author: Cory Massaro):

[mediawiki/extensions/WikiLambda@master] ApiFunctionCall: Add example function call that times out

https://gerrit.wikimedia.org/r/869289

gerritbot added a comment.Jan 9 2023, 1:43 PM

Change 869290 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Add 15-second timeout to the evaluator.

https://gerrit.wikimedia.org/r/869290

cmassaro mentioned this in rMSFE2c4cbbed3eb2: Add 15-second timeout to the evaluator..Jan 9 2023, 1:44 PM
Jdforrester-WMF closed this task as Resolved.Jan 9 2023, 4:51 PM
Jdforrester-WMF subscribed.

Done. Note that we'll need to pass around the remaining timeout for clean re-entrant behaviour, but that's captured in another, post-launch ticket.

gerritbot added a comment.Jan 9 2023, 6:57 PM

Change 869289 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ApiFunctionCall: Add example function call that times out

https://gerrit.wikimedia.org/r/869289

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 9 2023, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 9 2023, 7:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits