Page MenuHomePhabricator
Create Task
Maniphest T323700

[toolforge-cli][build] show fails if the pipelinerun has no 'status'
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

When runing toolforge build show on a build entry that has no status, the cli breaks with:

dcaro@vulcanus$ toolforge build show  minikube-user-buildpacks-pipelinerun-jpgbk
Traceback (most recent call last):
  File "/home/dcaro/.virtualenvs/toolforge-cli-python3/bin/toolforge", line 8, in <module>
    sys.exit(main())
  File "/home/dcaro/Work/wikimedia/toolforge-cli/toolforge_cli/cli.py", line 563, in main
    toolforge()
  File "/home/dcaro/.virtualenvs/toolforge-cli-python3/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/dcaro/.virtualenvs/toolforge-cli-python3/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/dcaro/.virtualenvs/toolforge-cli-python3/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/dcaro/.virtualenvs/toolforge-cli-python3/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/dcaro/.virtualenvs/toolforge-cli-python3/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/dcaro/.virtualenvs/toolforge-cli-python3/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/dcaro/Work/wikimedia/toolforge-cli/toolforge_cli/cli.py", line 530, in build_show
    status = next(condition for condition in run["status"]["conditions"] if condition["type"] == "Succeeded")
KeyError: 'status'

See the full run object as json here:

P40757 bad_run.json
1{
2 "apiVersion": "tekton.dev/v1beta1",
3 "kind": "PipelineRun",
4 "metadata": {
5 "creationTimestamp": "2022-11-18T12:56:53Z",
6 "generateName": "minikube-user-buildpacks-pipelinerun-",
7 "generation": 1,
8 "labels": {
9 "user": "minikube-user"
10 },
11 "managedFields": [
12 {
13 "apiVersion": "tekton.dev/v1beta1",
14 "fieldsType": "FieldsV1",
15 "fieldsV1": {
16 "f:metadata": {
17 "f:generateName": {},
18 "f:labels": {
19 ".": {},
20 "f:user": {}
21 }
22 },
23 "f:spec": {
24 ".": {},
25 "f:params": {},
26 "f:pipelineRef": {
27 ".": {},
28 "f:name": {}
29 },
30 "f:serviceAccountName": {},
31 "f:workspaces": {}
32 }
33 },
34 "manager": "python-requests",
35 "operation": "Update",
36 "time": "2022-11-18T12:56:53Z"
37 }
38 ],
39 "name": "minikube-user-buildpacks-pipelinerun-jpgbk",
40 "namespace": "image-build",
41 "resourceVersion": "200215",
42 "uid": "18427b43-4b2d-4559-b181-fd811336f3af"
43 },
44 "spec": {
45 "params": [
46 {
47 "name": "BUILDER_IMAGE",
48 "value": "docker-registry.tools.wmflabs.org/toolforge-bullseye0-builder"
49 },
50 {
51 "name": "APP_IMAGE",
52 "value": "192.168.1.111/minikube-user/dcaro:latest"
53 },
54 {
55 "name": "SOURCE_URL",
56 "value": "https://github.com/david-caro/wm-lol"
57 },
58 {
59 "name": "USER_ID",
60 "value": "61312"
61 },
62 {
63 "name": "GROUP_ID",
64 "value": "61312"
65 }
66 ],
67 "pipelineRef": {
68 "name": "buildpacks"
69 },
70 "serviceAccountName": "buildpacks-service-account",
71 "workspaces": [
72 {
73 "emptyDir": {},
74 "name": "source-ws"
75 },
76 {
77 "emptyDir": {},
78 "name": "cache-ws"
79 }
80 ]
81 }
82}

This object was created with a broken installation that did not start the runs (ex. with the tekton-controller stopped)

Details

SubjectRepoBranchLines +/-
toolforge-cli: show better messaging if the pipelinerun has no 'status'cloud/toolforge/toolforge-climain+92 -34
toolforge-cli: show better messaging if the pipelinerun has no 'status'cloud/toolforge/toolforge-climain+4 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedLucasWerkmeisterT320140 Migrate wd-shex-infer from Toolforge GridEngine to Toolforge Kubernetes
 ResolvedmatmarexT319707 Migrate dtcheck from Toolforge GridEngine to Toolforge Kubernetes
 ResolvedLegoktmT320062 Migrate steve-adder from Toolforge GridEngine to Toolforge Kubernetes
 ResolvedLegoktmT320011 Migrate rfa-voting-history from Toolforge GridEngine to Toolforge Kubernetes
 OpendcaroT194332 [Epic,builds-api,components-api,webservice,jobs-api] Make Toolforge a proper platform as a service with push-to-deploy and build packs
 ResolveddcaroT267374 [tbs.beta] Create a toolforge build service beta release
 ResolvedRaymond_NdibeT324827 tbs: user-story 3 - I want to cancel the build using the toolforge build cancel feature
 ResolvedRaymond_NdibeT324828 tbs: user-story 3 - cancel cli should give the right error when the service is down
 ResolvedRaymond_NdibeT331409 [tbs.cli] The cancel command should return a message saying that the build is already finished when trying to cancel a finished build
 ResolvedRaymond_NdibeT331410 [tbs.cli] The cancel command should show a useful message when the connection to tekton works but returns http error (requests.exceptions.HTTPError)
 ResolvedNoneT332294 [tbs][cli] build cancel --help lists the -v option twice
 ResolveddcaroT324833 tbs: user-story 5 - I want to check the status of a given build using the toolforge build show feature.
 ResolveddcaroT324830 tbs: user-story 4 - I want to check the status of the last build using the toolforge build show feature
 ResolvedRaymond_NdibeT324831 tbs: user-story 4 - show cli should give the right error when the service is down
 ResolveddcaroT324823 tbs: user-story 2 - Feature: I can start a new build from a git url
 ResolvedRaymond_NdibeT323700 [toolforge-cli][build] show fails if the pipelinerun has no 'status'
 ResolvedRaymond_NdibeT324832 tbs: user-story 4 - show cli should use the latest build if no build id is passed

Event Timeline

dcaro triaged this task as High priority.Nov 23 2022, 12:13 PM
dcaro created this task.
dcaro added a project: Toolforge Build Service.
dcaro edited projects, added Toolforge Build Service (Iteration 05); removed Toolforge Build Service.
dcaro added a parent task: T267374: [tbs.beta] Create a toolforge build service beta release.
dcaro updated the task description. (Show Details)Nov 23 2022, 12:15 PM
dcaro updated the task description. (Show Details)
Slst2020 set the point value for this task to 3.Nov 23 2022, 4:43 PM
Slst2020 subscribed.Nov 23 2022, 4:47 PM

Related task that's already been resolved: T322190

Raymond_Ndibe claimed this task.Dec 1 2022, 12:56 PM
Raymond_Ndibe added a project: User-Raymond_Ndibe.
Raymond_Ndibe moved this task from Next Up to In Progress on the Toolforge Build Service (Iteration 05) board.Dec 6 2022, 1:20 PM
gerritbot added a comment.Dec 7 2022, 11:51 AM

Change 865607 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[cloud/toolforge/toolforge-cli@main] toolforge-cli: show better messaging if the pipelinerun has no 'status'

https://gerrit.wikimedia.org/r/865607

gerritbot added a project: Patch-For-Review.Dec 7 2022, 11:51 AM
Raymond_Ndibe moved this task from Backlog to In Review on the User-Raymond_Ndibe board.Dec 7 2022, 2:15 PM
Raymond_Ndibe moved this task from In Progress to In Review on the Toolforge Build Service (Iteration 05) board.
KHernandez-WMF moved this task from Iteration 05 to Iteration 06 on the Toolforge Build Service board.Dec 7 2022, 3:25 PM
KHernandez-WMF edited projects, added Toolforge Build Service (Iteration 06); removed Toolforge Build Service (Iteration 05).
KHernandez-WMF moved this task from Next Up to In Review on the Toolforge Build Service (Iteration 06) board.
gerritbot added a comment.Dec 8 2022, 12:37 PM

Change 865607 merged by jenkins-bot:

[cloud/toolforge/toolforge-cli@main] toolforge-cli: show better messaging if the pipelinerun has no 'status'

https://gerrit.wikimedia.org/r/865607

Raymond_Ndibe mentioned this in rCTTC963752cdf7da: toolforge-cli: show better messaging if the pipelinerun has no 'status'.Dec 8 2022, 12:37 PM
gerritbot added a comment.Dec 8 2022, 7:23 PM

Change 866493 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[cloud/toolforge/toolforge-cli@main] toolforge-cli: show better messaging if the pipelinerun has no 'status'

https://gerrit.wikimedia.org/r/866493

gerritbot added a comment.Dec 8 2022, 7:27 PM

Change 866493 merged by jenkins-bot:

[cloud/toolforge/toolforge-cli@main] toolforge-cli: show better messaging if the pipelinerun has no 'status'

https://gerrit.wikimedia.org/r/866493

Raymond_Ndibe mentioned this in rCTTCda99d5f9a770: toolforge-cli: show better messaging if the pipelinerun has no 'status'.Dec 8 2022, 7:27 PM
Raymond_Ndibe closed this task as Resolved.Dec 8 2022, 7:30 PM
Raymond_Ndibe moved this task from In Review to Done on the Toolforge Build Service (Iteration 06) board.
dcaro added a parent task: T324823: tbs: user-story 2 - Feature: I can start a new build from a git url.Dec 9 2022, 10:08 AM
KHernandez-WMF mentioned this in T324823: tbs: user-story 2 - Feature: I can start a new build from a git url.Dec 15 2022, 7:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits