Page MenuHomePhabricator

Registration pop-up styling issues
Closed, ResolvedPublic

Description

  • The title in the explainer text is supposed to be lighter in color than the toggle switch label.
  • The policy language is not centered in the middle of the icon

See T318369#8401230 for details.

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptNov 29 2022, 9:21 AM

Change 861814 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Registration pop-up styling issues

https://gerrit.wikimedia.org/r/861814

Daimona renamed this task from registration pop-up styling issues to Registration pop-up styling issues.Dec 17 2022, 12:21 AM
Daimona updated the task description. (Show Details)

Change 861814 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Registration pop-up styling issues

https://gerrit.wikimedia.org/r/861814

vaughnwalters subscribed.

โœ… The title in the explainer text is supposed to be lighter in color than the toggle switch label.
โœ… The policy language is not centered in the middle of the icon

Screen Shot 2022-12-20 at 9.43.09 AM.png (250ร—946 px, 104 KB)

Screen Shot 2022-12-20 at 9.41.55 AM.png (232ร—924 px, 93 KB)

Looks good, moving to design sign off

@gonyeahialam feel free to resolve this task once your review is complete. Thanks!