This is a follow-up from T310665: Impact module: summary panel (thanks for catching this @Etonkovidova in T310665#8426469).
@RHo, to clarify, the number used next to the Thanks icon should be a link, right? (Similar to the number of edits as a link).
And we will want to instrument clicks to this link as well.
Change 862227 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] NewImpact: wrap thanks count in a link to Thanks Log
Change 862303 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[schemas/event/secondary@master] HomepageModule: document impact module link ids
Change 862303 merged by jenkins-bot:
[schemas/event/secondary@master] HomepageModule: document impact module link ids
Change 862346 had a related patch set uploaded (by Kosta Harlan; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] NewImpact: wrap thanks count in a link to Thanks Log
Change 862227 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] NewImpact: wrap thanks count in a link to Thanks Log
Change 862346 merged by Gergő Tisza:
[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.12] NewImpact: wrap thanks count in a link to Thanks Log
Mentioned in SAL (#wikimedia-operations) [2022-11-30T22:33:07Z] <tgr@deploy1002> Started scap: Backport for [[gerrit:862346|NewImpact: wrap thanks count in a link to Thanks Log (T324087)]]
Mentioned in SAL (#wikimedia-operations) [2022-11-30T22:34:18Z] <tgr@deploy1002> tgr and kharlan: Backport for [[gerrit:862346|NewImpact: wrap thanks count in a link to Thanks Log (T324087)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet
hi @kostajh - this sounds good as an interim step, assuming we will the link soon with the more newcomer-friendly and useful information in the dialog proposed in T322166: New Impact module: Thanks count dialog.
And +1 to definitely wanting to instrument clicks.
Mentioned in SAL (#wikimedia-operations) [2022-11-30T22:39:50Z] <tgr@deploy1002> Finished scap: Backport for [[gerrit:862346|NewImpact: wrap thanks count in a link to Thanks Log (T324087)]] (duration: 06m 42s)
Checked on testwiki wmf.12 - the link is in place and works as expected:
The click event is in place too:
event.HomepageModule
Object { action: "link-click", action_data: "timeframe_in_days=60;timeframe_edits_count=155;thanks_count=30;last_edit_timestamp=1661910078;longest_streak_days_count=9;top_articles_views_count=3;linkId=impact-thanks-log", user_id: 34042, user_editcount: 277, user_variant: "control", module: "impact", is_mobile: false, mode: "desktop", homepage_pageview_token: "1r2d070fm248mc6as9p53a6l757q5pmf", state: "activated" }