- stub PaymentProvider class, Api class, and config with credentials are enough for now
- Api class should at least have one function to make a curl request and add the headers mentioned here: https://docs.dlocal.com/reference/payins-security#headers (either do T324274 to get the real security header or stub that out for now).
- investigate where we might be mapping 'astropay' to 'dlocal', see if we can stop doing that (see https://phabricator.wikimedia.org/diffusion/WFSP/browse/master/Core/ProviderConfiguration.php$59)
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Add dLocal Skeleton for SmashPig | wikimedia/fundraising/SmashPig | master | +104 -0 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T274300 Upgrade Dlocal to leverage Smartfields/no redirect | |||
Resolved | jgleeson | T324273 Create DLocal PaymentProvider in SmashPig |
Event Timeline
Comment Actions
dLocal doesn't appear to have a ping-style API endpoint. I can't see a single discrete API call we can use for this ticket to confirm the API is reachable and works.
It looks like we need to do the signature work in T324274 before making any follow-on API calls, as the signature header is required for all API calls as explained here
Comment Actions
From IRC:
15:48 <jgleeson> ejegg: I just saw the desc update of the ticket. we're still missing the method to call though 15:49 <ejegg> yep, I figure we need a base method that will take a URL as an argument, then once we start implementing the API calls they will call that base method 15:50 <ejegg> does that sound right? 15:50 <ejegg> I was basing that on all the curl requests needing the same headers 15:51 <ejegg> but if there's a reason not to share the header logic we can just put that off till we implement the first API call 15:52 <jgleeson> i guess we can add the files and method although it will be untested 15:52 <jgleeson> maybe we should combine the signature work with this 15:52 <ejegg> k, sounds good 15:53 <jgleeson> we could potentially use this api call as our healthcheck call https://docs.dlocal.com/reference/get-an-exchange-rate 15:54 <jgleeson> feels like the api with the lowest bar 15:54 <jgleeson> api call* 15:54 <ejegg> cool cool, I think this one is pretty simple too: https://docs.dlocal.com/reference/search-payment-methods 15:55 <ejegg> Are we using the equivalent payment method lookup call as a health check for Adyen? 15:57 <jgleeson> yep we are
Comment Actions
I've created T324274: Implement DLocal signature calculation in SmashPig which suggests using the search payment methods call
Comment Actions
Change 875425 had a related patch set uploaded (by Jgleeson; author: Jgleeson):
[wikimedia/fundraising/SmashPig@master] Add dLocal Skeleton for SmashPig
Comment Actions
Change 875425 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Add dLocal Skeleton for SmashPig