Page MenuHomePhabricator

Remove old AstroPay code from SmashPig
Closed, ResolvedPublic4 Estimated Story Points

Description

Astropay is the old name for dLocal.

The AstroPay directory exists in Smashpig at PaymentProviders/AstroPay. We're currently integrating with the new dLocal API so let's combine the legacy AstroPay files with the new dLocal files remove the AstroPay directory when the old-style listeners contained within it are no longer receiving traffic, to make the codebase easier to work with going forward.

Event Timeline

We will need to use different logic for the old-style and new-style listeners - wouldn't it be easier to leave them in separate directories?

Are we planning to use the old-style listeners alongside the new-style?

Yep, the old-style listener will need to work for up to a month after we switch the front-end over to the new integration, as some of the payment methods take a long time to clear.

Ok, in that case, how about we update this ticket to cover the deletion of the old Astropay directory once old-style listeners no longer receive traffic?

jgleeson renamed this task from Combine AstroPay and dLocal files under Smashpig to Remove old AstroPay code from SmashPig.Jan 4 2023, 4:01 PM
jgleeson removed jgleeson as the assignee of this task.
jgleeson updated the task description. (Show Details)
Dwisehaupt set the point value for this task to 4.Jan 9 2023, 9:50 PM

Change 965774 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/SmashPig@master] Remove astropay from smashpig

https://gerrit.wikimedia.org/r/965774

XenoRyet set Final Story Points to 4.