Page MenuHomePhabricator

Inline Diff: Update visual markers for text changes
Closed, DeclinedPublic5 Estimated Story Points

Assigned To
None
Authored By
JMcLeod_WMF
Dec 8 2022, 2:13 PM
Referenced Files
F36972724: Screenshot 2023-05-02 at 20.09.36.png
May 2 2023, 6:14 PM
F36972716: Screenshot 2023-05-02 at 20.10.33.png
May 2 2023, 6:14 PM
F36508217: Group 53.png
Jan 25 2023, 7:56 PM
F36508213: Captura de pantalla (58).png
Jan 25 2023, 7:56 PM
F36291310: paragraph split inline.png
Jan 18 2023, 12:09 AM
F36291303: current exp paragraph split.png
Jan 18 2023, 12:09 AM
F36291231: inline deletion.png
Jan 18 2023, 12:09 AM
F36291249: current experience inline deletion.png
Jan 18 2023, 12:09 AM
Subscribers

Description

Feature Summary

Improving inline visual markers to be able to clearly recognize what update has been done to the text.

Use cases

  • As a viewer of the Unified Inline Wikitext Diff diff on Desktop, I am able to see a visual marker over added text, and deleted text.

Benefits

Improve UX of diff view

Details for QA

  • Make sure markup/css changes to wikidiff do not break PHP engine output
  • Add test coverage for existing functionality, if missing
  • Acceptance Criteria: This change must ensure "functionality parity" in all other diff stress tests
  • Only highlight words which have changed within a paragraph split

Designs

Text Addition: Addition stays the same as the current representation, the blue highlight will be shown.

inline addition.png (126×996 px, 21 KB)

Text Deletion: Deletion behaves the same as the current experience, it still has a yellow highlight.

Current experienceProposed design
Screenshot 2023-05-02 at 20.10.33.png (346×2 px, 114 KB)
Screenshot 2023-05-02 at 20.10.33.png (346×2 px, 114 KB)

Space addition/deletion (enter/backspace): The space in-line would be represented with a blue highlight and markup to show a line addition. For multiple enters, a new highlight with text description will be added. In case of line delete, a yellow highlight with text description will be added to show where the deletion has taken place

Current experienceProposed design
current exp paragraph split.png (129×1 px, 24 KB)
Screenshot 2023-05-02 at 20.09.36.png (384×2 px, 115 KB)

Impact

Users that able to better understand new changes/users that are new to diffs

Contact Person / Team

  • Community Tech

Related Conversations

Slack channels

  • better-diffs
  • diffs-working-group

Event Timeline

JMcLeod_WMF renamed this task from Better Diffs: Engineering and Design Requirements to Better Diffs: Engineering and Design Requirements for Inline UI.Dec 8 2022, 2:22 PM
JMcLeod_WMF updated the task description. (Show Details)
HMonroy renamed this task from Better Diffs: Engineering and Design Requirements for Inline UI to Better Diffs: Implment Design Requirements for Inline UI.Jan 12 2023, 9:32 PM
HMonroy renamed this task from Better Diffs: Implment Design Requirements for Inline UI to Better Diffs: Implement Design Requirements for Inline UI.Jan 12 2023, 9:50 PM
JFernandez-WMF renamed this task from Better Diffs: Implement Design Requirements for Inline UI to Better Diffs: In-line - visual marker changes.Jan 17 2023, 6:25 PM
JFernandez-WMF updated the task description. (Show Details)
HMonroy renamed this task from Better Diffs: In-line - visual marker changes to Inline: Visual marker changes.Feb 15 2023, 7:23 PM
HMonroy renamed this task from Inline: Visual marker changes to Inline Diff: Visual marker changes.
HMonroy renamed this task from Inline Diff: Visual marker changes to Inline Diff: Update visual markers for text deletion.May 2 2023, 6:01 PM
HMonroy updated the task description. (Show Details)
HMonroy renamed this task from Inline Diff: Update visual markers for text deletion to Inline Diff: Update visual markers for text changes.May 2 2023, 6:03 PM