@JSengupta-WMF The mockups for the inline format have been updated since we created this task. I just want to confirm that the markers for new and deleted should be as shown as in this figma screenshot:

Change 936340 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/core@master] diff: Add new or deleted line markers

https://gerrit.wikimedia.org/r/936340

@HMonroy yes the newline and delete markers in your screenshot are the latest ones.

Change 936340 merged by jenkins-bot:

[mediawiki/core@master] diff: Add new or deleted line markers

https://gerrit.wikimedia.org/r/936340

I'm wondering about how should "⟵ delete" and "↲ newline" be translated into right to left languages.

Usually, I flip the arrows when translating to Hebrew and recommend that translators to Arabic, Persian, etc., do the same.

But in this case, I guess that they are supposed to look similar to the "⟵ Delete" (a.k.a. "⟵ Backspace") and "↲ Enter" (a.k.a. "↲ Return") key on common physical keyboards. And as far as I know, these keyboard keys always show arrows that point to the left, even on keyboards that are sold in countries where right-to-left languages are spoken. (My laptop's keyboard doesn't have any arrows at all, but many keyboards do.)

So my intuition about translating these messages is that the same left-pointing arrows should be used in the translations, and they should be visually on the left end of the translation (that is, in RTL languages they will be in the end of the string and not in the beginning).

Am I overthinking it? :)

@Amire80 you are right and thanks for bringing this up. I checked a number of keyboards from different manufacturers online and looks like even for RTL languages some symbols are universal such as Enter and Backspace. So let's go with what you proposed i.e. translated text but the arrows pointing to the left and at the end of the string.

@JSengupta-WMF I don't believe it is possible to get a "<- delete" at the end of a paragraph, like shown in the above screenshot.

Rev A:

foo bar

Rev B:

foo

bar

	Rev A > Rev B	Rev B > Rev A
maxSplitSize = 1
maxSplitSize > 1

• https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User%3ADom_walden%2Fsandbox2&diff=595374&oldid=595373&diff-type=inline
• https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User%3ADom_walden%2Fsandbox2&diff=595373&oldid=595374&diff-type=inline

Mobile

The same makers will appear on mobile, but the colours don't match the red/green colour scheme:

• https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:MobileDiff/590325&diff-type=inline

RTL

Example of the markers on arwiki. Is this what you were thinking of, @JSengupta-WMF?

• https://ar.wikipedia.beta.wmflabs.org/w/index.php?title=%D9%82%D8%B1%D8%A7%D8%B1_%D9%85%D8%AC%D9%84%D8%B3_%D8%A7%D9%84%D8%A3%D9%85%D9%86_%D8%A7%D9%84%D8%AA%D8%A7%D8%A8%D8%B9_%D9%84%D9%84%D8%A3%D9%85%D9%85_%D8%A7%D9%84%D9%85%D8%AA%D8%AD%D8%AF%D8%A9_%D8%B1%D9%82%D9%85_1226&diff=prev&oldid=3365&diff-type=inline&uselang=ar
• https://ar.wikipedia.beta.wmflabs.org/w/index.php?title=%D9%82%D8%B1%D8%A7%D8%B1_%D9%85%D8%AC%D9%84%D8%B3_%D8%A7%D9%84%D8%A3%D9%85%D9%86_%D8%A7%D9%84%D8%AA%D8%A7%D8%A8%D8%B9_%D9%84%D9%84%D8%A3%D9%85%D9%85_%D8%A7%D9%84%D9%85%D8%AA%D8%AD%D8%AF%D8%A9_%D8%B1%D9%82%D9%85_1226&diff=prev&oldid=3370&diff-type=inline&uselang=ar

Copy and pasting

Newlines don't get copied:

• https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User%3ADom_walden%2Fsandbox2&diff=595383&oldid=595382&diff-type=inline
• https://test.wikipedia.org/w/index.php?title=User%3ADWalden_(WMF)%2Fsandbox&diff=575822&oldid=575821&diff-type=inline

enwiki beta:

foobar foobar foobar
foobaz foobaz foobaz

testwiki:

foobar foobar foobar
 
foobaz foobaz foobaz

@dom_walden that's OK

There's report on wiki (https://en.m.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)) that the behaviour on mobile has changed. Could you please take a look? the styles on core are shared with that page.

This current diff has spaces between lines (compare with screenshot above)
https://en.m.wikipedia.org/wiki/Special:MobileDiff/1166429149

Extra note: I see no mocks or QA steps in this ticket for mobile. Please always include QA At this point mobile and desktop code are more or less the same with only a few exceptions so please always check both views in all of your tasks. If you don't do this I personally get pinged on a wiki somewhere when something breaks.

Edit: Is this T342158 ?

In T330247#9035171, @Jdlrobson wrote:

Extra note: I see no mocks or QA steps in this ticket for mobile. Please always include QA At this point mobile and desktop code are more or less the same with only a few exceptions so please always check both views in all of your tasks. If you don't do this I personally get pinged on a wiki somewhere when something breaks.

We regularly test mobile diffs, as well as many other types of diffs and places where diffs are shown. We were aware of this issue and were discussing it internally.

In T330247#9035171, @Jdlrobson wrote:

There's report on wiki (https://en.m.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)) that the behaviour on mobile has changed. Could you please take a look? the styles on core are shared with that page.

This current diff has spaces between lines (compare with screenshot above)
https://en.m.wikipedia.org/wiki/Special:MobileDiff/1166429149

Looks like this was resolved now as part of T327645: Inline Diff: Insert/delete introduce line breaks, and the white gaps between green/red lines will be gone. I added screenshots there.

Permanent link to the on-wiki discussion: https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=1166964553#Not_digging_the_new_mobile_diffs

I have nothing more to add to T330247#9015327. Testing of the more recent issue will continue with T327645.