Page MenuHomePhabricator
Create Task
Maniphest T325041

Bring NewImpact logging on par with old Impact
Closed, ResolvedPublic
Actions

Description

  • All icon popups should track a close event when dismissed (including click on the X icon inside the dialog area and clicking outside of it)
  • Add new actions for for opening / closing information icon popups on the score cards.
  • Add impact-see-suggested-edits action for clicking on the button on the mobile detail view when suggested edits is not yet activated.

Aside: traditionally, this has been a lot of boilerplate. Would be nice to come up with a declarative way to add logging via the HTML markup (we have that for some things like links via the data-link-id / data-link-module-path attributes, but even there some manual setup is needed).

Details

SubjectRepoBranchLines +/-
User impact: instrument info tooltip clicksmediawiki/extensions/GrowthExperimentsmaster+46 -2
User impact: instrument info tooltip clicksmediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.14+46 -2
Vue components: react to binding updates of v-click-outside directivemediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.14+30 -10
Vue components: react to binding updates of v-click-outside directivemediawiki/extensions/GrowthExperimentsmaster+30 -10
NewImpact: Add log event for clicking suggested edits buttonmediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.14+1 -0
Impact module: instrument open/close actions on the information tooltipsschemas/event/secondarymaster+561 -3
NewImpact: Add log event for clicking suggested edits buttonmediawiki/extensions/GrowthExperimentsmaster+1 -0
Customize query in gerrit

Event Timeline

Tgr created this task.Dec 13 2022, 5:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2022, 5:24 AM
Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 13 2022, 5:24 AM
kostajh triaged this task as High priority.Dec 13 2022, 2:25 PM
Tgr claimed this task.Dec 14 2022, 6:36 AM
Tgr moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Dec 14 2022, 6:54 AM

Change 867914 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Add log event for clicking suggested edits button

https://gerrit.wikimedia.org/r/867914

gerritbot added a project: Patch-For-Review.Dec 14 2022, 6:54 AM
gerritbot added a comment.Dec 14 2022, 10:04 AM

Change 867914 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Add log event for clicking suggested edits button

https://gerrit.wikimedia.org/r/867914

gerritbot added a comment.Dec 14 2022, 10:14 AM

Change 868047 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.14] NewImpact: Add log event for clicking suggested edits button

https://gerrit.wikimedia.org/r/868047

Tgr removed Tgr as the assignee of this task.Dec 14 2022, 10:49 AM
Tgr moved this task from In Progress to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Sgs claimed this task.Dec 14 2022, 10:57 AM
Sgs moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 14 2022, 11:01 AM
gerritbot added a comment.Dec 14 2022, 4:52 PM

Change 868130 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: instrument info tooltip clicks

https://gerrit.wikimedia.org/r/868130

Sgs updated the task description. (Show Details)Dec 14 2022, 8:11 PM
gerritbot added a comment.Dec 14 2022, 8:28 PM

Change 868162 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[schemas/event/secondary@master] Impact module: instrument open/close actions on the information tooltips

https://gerrit.wikimedia.org/r/868162

gerritbot added a comment.Dec 14 2022, 8:29 PM

Change 868163 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Vue components: react to binding updates of v-click-outside directive

https://gerrit.wikimedia.org/r/868163

Sgs changed the task status from Open to In Progress.Dec 14 2022, 8:42 PM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Dec 14 2022, 10:14 PM

Change 868162 merged by jenkins-bot:

[schemas/event/secondary@master] Impact module: instrument open/close actions on the information tooltips

https://gerrit.wikimedia.org/r/868162

gerritbot added a comment.Dec 14 2022, 10:36 PM

Change 868047 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.14] NewImpact: Add log event for clicking suggested edits button

https://gerrit.wikimedia.org/r/868047

Stashbot added a comment.Dec 14 2022, 10:37 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-14T22:37:26Z] <tgr@deploy1002> Started scap: Backport for [[gerrit:868047|NewImpact: Add log event for clicking suggested edits button (T325041)]], [[gerrit:868051|UserEditTracker: Allow querying primary DB for edit timestamp]]

Stashbot added a comment.Dec 14 2022, 10:39 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-14T22:39:14Z] <tgr@deploy1002> tgr and kharlan and tgr: Backport for [[gerrit:868047|NewImpact: Add log event for clicking suggested edits button (T325041)]], [[gerrit:868051|UserEditTracker: Allow querying primary DB for edit timestamp]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Dec 14 2022, 10:49 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-14T22:49:03Z] <tgr@deploy1002> Finished scap: Backport for [[gerrit:868047|NewImpact: Add log event for clicking suggested edits button (T325041)]], [[gerrit:868051|UserEditTracker: Allow querying primary DB for edit timestamp]] (duration: 11m 37s)

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.14; 2022-12-12); removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 14 2022, 11:01 PM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 15 2022, 7:34 AM
gerritbot added a comment.Dec 15 2022, 7:52 AM

Change 868163 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Vue components: react to binding updates of v-click-outside directive

https://gerrit.wikimedia.org/r/868163

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.17; 2023-01-02); removed MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 15 2022, 8:01 AM
gerritbot added a comment.Dec 15 2022, 10:07 AM

Change 868063 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.14] Vue components: react to binding updates of v-click-outside directive

https://gerrit.wikimedia.org/r/868063

gerritbot added a comment.Dec 15 2022, 10:08 AM

Change 868064 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.14] User impact: instrument info tooltip clicks

https://gerrit.wikimedia.org/r/868064

gerritbot added a comment.Dec 15 2022, 2:58 PM

Change 868063 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.14] Vue components: react to binding updates of v-click-outside directive

https://gerrit.wikimedia.org/r/868063

gerritbot added a comment.Dec 15 2022, 2:58 PM

Change 868064 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.14] User impact: instrument info tooltip clicks

https://gerrit.wikimedia.org/r/868064

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.14; 2022-12-12); removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 15 2022, 3:01 PM
gerritbot added a comment.Dec 15 2022, 3:01 PM

Change 868130 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: instrument info tooltip clicks

https://gerrit.wikimedia.org/r/868130

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.17; 2023-01-02); removed MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 15 2022, 4:00 PM
MShilova_WMF moved this task from Triage to NewImpact Release (Completed/QA) on the GrowthExperiments-ImpactModule board.Dec 19 2022, 2:21 PM
KStoller-WMF closed this task as Resolved.Feb 10 2023, 12:33 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 10 2023, 1:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits