Don't use bidirectional styles in VueTest Codex demo
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Catrope
	Dec 19 2022, 4:08 PM

Description

Right now Special:VueTest/Codex uses bidirectional styles, with selectors like [dir] .cdx-foo or [dir="ltr"] .cdx-bar. The real Codex styles in MW don't use these, so VueTest shouldn't either. Separate LTR/RTL style files should be used instead.

Details

Subject	Repo	Branch	Lines +/-
Update Codex for the legacy vs non-legacy build (take 2)	mediawiki/extensions/VueTest	master	+239 -21
build: Use shared Vite config for the demos build	design/codex	main	+22 -52
Update Codex from v0.4.3 to v0.5.0	mediawiki/core	master	+1 K -1 K
Update Codex for the legacy vs non-legacy build	mediawiki/extensions/VueTest	master	+227 -21

Customize query in gerrit

Related Objects

Mentioned In: rEVTE22c17830ca71: Update Codex for the legacy vs non-legacy build (take 2)
rEVTEff9a78e5c932: Update Codex for the legacy vs non-legacy build

Event Timeline

Catrope created this task.Dec 19 2022, 4:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2022, 4:08 PM

AnneT subscribed.Dec 19 2022, 7:40 PM

Change 881941 had a related patch set uploaded (by Catrope; author: Catrope):

[design/codex@main] build: Use shared Vite config for the demos build

https://gerrit.wikimedia.org/r/881941

gerritbot added a project: Patch-For-Review.Jan 20 2023, 11:46 PM

Catrope changed the task status from Open to In Progress.Jan 20 2023, 11:47 PM

Catrope claimed this task.

Catrope added a project: Design-System-Team (Design-System-Sprint).

Catrope moved this task from Committed to In Development on the Design-System-Team (Design-System-Sprint) board.

Change 881943 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/extensions/VueTest@master] Update Codex for the legacy vs non-legacy build

https://gerrit.wikimedia.org/r/881943

Test wiki created on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/3a46589fca/w

Also created a Codex documentation site:
https://patchdemo.wmflabs.org/wikis/3a46589fca/w/build/codex/docs

Test wiki on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/3a46589fca/w/~~

Test wiki created on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/c3e401a1d5/w

Also created a Codex documentation site:
https://patchdemo.wmflabs.org/wikis/c3e401a1d5/w/build/codex/docs

Catrope moved this task from In Development to Code Review on the Design-System-Team (Design-System-Sprint) board.Jan 21 2023, 12:42 AM

I asked this in a comment in Gerrit but I thought it was worth mentioning here as well. Once the legacy version of Codex styles is available in MediaWiki, will all WMF teams that use Codex in their own extensions need to ensure that dirSpecificSkinStyles is set appropriately in their own extension.json files? We'll want to make sure we document this clearly.

Change 881941 merged by jenkins-bot:

[design/codex@main] build: Use shared Vite config for the demos build

https://gerrit.wikimedia.org/r/881941

Closing this task because my understanding is that there isn't really anything user-facing to test here (VueTest is not yet deployed anywhere).

Change 881943 merged by jenkins-bot:

[mediawiki/extensions/VueTest@master] Update Codex for the legacy vs non-legacy build

https://gerrit.wikimedia.org/r/881943

Catrope mentioned this in rEVTEff9a78e5c932: Update Codex for the legacy vs non-legacy build.Jan 25 2023, 1:08 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2023, 1:30 AM

Codex styles weren't loading on my local version of VueTest, so I created a patchdemo with no branches and saw the same results. Any ideas on why this is happening?

egardner reopened this task as Open.Jan 25 2023, 4:49 PM

In T325560#8557657, @AnneT wrote:

Codex styles weren't loading on my local version of VueTest, so I created a patchdemo with no branches and saw the same results. Any ideas on why this is happening?

Previously VueTest used a single stylesheet which was defined in extension.json for all use-cases. The latest patch removed that old stylesheet and added some new ones, along with a block of dirSpecificSkinStyles config to apply the appropriate style for various skins/languages.

I am not familiar with the dirSpecificSkinStyles feature in ResourceLoader so I assumed that this would just work as expected, but that doesn't seem to be the case. @Catrope can you shed any light here?

Change 883615 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/extensions/VueTest@master] Update Codex for the legacy vs non-legacy build (take 2)

https://gerrit.wikimedia.org/r/883615

gerritbot added a project: Patch-For-Review.Jan 25 2023, 6:33 PM

Sorry about this, I set the wrong Depends-On on the VueTest change, so it was merged prematurely before the MW core patch it depends on. I've reverted it, and reuploaded it with the correct Depends-On.

ldelench_wmf triaged this task as High priority.Jan 27 2023, 4:21 PM

Change 869852 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0

https://gerrit.wikimedia.org/r/869852

Change 885450 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0

https://gerrit.wikimedia.org/r/885450

Change 885450 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.4.3 to v0.5.0

https://gerrit.wikimedia.org/r/885450

Catrope closed this task as Resolved.Feb 1 2023, 5:37 PM

Change 883615 merged by jenkins-bot: