Page MenuHomePhabricator

Deprecate some Kartographer feature flags
Closed, ResolvedPublic

Description

$wgKartographerEnableMapFrame has been enabled everywhere since June 2022, we can remove the flag. It seems to have been added only to workaround the incompatibility between FlaggedRevs and Kartographer, which is now resolved.

The versioned maps flags have been enabled on production for 8 months and shouldn't be disabled again, so we can remove:

Event Timeline

Change 875461 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Kartographer@master] Deprecate the EnableMapFrame feature flag

https://gerrit.wikimedia.org/r/875461

Change 875463 had a related patch set uploaded (by Awight; author: Awight):

[operations/mediawiki-config@master] Deprecate the EnableMapFrame feature flag

https://gerrit.wikimedia.org/r/875463

We've had a bit of developer discussion and our consensus is that the flag was added to avoid broken mapframes on the few wikis with an aggressive FlaggedRevs configuration. Now that the incompatibility is resolved, we think that mapframes should always be enabled. The maplink tag is already available with no feature flag restricting it.

awight renamed this task from Deprecate feature flag $wgKartographerEnableMapFrame to Deprecate some Kartographer feature flags.Jan 11 2023, 8:15 AM
awight updated the task description. (Show Details)

Change 878852 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Kartographer@master] Remove versioned mapdata feature flags

https://gerrit.wikimedia.org/r/878852

Change 878853 had a related patch set uploaded (by Awight; author: Awight):

[operations/mediawiki-config@master] [DNM] Remove Kartographer versioned mapdata flags

https://gerrit.wikimedia.org/r/878853

Change 878852 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Remove versioned mapdata feature flags

https://gerrit.wikimedia.org/r/878852

Change 879281 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove obsolete check for $wgKartographerEnableMapFrame

https://gerrit.wikimedia.org/r/879281

Change 879281 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove obsolete check for $wgKartographerEnableMapFrame

https://gerrit.wikimedia.org/r/879281

Change 875461 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Remove unused $wgKartographerEnableMapFrame feature flag

https://gerrit.wikimedia.org/r/875461

Change 883101 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/services/kartotherian@master] Remove flags from UML diagrams

https://gerrit.wikimedia.org/r/883101

Change 883101 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] Remove flags from UML diagrams

https://gerrit.wikimedia.org/r/883101

Change 875463 merged by jenkins-bot:

[operations/mediawiki-config@master] Deprecate the EnableMapFrame feature flag

https://gerrit.wikimedia.org/r/875463

Mentioned in SAL (#wikimedia-operations) [2023-01-24T08:50:19Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:875463|Deprecate the EnableMapFrame feature flag (T326288)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-24T08:52:03Z] <kartik@deploy1002> awight and kartik: Backport for [[gerrit:875463|Deprecate the EnableMapFrame feature flag (T326288)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-24T09:01:01Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:875463|Deprecate the EnableMapFrame feature flag (T326288)]] (duration: 10m 42s)

Change 878853 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove Kartographer versioned mapdata flags

https://gerrit.wikimedia.org/r/878853

Mentioned in SAL (#wikimedia-operations) [2023-01-24T09:03:36Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:878853|Remove Kartographer versioned mapdata flags (T326288)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-24T09:05:22Z] <kartik@deploy1002> awight and kartik: Backport for [[gerrit:878853|Remove Kartographer versioned mapdata flags (T326288)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-24T09:13:20Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:878853|Remove Kartographer versioned mapdata flags (T326288)]] (duration: 09m 44s)

Change 887794 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Remove unused property from Hooks class

https://gerrit.wikimedia.org/r/887794

Change 887794 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Remove unused property from Hooks class

https://gerrit.wikimedia.org/r/887794

thiemowmde updated the task description. (Show Details)