Page MenuHomePhabricator
Create Task
Maniphest T326345

[M] Reduce jumping of content in mobile preview animation
Closed, ResolvedPublic
Actions

Description

Problem:
Currently when the preview for the bottom most result is opened it slides the result to the top. It happens when the preview to be opened may go below the fold. It causes a lot of visual movement on screen and can be disorienting for the user.

See the opening of third result in this video.
https://drive.google.com/file/d/1Z-YPWhikxwFvjvhrfAaUmUjWt0kl0vqj/view

Fix:
Do not slide the result to the top. The only scenario in which the result should be sliding up is if the preview for one of the results above it is open. Otherwise maintain the position of the result. It is okay if the users have to slide up to view the preview. It less likely for the preview to be entirely below the fold.

Details

SubjectRepoBranchLines +/-
Reduce jumping of content in mobile preview animationmediawiki/extensions/SearchVuemaster+1 -12
Customize query in gerrit

Related Objects

Event Timeline

Sneha created this task.Jan 5 2023, 6:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2023, 6:53 PM
Sneha updated the task description. (Show Details)Jan 5 2023, 6:54 PM
CBogen edited projects, added SDAW-Search-Improvements (Milestone 3: QuickView mobile); removed SDAW-Search-Improvements.Jan 9 2023, 5:42 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Jan 9 2023, 5:54 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
CBogen renamed this task from Reduce jumping of content in mobile preview animation to [M] Reduce jumping of content in mobile preview animation.Jan 11 2023, 5:28 PM
CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Jan 11 2023, 5:55 PM
gerritbot added a comment.Jan 18 2023, 12:56 PM

Change 881402 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Reduce jumping of content in mobile preview animation

https://gerrit.wikimedia.org/r/881402

gerritbot added a project: Patch-For-Review.Jan 18 2023, 12:56 PM
SimoneThisDot claimed this task.Jan 18 2023, 12:56 PM
SimoneThisDot moved this task from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jan 19 2023, 10:24 AM
gerritbot added a comment.Jan 19 2023, 10:26 AM

Change 881402 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Reduce jumping of content in mobile preview animation

https://gerrit.wikimedia.org/r/881402

SimoneThisDot mentioned this in rESVU242b309188d3: Reduce jumping of content in mobile preview animation.Jan 19 2023, 10:27 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 19 2023, 10:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 19 2023, 11:00 AM
Sneha mentioned this in T320527: [S] Mobile: Enable users to open and close quick view on special:search results page.Jan 19 2023, 9:17 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Jan 19 2023, 9:43 PM
Etonkovidova subscribed.

Works as expected in betalabs - moving to Verify on Production for a quick check after deployment.

Etonkovidova closed this task as Resolved.Feb 9 2023, 10:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL