Page MenuHomePhabricator

Store each XFF IP in the CheckUser result tables using a hex format
Open, LowPublicFeature

Description

Summary

To allow T315926: Provide a way to search all of the XFF addresses listed in the XFF string, we need to make it possible to store each XFF IP as it's own distinct IP hex value

Background

  • The CheckUser result tables currently store each XFF string as both:
    • The raw XFF string
    • The last XFF IP using hexadecimal
  • To allow T315926: Provide a way to search all of the XFF addresses listed in the XFF string to be implemented, we need to store all the IPs as separate XFF IP values
    • This likely means having a separate table(s) so that we can have a one-to-many or many-to-many relationship to each CheckUser result table
    • However, we could also consider making the xff_hex column store comma separated values and use a LIKE query, or even have multiple xff_hex columns (relying on the idea that the XFF string won't be too long)

Acceptance criteria

Event Timeline

• Dreamy_Jazz renamed this task from Normalise the XFF and user agent columns to Normalise the XFF columns in the CheckUser result tables.Feb 27 2026, 1:49 PM
• Dreamy_Jazz updated the task description. (Show Details)
• Dreamy_Jazz renamed this task from Normalise the XFF columns in the CheckUser result tables to Store each XFF IP in the CheckUser result tables using a hex format.Feb 27 2026, 1:57 PM
• Dreamy_Jazz lowered the priority of this task from Medium to Low.
• Dreamy_Jazz added a project: Schema-change.
• Dreamy_Jazz updated the task description. (Show Details)

Probably won't work on this for the time being