Page MenuHomePhabricator
Create Task
Maniphest T361174

Write to agent_id columns in the CheckUserInsert service when migration configuration allows it
Closed, ResolvedPublic
Actions

Description

The CheckUserInsert service needs to support writing to the cuc_agent_id, cule_agent_id, and cupe_agent_id columns if the schema migration configuration value added in T361173: Add schema migration config for cu_useragent table indicates to write to these columns.

This will handle supporting not writing to the cuc_agent, cule_agent, and cupe_agent columns.

Acceptance criteria
  • The CheckUserInsert service should support writing to the agent_id columns if SCHEMA_COMPAT_WRITE_NEW is set
  • The CheckUserInsert service should only write to the agent columns if SCHEMA_COMPAT_WRITE_OLD is set

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Support not writing old for user agent table migrationmediawiki/extensions/CheckUsermaster+22 -9
Write to cu_useragent table if configured to do somediawiki/extensions/CheckUsermaster+137 -14
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• TBolligerT120734 Epic ⚡️ Improve MediaWiki's blocking tools
 OpenNoneT146837 Add ability to search by user agent from CheckUser interface
 OpenNoneT249374 CU 2.0: Filter out exact UAs in the Compare tab
 OpenNoneT147894 Create index for agent_id columns in the CheckUser result tables
 ResolvedDreamy_JazzT305930 Normalize cu_changes table
 ResolvedDreamy_JazzT361139 Normalise the user agent column in CheckUser result tables
 ResolvedDreamy_JazzT361208 Remove agent columns from CheckUser result tables
 ResolvedDreamy_JazzT361206 Stop writing old for user agent schema migration on WMF wikis
 ResolvedDreamy_JazzT361205 Stop writing old for user agent schema migration
 ResolvedDreamy_JazzT361199 Set user agent schema migration config to read new on WMF wikis
 ResolvedDreamy_JazzT361201 Set user agent schema migration config to read new in extension.json
 ResolvedDreamy_JazzT361192 Read user agent strings from the cu_useragent table in Special:CheckUser
 ResolvedDreamy_JazzT361193 Read user agent strings from the cu_useragent table in the CheckUser API
 ResolvedDreamy_JazzT361195 Read user agent strings from the cu_useragent table in Special:Investigate
 ResolvedDreamy_JazzT413893 Read from the agent_id column in misc interfaces
 ResolvedDreamy_JazzT413868 Populate the cu_useragent table and agent_id columns on WMF wikis
 ResolvedDreamy_JazzT361198 Create a maintenance script to populate the cu_useragent table and agent_id columns with values from the agent columns
 ResolvedDreamy_JazzT361196 Write to the cu_useragent table and agent_id columns on WMF wikis
 ResolvedDreamy_JazzT361197 Write to the cu_useragent table and agent_id columns on by default in extension.json
 ResolvedDreamy_JazzT413873 Update remaining code that writes to the CheckUser result tables to write to the agent_id columns
 ResolvedDreamy_JazzT361174 Write to agent_id columns in the CheckUserInsert service when migration configuration allows it
 ResolvedDreamy_JazzT361173 Add schema migration config for cu_useragent table
 ResolvedDreamy_JazzT361140 Add user agent ID column to each CheckUser result table
 ResolvedDreamy_JazzT359312 Create cu_useragent table
 ResolvedMarosteguiT361631 Unable to create table cu_useragent on labtestwiki
 DeclinedNoneT328289 update labtestwiki user and password
 ResolvedPapaulT369308 Decommission clouddb2002-dev.codfw.wmnet
 ResolvedtaaviT378260 Retire labtestwiki
 ResolvedMarosteguiT361673 Filter cu_useragent on sanitarium
 ResolvedSnwachukwuT361210 Changes to the cuc_agent column in the cu_changes table

Event Timeline

Dreamy_Jazz created this task.Mar 28 2024, 12:04 AM
Dreamy_Jazz removed a project: Epic.
Dreamy_Jazz added a subtask: T361173: Add schema migration config for cu_useragent table.
Dreamy_Jazz added a subtask: T361140: Add user agent ID column to each CheckUser result table.Mar 28 2024, 9:31 AM
Dreamy_Jazz added a parent task: T361192: Read user agent strings from the cu_useragent table in Special:CheckUser.Mar 28 2024, 9:37 AM
Dreamy_Jazz added a parent task: T361193: Read user agent strings from the cu_useragent table in the CheckUser API.Mar 28 2024, 9:46 AM
Dreamy_Jazz added a parent task: T361195: Read user agent strings from the cu_useragent table in Special:Investigate.Mar 28 2024, 9:57 AM
Dreamy_Jazz mentioned this in T361196: Write to the cu_useragent table and agent_id columns on WMF wikis.Mar 28 2024, 10:00 AM
Dreamy_Jazz mentioned this in T361197: Write to the cu_useragent table and agent_id columns on by default in extension.json.
Dreamy_Jazz added a parent task: T361197: Write to the cu_useragent table and agent_id columns on by default in extension.json.Mar 28 2024, 10:02 AM
Dreamy_Jazz removed a parent task: T361192: Read user agent strings from the cu_useragent table in Special:CheckUser.
Dreamy_Jazz removed a parent task: T361193: Read user agent strings from the cu_useragent table in the CheckUser API.
Dreamy_Jazz removed a parent task: T361195: Read user agent strings from the cu_useragent table in Special:Investigate.
Dreamy_Jazz removed a subtask: T361140: Add user agent ID column to each CheckUser result table.Mar 28 2024, 10:07 AM
Dreamy_Jazz removed a parent task: T361139: Normalise the user agent column in CheckUser result tables.Mar 28 2024, 10:30 AM
Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Aug 6 2025, 12:24 PM
Dreamy_Jazz added a project: Essential-Work.Aug 14 2025, 10:38 AM
OKryva-WMF edited projects, added Product Safety and Integrity; removed Trust and Safety Product Team.Oct 10 2025, 9:54 AM
OKryva-WMF moved this task from Inbox to Later sprints on the Product Safety and Integrity board.Oct 10 2025, 9:54 AM
mszwarc closed subtask T361173: Add schema migration config for cu_useragent table as Resolved.Dec 17 2025, 1:39 PM
Dreamy_Jazz claimed this task.Dec 19 2025, 10:34 AM
Dreamy_Jazz edited projects, added Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)); removed Product Safety and Integrity.
gerritbot added a comment.Dec 19 2025, 10:35 AM

Change #1219815 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Write to the new cu_useragent table depending on migration config

https://gerrit.wikimedia.org/r/1219815

gerritbot added a project: Patch-For-Review.Dec 19 2025, 10:35 AM
Dreamy_Jazz moved this task from Backlog to In progress on the Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)) board.Dec 19 2025, 10:41 AM
Dreamy_Jazz moved this task from In progress to Needs review on the Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)) board.Dec 19 2025, 3:43 PM
Dreamy_Jazz updated the task description. (Show Details)Jan 5 2026, 12:49 PM
gerritbot added a comment.Jan 5 2026, 1:08 PM

Change #1219815 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Write to cu_useragent table if configured to do so

https://gerrit.wikimedia.org/r/1219815

Dreamy_Jazz updated the task description. (Show Details)Jan 5 2026, 1:11 PM
gerritbot added a comment.Jan 5 2026, 1:23 PM

Change #1223186 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Support not writing old for user agent table migration

https://gerrit.wikimedia.org/r/1223186

gerritbot added a comment.Jan 5 2026, 2:16 PM

Change #1223186 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Support not writing old for user agent table migration

https://gerrit.wikimedia.org/r/1223186

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2026, 2:31 PM
Dreamy_Jazz moved this task from Needs review to Needs QA on the Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)) board.Jan 6 2026, 11:16 AM
Dreamy_Jazz mentioned this in T413873: Update remaining code that writes to the CheckUser result tables to write to the agent_id columns.Jan 6 2026, 12:03 PM
Dreamy_Jazz added a parent task: T413873: Update remaining code that writes to the CheckUser result tables to write to the agent_id columns.
Dreamy_Jazz closed this task as Resolved.Jan 7 2026, 1:31 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz moved this task from Needs QA to Done on the Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits