Page MenuHomePhabricator

Not all numbers are localised in AbuseFilter
Closed, ResolvedPublic


in abuse filter's raw numbers are in English would you please convert them to Persian one

Version: unspecified
Severity: normal



Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:55 PM
bzimport added projects: AbuseFilter, I18n.
bzimport set Reference to bz30729.

Should be just formatNum()s sprinkled in the code. Maybe the extension author could do it easily?

Shrikanth volunteered on this during bug triage. Brain has offered to mentor.

Created attachment 9070
Fixes the non-localized numbers

Since the bug is already assigned to someone, I didn't commit the change but rather post it here to assist Srikanth with fixing the bug.


Thanks Huji. There are more places which needs the fix. I am hitting over AbuseFilterViewRevert.php for sometime now and hopefully get all of them soon.

Should the input also be modified to accept i18n numerals ? Special:AbuseFilter/test/ page has option to load a filter by ID.

I don't think so. In other places where MediaWiki accepts numbers, it always expects them to be in English-style numerals. I think it is a good practice to stick to the tradition in extensions too.

Fixed with r100016. Sorry, I was not aware of this bug. It was not my intention to "steal" an easy bug from a novice developer.