Per @hashar here: T325297#8474351
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T319359 GitLab integrations: the Gerrit & Jenkins integration catalog | |||
| Resolved | • brennen | T265617 Experiment with GitLab-Phabricator integration | |||
| Resolved | dancy | T324150 Comment on Phabricator tasks for new, merged, and abandoned changes on GitLab | |||
| Resolved | • brennen | T327424 GitLab comments should come from a CodeReviewBot instead of gerritbot | |||
| Resolved | • brennen | T330923 Create CodeReviewBot for use by GitLab-Phabricator integrations |
Per discussion on this pull request to Phabricator-maintenance-bot for patch-for-review tagging, I'm going to create a CodeReviewBot in Phab and switch to using that for GitLab MR notices.
I've found these docs:
I'll create a bot request subtask here, just for transparency, but should be able to create the bot myself.
I confirmed the new CodeReviewBot user works here - T324164#8664674 - but haven't permanently switched to that yet since I need to make sure it works with Phabricator maintenance bot.
Additionally, I think maybe the maintenance bot should do just do everything as CodeReviewBot instead of gerritbot, so it's not tied to to the name of a specific service - but I'm not sure if that would break any existing workflows or matching on the name elsewhere.
cc: @Ladsgroup who I believe was taking time off back when I started looking at this.
Hi,
it's quite easy to make my bot work with both gerrit bot and code reviewbot. At least during the migration period. Simply change the line in here:
if transaction['authorPHID'] == self.gerrit_bot_phid:
To something like:
if transaction['authorPHID'] in [self.gerrit_bot_phid, self.code_review_bot_phid]:
(and set that attribute somewhere). And be done with it. Feel free to make a PR. If you don't want to, I can make it as well.
Mentioned in SAL (#wikimedia-releng) [2023-05-10T23:19:39Z] <brennen> reconfigured and restarted gitlab-webhooks to use CodeReviewBot for messages instead of gerritbot (T327424)
Thank you @brennen and @Ladsgroup , that will slightly reduce the confusion of people filing task against Gerrit instead of GitLab or whatever else :)