Page MenuHomePhabricator
Create Task
Maniphest T327518

Improve paragraph split appearance on Diff
Open, LowPublic
Actions

Description

See https://phabricator.wikimedia.org/T324803, specifically https://phabricator.wikimedia.org/T324803#8515102.

With T324803, it sounds like the JSON output will remain unchanged to be backwards-compatible. To adopt improved paragraph split support on the apps, we'll need to add logic in the wikidiff2 json formatter hook, as well as API / PHP work to pass in a feature flag to opt-in to this logic.

TBD: A new API version number / app-side changes will depend on if the JSON contract needs to change.

Related Objects

Event Timeline

Tsevener created this task.Jan 20 2023, 4:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2023, 4:06 PM
Tsevener renamed this task from Improve paragraph split appearance on diff screens to Improve paragraph split appearance on Diff.Jan 20 2023, 4:06 PM
Tsevener mentioned this in T324803: Better Diffs: Wikidiff2 revise algorithm.
Tsevener updated the task description. (Show Details)
Tsevener added a project: Wikipedia-Android-App-Backlog.Jan 20 2023, 8:24 PM
LGoto triaged this task as Low priority.Jan 24 2023, 7:44 PM
LGoto moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.
LGoto moved this task from Needs Triage to UX Debt Backlog on the Wikipedia-Android-App-Backlog board.Jan 26 2023, 5:08 PM
LGoto added a subscriber: scblr.
gerritbot added a comment.Jul 10 2023, 5:50 AM

Change 936135 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Add support for wikidiff2_multi_format_diff()

https://gerrit.wikimedia.org/r/936135

gerritbot added a project: Patch-For-Review.Jul 10 2023, 5:50 AM
tstarling removed a project: Patch-For-Review.Jul 13 2023, 2:30 AM
tstarling subscribed.
In T327518#9000085, @gerritbot wrote:

Change 936135 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Add support for wikidiff2_multi_format_diff()

https://gerrit.wikimedia.org/r/936135

Sorry, wrong task.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL