Page MenuHomePhabricator

Eliminate minimized state of the Page Curation toolbar and add a close button to its maximized state
Closed, DeclinedPublic

Description

Requested by Geni on Discord.

Right now close button only appears on minimized Page Curation toolbar, not maximized toolbar. Geniice requests we have it for both.

Minimized stateMaximized state
image.png (491×72 px, 6 KB)
image.png (654×115 px, 26 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

We could also reduce the size of the "minimize" button and add the close button in the same row (This is shown in https://www.mediawiki.org/wiki/File:PagesFeedInfoFlyout.png).

Alternatively, is there much use for the minimized state of the toolbar at all? If we eliminate this state then, we can remove the "minimize" button and just add the small "close" button to the toolbar.

Alternatively, is there much use for the minimized state of the toolbar at all? If we eliminate this state then, we can remove the "minimize" button and just add the small "close" button to the toolbar.

That simplifies things and would allow us to remove code, so +1 from me from that perspective.

Longer term, some design input on how to best display this component (menu + its panels) would be nice. To me, it seems like a "Help panel" type design + implementation https://www.mediawiki.org/wiki/Help:Growth/Tools/Help_panel could work.

MPGuy2824 changed the task status from Open to In Progress.Feb 17 2023, 4:30 AM
MPGuy2824 claimed this task.
MPGuy2824 renamed this task from Add a close button to Page Curation toolbar to Eliminate minimized state of the Page Curation toolbar and add a close button to its maximized state.Feb 17 2023, 5:31 AM

Change 889898 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] Eliminiating the 'minimized' state of the toolbar

https://gerrit.wikimedia.org/r/889898

Change 892367 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] [WIP] toolbar: Register the "close" button as a tool

https://gerrit.wikimedia.org/r/892367

This ticket kind of turned into two different requests: Request 1 was to add a "close" button to the Page Curation toolbar, and request 2 was to eliminate the minimized state.

I gave this some additional thought, and I think I'd be in favor of leaving the current system as-is. That is, I am not sure we need to implement either request.

The minimized state is a useful visual indicator that this is a new article, without covering any of the page text like the un-minimized toolbar does sometimes.

Change 892367 abandoned by Kosta Harlan:

[mediawiki/extensions/PageTriage@master] [WIP] toolbar: Register the "close" button as a tool

Reason:

https://gerrit.wikimedia.org/r/892367

This ticket kind of turned into two different requests: Request 1 was to add a "close" button to the Page Curation toolbar, and request 2 was to eliminate the minimized state.

I gave this some additional thought, and I think I'd be in favor of leaving the current system as-is. That is, I am not sure we need to implement either request.

The minimized state is a useful visual indicator that this is a new article, without covering any of the page text like the un-minimized toolbar does sometimes.

That sounds fine. We could revisit this later in a broader design/UX review.

I gave this some additional thought, and I think I'd be in favor of leaving the current system as-is. That is, I am not sure we need to implement either request.

The minimized state is a useful visual indicator that this is a new article, without covering any of the page text like the un-minimized toolbar does sometimes.

We did have (some) consensus on this. Maybe we should ask reviewers that question again, before the remaining patch is abandoned and this ticket is marked as Declined.

Change 889898 abandoned by MPGuy2824:

[mediawiki/extensions/PageTriage@master] toolbar: Remove support for minimized state

Reason:

Given that the toolbar is moving to Vue, this patch is defunct

https://gerrit.wikimedia.org/r/889898

MPGuy2824 changed the task status from In Progress to Open.Dec 20 2023, 2:48 AM
MPGuy2824 removed MPGuy2824 as the assignee of this task.
MPGuy2824 moved this task from Code Review to Backlog on the PageTriage board.

This ticket seems to have changed past the original scope I created for it. I would not be in favor of getting rid of the minimized state.