Page MenuHomePhabricator
Create Task
Maniphest T327824

[wmf-20] testwiki - ext-growthExperiments-ScoreCards__scorecard__info for one day streak shows $3
Closed, ResolvedPublicBUG REPORT
Actions

Description

  1. Login to testwiki wmf.20 as a new user (with no edits) or a user whose longest editing streak was only during one day. If you're a new user, make an edit.

Examples of a test user in testwiki - https://test.wikipedia.org/wiki/Special:Impact/Testzilant19oct01

  1. Go to Special:Homepage - the NewImpact module info button shows $3 instead of "1 day":

Screen Shot 2023-01-24 at 2.38.38 PM.png (1×1 px, 125 KB)

Note:

  • https://test.wikipedia.org/wiki/Special:Impact/Testzilant19oct01 displays the date correctly. Only the NewImpact on Special:Homepage displays $3.
  • checked with users whose 1-day streak was long time ago - the issue is present
  • checked few cases for different length of editing streaks - the dates are displayed correctly

Details

SubjectRepoBranchLines +/-
User impact: amend incorrect parameter for the single day streak textmediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.20+3 -3
User impact: amend incorrect parameter for the single day streak textmediawiki/extensions/GrowthExperimentsmaster+3 -3
User impact: ammend incorrect parameter for the single day streak textmediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.19+6 -2
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jan 24 2023, 10:52 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 24 2023, 10:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova mentioned this in T323487: NewImpact: Adjust display for single day longest streak.Jan 25 2023, 1:23 AM
Etonkovidova updated the task description. (Show Details)Jan 25 2023, 1:29 AM
Etonkovidova renamed this task from {wmf-20] testwiki - ext-growthExperiments-ScoreCards__scorecard__info for one day streak shows $3 to [wmf-20] testwiki - ext-growthExperiments-ScoreCards__scorecard__info for one day streak shows $3 .Jan 25 2023, 2:04 AM
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jan 25 2023, 4:09 AM
Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh triaged this task as High priority.Jan 25 2023, 5:55 AM
kostajh changed the subtype of this task from "Task" to "Bug Report".
gerritbot added a comment.Jan 25 2023, 10:59 AM

Change 883545 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: ammend incorrect parameter for the single day streak text

https://gerrit.wikimedia.org/r/883545

gerritbot added a project: Patch-For-Review.Jan 25 2023, 10:59 AM
Sgs claimed this task.Jan 25 2023, 11:00 AM
Sgs moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jan 25 2023, 11:02 AM

Change 883547 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.20] User impact: ammend incorrect parameter for the single day streak text

https://gerrit.wikimedia.org/r/883547

gerritbot added a comment.Jan 25 2023, 11:10 AM

Change 883548 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.19] User impact: ammend incorrect parameter for the single day streak text

https://gerrit.wikimedia.org/r/883548

gerritbot added a comment.Jan 25 2023, 11:11 AM

Change 883548 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.19] User impact: ammend incorrect parameter for the single day streak text

Reason:

The issue is not present on wmf.19

https://gerrit.wikimedia.org/r/883548

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 25 2023, 11:20 AM
Sgs added a comment.Jan 25 2023, 11:20 AM

I the issue was introduced in rEGREdf38f61980faa42ccb0f987684de723b58f03b21 when changing the logic of the arguments supplied to mw.message('key', ..args).

gerritbot added a comment.Jan 25 2023, 11:42 AM

Change 883545 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: amend incorrect parameter for the single day streak text

https://gerrit.wikimedia.org/r/883545

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 25 2023, 12:00 PM
gerritbot added a comment.Jan 25 2023, 2:20 PM

Change 883547 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.20] User impact: amend incorrect parameter for the single day streak text

https://gerrit.wikimedia.org/r/883547

Stashbot mentioned this in T327490: Create an easy way to observe/monitor Wikibase REST API errors happening on Wikidata.Jan 25 2023, 2:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-25T14:21:10Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:883224|REST: Use error log level for unexpected errors (T327490)]], [[gerrit:883547|User impact: amend incorrect parameter for the single day streak text (T327824)]]

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2023, 2:31 PM
Stashbot added a comment.Jan 25 2023, 2:40 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-25T14:39:58Z] <urbanecm@deploy1002> jakob and sgimeno and urbanecm: Backport for [[gerrit:883224|REST: Use error log level for unexpected errors (T327490)]], [[gerrit:883547|User impact: amend incorrect parameter for the single day streak text (T327824)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Stashbot added a comment.Jan 25 2023, 2:53 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-25T14:53:31Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:883224|REST: Use error log level for unexpected errors (T327490)]], [[gerrit:883547|User impact: amend incorrect parameter for the single day streak text (T327824)]] (duration: 32m 21s)

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.20; 2023-01-23); removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 25 2023, 3:00 PM
Stashbot added a comment.Jan 25 2023, 3:04 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-25T15:04:24Z] <urbanecm@deploy1002> Started scap: triggering i18n refresh for T327824

Stashbot added a comment.Jan 25 2023, 3:12 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-25T15:12:22Z] <urbanecm@deploy1002> Finished scap: triggering i18n refresh for T327824 (duration: 07m 57s)

Etonkovidova closed this task as Resolved.Feb 3 2023, 7:19 PM

Checked on testwiki wmf.21 - the fix is in place:

Screen Shot 2023-02-03 at 11.17.54 AM.png (956×996 px, 118 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL