Page MenuHomePhabricator

AQS 2.0: Edit Analytics: Implement Unit Tests
Closed, ResolvedPublic

Description

Implement unit tests for the Edit Analytics service. Completion of T327835: AQS 2.0: Implement Test Framework for Druid-based Endpoints is a prerequisite for beginning this task.

See T316849: Audit tests for Druid-based endpoints for a full list of existing production tests for Druid-based endpoints. Only the tests relevant to the Edit Analytics endpoints should be implemented, under this task. But because this is still a lengthy list of tests, we should consider breaking up this task and/or creating subtasks. However, we won't be ready for that conversation until we know more about how T327835: AQS 2.0: Implement Test Framework for Druid-based Endpoints is going to turn out.

Completion criteria: tests listed in T316849: Audit tests for Druid-based endpoints that are relevant to Edit Analytics are implemented. Checklist to be created later.

Update: some (most? all?) of the tests listed in the above referenced task are actually integration tests and not unit tests. Unit tests should have no dependencies. That is, they should execute without the associated testing environment/mock data set. We may need a new list of actual unit tests. Device Analytics can serve as inspiration.

Event Timeline

Sfaci triaged this task as Medium priority.Jul 4 2023, 9:34 AM
Sfaci edited projects, added AQS2.0 (Sprint 10); removed AQS2.0.
Sfaci removed Sfaci as the assignee of this task.Jul 19 2023, 7:34 AM
Sfaci subscribed.
SGupta-WMF changed the task status from Open to In Progress.Jul 28 2023, 11:03 AM
SGupta-WMF claimed this task.
SGupta-WMF moved this task from Next Up to In Progress on the AQS2.0 (Sprint 10) board.

Change 949848 had a related patch set uploaded (by Sg912; author: Sg912):

[generated-data-platform/aqs/edit-analytics@main] Bug:T327836

https://gerrit.wikimedia.org/r/949848

Change 953755 had a related patch set uploaded (by Sg912; author: Sg912):

[generated-data-platform/aqs/edit-analytics@main] Bug:T327836

https://gerrit.wikimedia.org/r/953755

Change 953755 abandoned by Sg912:

[generated-data-platform/aqs/edit-analytics@main] Bug:T327836

Reason:

https://gerrit.wikimedia.org/r/953755

Change 953755 restored by Sg912:

[generated-data-platform/aqs/edit-analytics@main] Bug:T327836

https://gerrit.wikimedia.org/r/953755

Change 953755 merged by Sg912:

[generated-data-platform/aqs/edit-analytics@main] Bug:T327836

https://gerrit.wikimedia.org/r/953755

Change 949848 abandoned by Sg912:

[generated-data-platform/aqs/edit-analytics@main] Bug:T327836

Reason:

https://gerrit.wikimedia.org/r/949848

Sfaci claimed this task.

test status: QA PASS

Able to run the tests locally and there is no functional change for this service per ticket description