Collapsible elements are invisible to browser search
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Tacsipacsi
	Jan 25 2023, 12:29 PM

Description

Steps to reproduce

Open https://www.mediawiki.org/w/index.php?title=Manual:Collapsible_elements&oldid=5581603
Using the browser search (⌃+F, ⌘+F etc.), search for is hidden.

Actual result

Two results are found, in the two code examples.

Expected result

Four results are found: two in the code examples, and two in the rendered examples.

Other information

At least in Chrome and many Chromium-based browsers, MobileFrontend fixed this in 1abe4bd7dbd3b4001979a9bdb518f8d4d287a485 (T216789). The same fix should work here as well.

Details

	Subject	Repo	Branch	Lines +/-
	makeCollapsible: Expand when text is matched with browser find feature	mediawiki/core	master	+99 -54

Customize query in gerrit

Related Objects

Mentioned Here: T216789: Use display locking to allow browser's native "Find in page" function to work with collapsed sections
rEMFR1abe4bd7dbd3: Make sections expandable by find-in-page

Event Timeline

Tacsipacsi created this task.Jan 25 2023, 12:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2023, 12:29 PM

Esanders subscribed.Oct 21 2023, 10:14 AM

Change 967556 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] makeCollapsible: Expand when text is matched with browser find feature

https://gerrit.wikimedia.org/r/967556

gerritbot added a project: Patch-For-Review.Oct 21 2023, 12:28 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/a06975bb3f/wiki/Collapsible

Unfortunately this won't work with how we current collapse tables, as content-visibility can't be used to hide table structure, but it will work in all other cases.

In T327893#9270203, @Esanders wrote:

Unfortunately this won't work with how we current collapse tables, as content-visibility can't be used to hide table structure, but it will work in all other cases.

I realised we can force this to work with table cells, by turning them into not-table cells when hidden (using display:block)!

Demos:

https://patchdemo.wmflabs.org/wikis/a06975bb3f/wiki/Collapsible
https://patchdemo.wmflabs.org/wikis/a06975bb3f/wiki/Kim_Gyu-ri_(actress,_born_August_1979) (collapsed nav boxes at end of article)

Esanders added a subscriber: Quiddity.Oct 25 2023, 3:53 PM

Collapsible elements are invisible to browser searchOpen, Needs TriagePublicBUG REPORTActions