Page MenuHomePhabricator

Removing leading zeros for srid for heritage API
Open, Needs TriagePublic

Related Objects

Event Timeline

Ciell added subscribers: AxelPettersson_WMSE, Ciell.

@AxelPettersson_WMSE Could you maybe help out with this?
From my reading of the description in the bug report, the problem seems to lie in Wikidata, not with the heritage tool on toolforge - but maybe you disagree? I would appreciate your opinion so I can connect to the right person for a fix.

It looks like the issue is that the Monuments Database config expects the identifier to be an integer (133) when in reality it is a string (00133). So when it harvests the lists it drops the leading zeros.

It should therefore just be a question of updating the config and redeploying and then all the identifiers should get their leading zeros back and database should match P381.

Change 891260 had a related patch set uploaded (by Lokal Profil; author: Lokal Profil):

[labs/tools/heritage@master] ch_de identifieras should retain leading zeroes

https://gerrit.wikimedia.org/r/891260

Change 891260 merged by jenkins-bot:

[labs/tools/heritage@master] ch_de identifieras should retain leading zeroes

https://gerrit.wikimedia.org/r/891260

@Ciell This is deployed now but the data won't change until the next harvest so give it a few days.