Maniphest T327956

Removing leading zeros for srid for heritage API
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	M2k_dewiki
	Jan 25 2023, 8:37 PM

Tags

Referenced Files

None

Subscribers

• AxelPettersson_WMSE

Description

Hello,

Property P381
https://www.wikidata.org/wiki/Property:P381
uses five digits including leading zeros, according to
https://www.babs.admin.ch/en/aufgabenbabs/kgs/inventar.html

Example:
https://www.wikidata.org/wiki/Q19362321

While
https://heritage.toolforge.org/api/api.php?action=search&format=html&srcountry=ch&srid=00133
leads to a blank page, the same id without leading zeros
https://heritage.toolforge.org/api/api.php?action=search&format=html&srcountry=ch&srid=133
returns the matching monument entry.

Would it be possible to match the srid, independent of possible leading zeros?

Maybe some JavaScript could be used as a possible workaround? For example, something like

https://heritage.toolforge.org/api/api.php?action=search&format=html&srcountry=ch&srid= + function_to_remove_leading_zeros ( $1 )

Thanks a lot!

Also see

https://www.wikidata.org/wiki/Topic:Xbcy58fywxh6shvz
https://www.wikidata.org/wiki/Wikidata:Project_chat#Adding/Removing_leading_zeros_for_URL_formatter
https://www.wikidata.org/wiki/Property_talk:P381#PCP_reference_number_(P381)_-_Broken_link_with_leading_0's

https://phabricator.wikimedia.org/T321633

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ch_de identifieras should retain leading zeroes	labs/tools/heritage	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T317279: erfgoedbot/check_emailable_users.py fails on all users
T317278: erfgoedbot categorization job start fails
Mentioned Here: T317278: erfgoedbot categorization job start fails
T317279: erfgoedbot/check_emailable_users.py fails on all users
rTHERa4d8f5e29175: Localisation updates from https://translatewiki.net.
rTHERed09031f370a: Localisation updates from https://translatewiki.net.
rTHERaef11beb0473: Localisation updates from https://translatewiki.net.
rTHERa9a38150ba17: Localisation updates from https://translatewiki.net.
rTHER1ac1b7db2a79: Localisation updates from https://translatewiki.net.
rTHER2f02594df59b: Localisation updates from https://translatewiki.net.
rTHER3a34d3a93f61: Localisation updates from https://translatewiki.net.
rTHER88ebc6e14a48: Fix jsub syntax in update_monuments Shell script
rTHERc65ef5c9e4b8: Localisation updates from https://translatewiki.net.
rTHERed58572bc4cc: Localisation updates from https://translatewiki.net.
rTHERdbb296edf322: Localisation updates from https://translatewiki.net.
rTHERc9878d063110: Localisation updates from https://translatewiki.net.
rTHERaf60a34f9dca: Localisation updates from https://translatewiki.net.
rTHER71378e1dea84: ch_de identifieras should retain leading zeroes
rTHER133bbf2403e3: Use `revisions` instead of `getLatestEditors` in check_emailable_users
rTHER91eab6004d98: Localisation updates from https://translatewiki.net.
P381 (An Untitled Masterwork)
T321633: Blank page from heritage API with monument ID

Event Timeline

M2k_dewiki created this task.Jan 25 2023, 8:37 PM

M2k_dewiki edited projects, added Wiki-Loves-Monuments; removed Wiki-Loves-Monuments-Database.Jan 25 2023, 8:47 PM

M2k_dewiki updated the task description. (Show Details)

M2k_dewiki updated the task description. (Show Details)Jan 25 2023, 8:56 PM

M2k_dewiki updated the task description. (Show Details)

@AxelPettersson_WMSE Could you maybe help out with this?
From my reading of the description in the bug report, the problem seems to lie in Wikidata, not with the heritage tool on toolforge - but maybe you disagree? I would appreciate your opinion so I can connect to the right person for a fix.

Ciell reopened this task as Open.Feb 17 2023, 5:35 PM

Ciell closed this task as a duplicate of T321633: Blank page from heritage API with monument ID.

Ciell merged a task: T321633: Blank page from heritage API with monument ID.Feb 17 2023, 5:38 PM

Ciell added subscribers: Nux, Aklapper.

Ciell moved this task from Incoming to Backlog on the Wiki-Loves-Monuments board.Feb 17 2023, 5:41 PM

It looks like the issue is that the Monuments Database config expects the identifier to be an integer (133) when in reality it is a string (00133). So when it harvests the lists it drops the leading zeros.

It should therefore just be a question of updating the config and redeploying and then all the identifiers should get their leading zeros back and database should match P381.

Change 891260 had a related patch set uploaded (by Lokal Profil; author: Lokal Profil):

[labs/tools/heritage@master] ch_de identifieras should retain leading zeroes

https://gerrit.wikimedia.org/r/891260

gerritbot added a project: Patch-For-Review.Feb 22 2023, 12:17 PM

There might be a need to also look over the zero-padding in https://commons.wikimedia.org/wiki/Template:Cultural_property_of_national_significance_in_Switzerland to ensure it doesn't add too many

Change 891260 merged by jenkins-bot:

[labs/tools/heritage@master] ch_de identifieras should retain leading zeroes

https://gerrit.wikimedia.org/r/891260

Maintenance_bot removed a project: Patch-For-Review.Feb 23 2023, 8:10 PM

Mentioned in SAL (#wikimedia-cloud) [2023-03-08T12:46:56Z] <wm-bot> <lokal-profil> Deploy a4d8f5e, ed09031, aef11be, a9a3815, 1ac1b7d, 2f02594, 3a34d3a, 88ebc6e (T317278), c65ef5c, ed58572, dbb296e, c9878d0, af60a34, 71378e1 (T327956), 133bbf2 (T317279), 91eab60

Stashbot mentioned this in T317278: erfgoedbot categorization job start fails.Mar 8 2023, 12:46 PM

Stashbot mentioned this in T317279: erfgoedbot/check_emailable_users.py fails on all users.

@Ciell This is deployed now but the data won't change until the next harvest so give it a few days.

Lokal_Profil closed this task as Resolved.Aug 26 2024, 9:12 AM

Lokal_Profil claimed this task.