Page MenuHomePhabricator

Flow topic pages show tab linking to namespace that does not exist
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
A tab for a non-existing "talk" namespace is shown. The topic namespace is an outlier in that it has no talk namespace at all. (In fact, its id 2601 indicates it is a talk namespace itself)

The tab links to Special:BadTitle/NS2601:.

What should have happened instead?:
The talk tab shouldn't be visible.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

The fact that this only occurs in Minerva and Vector-2022 indicates that there is something going wrong with the associated pages portlet, as this issue does not occur in Legacy Vector.

Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
Jdlrobson subscribed.

given this is impacting Minerva and Vector 2022, this sounds very much like an issue with the hook inside Flow. Looks like it's removing the menu item from p-namespaces BUT not p-associated-pages. Growth team, let me know if I can help.

kostajh subscribed.

Seems close enough to the criteria for issues we will work on in our "non maintained" projects, so moving this to current sprint.

I think the issue is this block of code:

	if ( isset( $links['namespaces']['topic_talk'] ) ) {
				// hide discussion page in Topic namespace(which is already discussion)
				unset( $links['namespaces']['topic_talk'] );
				// hide protection (topic protection is done via moderation)
				unset( $links['actions']['protect'] );
				// topic pages are also not movable
				unset( $links['actions']['move'] );
			}

It now also needs to apply to $links['associated-pages'] when Skin::supportsMenu('associated-pages') is truthy (but you can also do it unconditionally).

Change 886452 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/extensions/Flow@master] Hide non-existing Topic_talk namespace in associated-pages portlet

https://gerrit.wikimedia.org/r/886452

Change 886452 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Hide non-existing Topic_talk namespace in associated-pages portlet

https://gerrit.wikimedia.org/r/886452

Whoops. Sorry guess this needs QA

Etonkovidova subscribed.

Whoops. Sorry guess this needs QA

Thx, @Jdlrobson! Checked in wmf.23 - the issue is fixed.