Page MenuHomePhabricator

Stop using MWException in Wikimedia deployed code
Open, Needs TriagePublic

Description

This task is specifically about replacing MWException in WMF-deployed code, for the reasons explained in T86704. Any patch related to phasing out MWException can be tagged with this task, so think twice before subscribing :)

Codesearch:

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/ActiveAbstractmaster+39 -38
mediawiki/coremaster+9 -13
mediawiki/extensions/Flowmaster+52 -146
mediawiki/coremaster+44 -94
mediawiki/coremaster+77 -152
mediawiki/coremaster+59 -102
mediawiki/coremaster+43 -74
mediawiki/extensions/Wikibasemaster+2 -3
mediawiki/coremaster+9 -10
mediawiki/coremaster+59 -98
mediawiki/extensions/LiquidThreadsmaster+11 -15
mediawiki/extensions/Flowmaster+22 -37
mediawiki/extensions/Flowmaster+67 -122
mediawiki/extensions/CentralNoticewmf_deploy+1 -2
mediawiki/extensions/MathSearchmaster+1 -1
mediawiki/extensions/MediaModerationmaster+268 -81
mediawiki/extensions/WikibaseMediaInfomaster+5 -12
mediawiki/extensions/WikibaseCirrusSearchmaster+2 -11
mediawiki/extensions/WikibaseLexememaster+4 -20
mediawiki/extensions/Wikibasemaster+25 -34
mediawiki/extensions/Wikibasemaster+53 -59
mediawiki/extensions/Wikibasemaster+26 -80
mediawiki/extensions/Wikibasemaster+35 -77
mediawiki/extensions/Translatemaster+24 -35
mediawiki/extensions/DonationInterfacemaster+0 -12
mediawiki/extensions/WikibaseLexemeCirrusSearchmaster+0 -5
mediawiki/coremaster+82 -134
mediawiki/extensions/GrowthExperimentsmaster+1 -46
mediawiki/vendormaster+55 -55
mediawiki/coremaster+85 -66
mediawiki/coremaster+63 -124
mediawiki/extensions/Scribuntomaster+37 -35
mediawiki/extensions/Echomaster+25 -37
mediawiki/coremaster+32 -42
mediawiki/extensions/MediaModerationmaster+1 -7
mediawiki/coremaster+126 -185
mediawiki/extensions/CirrusSearchmaster+18 -57
mediawiki/extensions/MediaSearchmaster+58 -22
mediawiki/extensions/Mathmaster+53 -40
mediawiki/extensions/EventBusmaster+2 -18
mediawiki/extensions/OATHAuthmaster+7 -48
mediawiki/extensions/ORESmaster+10 -16
mediawiki/extensions/SyntaxHighlight_GeSHimaster+2 -5
mediawiki/extensions/ProofreadPagemaster+30 -49
mediawiki/extensions/ExternalGuidancemaster+2 -2
mediawiki/extensions/JsonConfigmaster+6 -6
mediawiki/extensions/TimedMediaHandlermaster+10 -22
mediawiki/extensions/Echomaster+11 -57
mediawiki/skins/MinervaNeuemaster+0 -40
mediawiki/extensions/MachineVisionmaster+6 -13
mediawiki/extensions/UploadWizardmaster+4 -4
mediawiki/extensions/WikiLambdamaster+3 -6
mediawiki/coremaster+92 -119
mediawiki/extensions/VipsScalermaster+2 -2
mediawiki/extensions/CentralNoticemaster+1 -2
mediawiki/extensions/ImageSuggestionsmaster+0 -2
mediawiki/extensions/ApiFeatureUsagemaster+6 -6
mediawiki/extensions/Newslettermaster+4 -5
mediawiki/extensions/EntitySchemamaster+3 -5
mediawiki/extensions/WikibaseQualityConstraintsmaster+2 -2
mediawiki/skins/Nostalgiamaster+0 -2
mediawiki/extensions/CommonsMetadatamaster+5 -3
mediawiki/extensions/CentralAuthmaster+8 -10
mediawiki/extensions/PageTriagemaster+1 -13
mediawiki/extensions/Wikistoriesmaster+0 -1
mediawiki/extensions/GlobalBlockingmaster+2 -7
mediawiki/extensions/AbuseFiltermaster+17 -26
mediawiki/extensions/intersectionmaster+2 -2
mediawiki/extensions/ChessBrowsermaster+2 -2
mediawiki/extensions/WikimediaEditorTasksmaster+2 -2
mediawiki/extensions/SubPageList3master+0 -1
mediawiki/extensions/wikihieromaster+0 -2
mediawiki/extensions/Thanksmaster+0 -2
mediawiki/extensions/ArticlePlaceholdermaster+0 -3
mediawiki/extensions/GeoDatamaster+0 -6
mediawiki/extensions/CheckUsermaster+14 -21
mediawiki/services/parsoidmaster+1 -1
mediawiki/extensions/MobileFrontendmaster+3 -7
mediawiki/extensions/WikimediaMaintenancemaster+0 -1
mediawiki/extensions/Gadgetsmaster+1 -1
mediawiki/extensions/AntiSpoofmaster+2 -2
mediawiki/extensions/Wikisourcemaster+2 -2
mediawiki/extensions/ConfirmEditmaster+4 -5
mediawiki/extensions/TitleBlacklistmaster+2 -2
mediawiki/extensions/Collectionmaster+0 -1
mediawiki/extensions/Cognatemaster+3 -5
mediawiki/extensions/Wikibasemaster+13 -13
mediawiki/extensions/Translatemaster+76 -73
mediawiki/coremaster+24 -37
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 928585 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/skins/MinervaNeue@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928585

Change 928581 merged by jenkins-bot:

[mediawiki/extensions/MachineVision@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928581

Change 928585 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928585

Change 928603 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/ProofreadPage@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928603

Change 928126 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Replace some usages of deprecated MWException

https://gerrit.wikimedia.org/r/928126

Change 928626 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/GrowthExperiments@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928626

Change 928629 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CirrusSearch@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928629

Change 928579 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928579

Change 928163 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928163

Change 928534 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928534

Change 928530 merged by jenkins-bot:

[mediawiki/extensions/ExternalGuidance@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928530

Change 928161 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928161

Change 928603 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928603

Change 928607 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CentralNotice@wmf_deploy] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928607

Change 928653 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/EventBus@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928653

Change 928656 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/LiquidThreads@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928656

Change 928668 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/MediaSearch@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928668

Change 928673 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/OATHAuth@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928673

Change 928653 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928653

Change 928675 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Replace some more usages of deprecated MWException

https://gerrit.wikimedia.org/r/928675

Change 928684 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Math@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928684

Change 928686 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Echo@master] Replace remaining usages of deprecated MWException

https://gerrit.wikimedia.org/r/928686

Change 928690 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Wikibase@master] Replace some usages of deprecated MWException

https://gerrit.wikimedia.org/r/928690

Change 928694 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Wikibase@master] Replace some usages of deprecated MWException, part 2

https://gerrit.wikimedia.org/r/928694

Change 928821 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/MediaModeration@master] Remove broken exception handling

https://gerrit.wikimedia.org/r/928821

Change 928684 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928684

Change 928830 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Wikibase@master] Replace usages of deprecated MWException, part 3

https://gerrit.wikimedia.org/r/928830

Change 928835 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Scribunto@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928835

Change 926666 merged by jenkins-bot:

[mediawiki/core@master] Replace more usages of deprecated MWException

https://gerrit.wikimedia.org/r/926666

Change 928675 merged by jenkins-bot:

[mediawiki/core@master] Replace some more usages of deprecated MWException

https://gerrit.wikimedia.org/r/928675

Change 928629 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928629

Change 928668 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928668

Change 928821 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Remove broken exception handling

https://gerrit.wikimedia.org/r/928821

Change 928686 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Replace remaining usages of deprecated MWException

https://gerrit.wikimedia.org/r/928686

Change 928852 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Flow@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928852

Change 928855 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Flow@master] Replace deprecated MWException, part 2

https://gerrit.wikimedia.org/r/928855

Change 928860 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928860

Change 928863 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Translate@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928863

Change 928835 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928835

Change 928868 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] media: Replace deprecated MWException

https://gerrit.wikimedia.org/r/928868

Change 928878 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928878

Change 928860 merged by jenkins-bot:

[mediawiki/core@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928860

Change 928868 merged by jenkins-bot:

[mediawiki/core@master] media: Replace deprecated MWException

https://gerrit.wikimedia.org/r/928868

Change 928957 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928957

Change 928961 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928961

Change 928966 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Replace deprecated MWException, deprecate wfUnpack

https://gerrit.wikimedia.org/r/928966

Change 928984 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Replace more instances of deprecated MWException

https://gerrit.wikimedia.org/r/928984

Change 928991 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Replace more instances of unchecked MWException

https://gerrit.wikimedia.org/r/928991

Change 929160 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump parsoid to 0.18.0-a14

https://gerrit.wikimedia.org/r/929160

Change 929160 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.18.0-a14

https://gerrit.wikimedia.org/r/929160

Change 928626 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928626

Change 928878 merged by jenkins-bot:

[mediawiki/core@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928878

Change 928944 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/DonationInterface@master] Remove unnecessary `@throws MWException`

https://gerrit.wikimedia.org/r/928944

Change 929416 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Remove `@throws MWException` for unchecked exceptions

https://gerrit.wikimedia.org/r/929416

Change 929416 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Remove `@throws MWException` for unchecked exceptions

https://gerrit.wikimedia.org/r/929416

Change 928944 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Remove unnecessary `@throws MWException`

https://gerrit.wikimedia.org/r/928944

Change 929415 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/ActiveAbstract@master] Improve exception handling a bit

https://gerrit.wikimedia.org/r/929415

Change 928863 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928863

Change 930163 had a related patch set uploaded (by EllenR; author: Daimona Eaytoy):

[mediawiki/extensions/MediaModeration@master] trying to commit, fixes PhotoDNA file extension

https://gerrit.wikimedia.org/r/930163

Change 928690 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace some usages of deprecated MWException

https://gerrit.wikimedia.org/r/928690

Change 928694 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace some usages of deprecated MWException, part 2

https://gerrit.wikimedia.org/r/928694

Change 930848 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Wikibase@master] Replace usages of deprecated MWException, part 4

https://gerrit.wikimedia.org/r/930848

Change 928830 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace usages of deprecated MWException, part 3

https://gerrit.wikimedia.org/r/928830

Change 930848 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace usages of deprecated MWException, part 4

https://gerrit.wikimedia.org/r/930848

Change 931665 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/WikibaseCirrusSearch@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/931665

Change 931668 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/WikibaseLexeme@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/931668

Change 931670 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/WikibaseMediaInfo@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/931670

Change 931668 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/931668

Change 931665 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/931665

Change 931670 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/931670

Change 930163 abandoned by EllenR:

[mediawiki/extensions/MediaModeration@master] Code to fix verification of PhotoDNA images

Reason:

duplicate effort of futility

https://gerrit.wikimedia.org/r/930163

Change 937184 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/MathSearch@master] Catch non MWExceptions in MathId generation

https://gerrit.wikimedia.org/r/937184

Change 937184 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Catch non MWExceptions in MathId generation

https://gerrit.wikimedia.org/r/937184

Change 928607 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf_deploy] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928607

Change 983183 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Reparent trivial subclasses of MWException

https://gerrit.wikimedia.org/r/983183

Change 983186 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Wikibase@master] Reparent trivial subclasses of MWException

https://gerrit.wikimedia.org/r/983186

Change 928852 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928852

Change 928855 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Replace deprecated MWException, part 2

https://gerrit.wikimedia.org/r/928855

Change 983257 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Flow@master] Replace subclasses of MWException

https://gerrit.wikimedia.org/r/983257

Change 928656 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928656

Change 928957 merged by jenkins-bot:

[mediawiki/core@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928957

Change 983183 merged by jenkins-bot:

[mediawiki/core@master] Reparent trivial subclasses of MWException

https://gerrit.wikimedia.org/r/983183

Change 983186 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Reparent trivial subclass of MWException

https://gerrit.wikimedia.org/r/983186

Change 928961 merged by jenkins-bot:

[mediawiki/core@master] Replace deprecated MWException

https://gerrit.wikimedia.org/r/928961

Change 928966 merged by jenkins-bot:

[mediawiki/core@master] Replace more usages of deprecated MWException

https://gerrit.wikimedia.org/r/928966

Change 928984 merged by jenkins-bot:

[mediawiki/core@master] Replace more instances of deprecated MWException

https://gerrit.wikimedia.org/r/928984

Change 928991 merged by jenkins-bot:

[mediawiki/core@master] Replace more instances of unchecked MWException

https://gerrit.wikimedia.org/r/928991

Change 983257 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Replace subclasses of MWException

https://gerrit.wikimedia.org/r/983257

Change 993455 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Replace unchecked MWException with SPL exceptions

https://gerrit.wikimedia.org/r/993455

Change 993455 merged by jenkins-bot:

[mediawiki/core@master] Replace unchecked MWException with SPL exceptions

https://gerrit.wikimedia.org/r/993455

Daimona moved this task from Backlog to Doing on the User-Daimona board.
Daimona updated the task description. (Show Details)