Page MenuHomePhabricator

ResourcesTest::testUnsatisfiableDependencies: The module 'propertySuggester.suggestions' must not have target 'mobile' because its dependency 'wikibase.view.ControllerViewFactory' does not have it
Closed, DuplicatePublic

Description

09:29:40 There was 1 failure:
09:29:40 
09:29:40 1) ResourcesTest::testUnsatisfiableDependencies
09:29:40 * The module 'propertySuggester.suggestions' must not have target 'mobile' because its dependency 'wikibase.view.ControllerViewFactory' does not have it
09:29:40 
09:29:40 Failed asserting that two arrays are equal.
09:29:40 --- Expected
09:29:40 +++ Actual
09:29:40 @@ @@
09:29:40  Array (
09:29:40 +    0 => 'propertySuggester.suggestions'
09:29:40  )
09:29:40 
09:29:40 /workspace/src/tests/phpunit/structure/ResourcesTest.php:150
09:29:40 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
09:29:40 === Logs generated by test case
09:29:40 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
09:29:40 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:29:40 ===
09:29:40 
09:29:40 FAILURES!
09:29:40 Tests: 27892, Assertions: 93348, Failures: 1, Skipped: 84.

Blocking CI and merges to GrowthExperiments, among other extensions. Caused by rMW01aec63c217f: ResourceLoader: Default File modules to mobile and desktop targets, I assume.

Event Timeline

kostajh triaged this task as Unbreak Now! priority.Feb 1 2023, 9:13 AM
kostajh created this task.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 885735 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PropertySuggester@master] ResourceLoader: Define "desktop" only target for propertySuggester.suggestions

https://gerrit.wikimedia.org/r/885735

Change 885432 had a related patch set uploaded (by Kosta Harlan; author: Jdlrobson):

[mediawiki/extensions/PropertySuggester@master] Explicitly mark target of module

https://gerrit.wikimedia.org/r/885432

Change 885432 merged by jenkins-bot:

[mediawiki/extensions/PropertySuggester@master] Explicitly mark target of module

https://gerrit.wikimedia.org/r/885432

Change 885735 abandoned by Kosta Harlan:

[mediawiki/extensions/PropertySuggester@master] ResourceLoader: Define "desktop" only target for propertySuggester.suggestions

Reason:

See I92e284e5d42568d3bcbdb40a239641bdca09fe7f

https://gerrit.wikimedia.org/r/885735