Page MenuHomePhabricator
Create Task
Maniphest T328500

ResourcesTest::testUnsatisfiableDependencies blocks CI on certain extensions
Closed, ResolvedPublicBUG REPORT
Actions

Description

As a result of certain extensions not running in CI for MediaWiki core, this slipped through the net.

Adding this to Phabricator in case others run into it and not sure what to do.

If you see any jenkins -1s and PHPUnit errors for “ResourcesTest::testUnsatisfiableDependencies” please follow its instruction and set "targets": "desktop" or "targets": "mobile" in the definition.

Details

SubjectRepoBranchLines +/-
Revert "Load PageTriageExternalTags on mobile and desktop"mediawiki/extensions/PageTriagemaster+0 -2
Load PageTriageExternalTags on mobile and desktopmediawiki/extensions/PageTriagemaster+2 -0
Explicitly mark target of modulemediawiki/extensions/PropertySuggestermaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jan 31 2023, 10:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2023, 10:44 PM
gerritbot added a comment.Jan 31 2023, 10:44 PM

Change 885432 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/PropertySuggester@master] Explicitly mark target of module

https://gerrit.wikimedia.org/r/885432

gerritbot added a project: Patch-For-Review.Jan 31 2023, 10:44 PM
Maintenance_bot added a project: Wikidata.Jan 31 2023, 10:45 PM
Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptJan 31 2023, 10:45 PM
Urbanecm triaged this task as Unbreak Now! priority.Feb 1 2023, 9:43 AM
Urbanecm merged a task: T328522: ResourcesTest::testUnsatisfiableDependencies: The module 'propertySuggester.suggestions' must not have target 'mobile' because its dependency 'wikibase.view.ControllerViewFactory' does not have it.
Urbanecm added a subscriber: kostajh.
gerritbot added a comment.Feb 1 2023, 9:47 AM

Change 885432 merged by jenkins-bot:

[mediawiki/extensions/PropertySuggester@master] Explicitly mark target of module

https://gerrit.wikimedia.org/r/885432

kostajh closed this task as Resolved.Feb 1 2023, 10:04 AM
kostajh claimed this task.
kostajh mentioned this in rEPSfd079bce9efb: Explicitly mark target of module.Feb 1 2023, 10:06 AM
kostajh reopened this task as Open.Feb 1 2023, 10:20 AM
kostajh added a subtask: T328522: ResourcesTest::testUnsatisfiableDependencies: The module 'propertySuggester.suggestions' must not have target 'mobile' because its dependency 'wikibase.view.ControllerViewFactory' does not have it.

Leaving this open as a parent task, let's make subtasks for specific extensions. I don't know how to "unmerge" T328522 but I've added it as a subtask of this one.

kostajh lowered the priority of this task from Unbreak Now! to Needs Triage.Feb 1 2023, 10:21 AM
kostajh edited projects, added MediaWiki-ResourceLoader; removed [DEPRECATED] wdwb-tech, Wikidata, MediaWiki-extensions-PropertySuggester.Feb 1 2023, 10:24 AM
Restricted Application added a project: Performance-Team. · View Herald TranscriptFeb 1 2023, 10:24 AM
kostajh added a parent task: T127268: Dismantle ResourceLoader's "targets" system.Feb 1 2023, 10:27 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 1 2023, 10:30 AM
gerritbot added a comment.Feb 1 2023, 8:51 PM

Change 885881 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/PageTriage@master] Load PageTriageExternalTags on mobile and desktop

https://gerrit.wikimedia.org/r/885881

gerritbot added a project: Patch-For-Review.Feb 1 2023, 8:51 PM
gerritbot added a comment.Feb 1 2023, 9:15 PM

Change 885881 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Load PageTriageExternalTags on mobile and desktop

https://gerrit.wikimedia.org/r/885881

Maintenance_bot removed a project: Patch-For-Review.Feb 1 2023, 9:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 1 2023, 10:00 PM
gerritbot added a comment.Feb 2 2023, 9:54 AM

Change 885936 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] Revert "Load PageTriageExternalTags on mobile and desktop"

https://gerrit.wikimedia.org/r/885936

gerritbot added a project: Patch-For-Review.Feb 2 2023, 9:54 AM
gerritbot added a comment.Feb 2 2023, 11:21 PM

Change 885936 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Revert "Load PageTriageExternalTags on mobile and desktop"

https://gerrit.wikimedia.org/r/885936

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2023, 11:30 PM
Krinkle moved this task from Inbox to External on the MediaWiki-ResourceLoader board.Feb 6 2023, 8:16 PM
Krinkle moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.
Krinkle subscribed.

Do the above patches address the CI blockage or is there more to do?

kostajh added a comment.Feb 6 2023, 8:52 PM
In T328500#8590954, @Krinkle wrote:

Do the above patches address the CI blockage or is there more to do?

They address it for PageTriage. In T328500#8577626 I suggested that we leave this open as a parent task, in case someone else finds this task from CI failures for their extension. But since it's been a few days, perhaps we can just close it.

kostajh closed subtask T328535: ResourcesTest::testUnsatisfiableDependencies: The module 'ext.pageTriage.views.toolbar' must not have target 'mobile' because its dependency 'ext.pageTriage.externalTagsOptions' does not have it as Resolved.Feb 6 2023, 8:52 PM
Jdlrobson closed this task as Resolved.Feb 6 2023, 10:46 PM

I think it's fine to resolve this now. Presumably we will have caught all the Wikimedia deployed code issues by now, and this is searchable on Phabricator even when resolved if not.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL