[XS] Search preview desktop: the spacing around the close button is not consistent
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Sneha
	Feb 7 2023, 3:20 PM

Description

Steps to replicate the issue (include links if applicable):

Open preview

What happens?:

The spacing on the left of the button is more than the top. It makes the button look slightly displaced.

What should have happened instead?:

The spacing around the close button should be equal distance (12 px) from left and top edge.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	Search preview desktop: the spacing around the close button is not consistent	mediawiki/extensions/SearchVue	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: rESVU02b2ff44e13f: Search preview desktop: the spacing around the close button is not consistent

Event Timeline

Sneha created this task.Feb 7 2023, 3:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2023, 3:20 PM

Sneha updated the task description. (Show Details)Feb 7 2023, 3:21 PM

CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Feb 20 2023, 2:57 PM

CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.

CBogen renamed this task from Search preview desktop: the spacing around the close button is not consistent to [XS] Search preview desktop: the spacing around the close button is not consistent.Mar 22 2023, 4:29 PM

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.

SimoneThisDot claimed this task.Apr 12 2023, 9:28 AM

SimoneThisDot moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.

Change 908213 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Search preview desktop: the spacing around the close button is not consistent

https://gerrit.wikimedia.org/r/908213

gerritbot added a project: Patch-For-Review.Apr 12 2023, 9:47 AM

SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Apr 12 2023, 9:47 AM

Change 908213 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Search preview desktop: the spacing around the close button is not consistent

https://gerrit.wikimedia.org/r/908213

SimoneThisDot mentioned this in rESVU02b2ff44e13f: Search preview desktop: the spacing around the close button is not consistent.Apr 12 2023, 1:17 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 12 2023, 1:30 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 12 2023, 2:00 PM

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.May 9 2023, 1:16 PM

Checked (the screenshot below is from ruwiki wmf.8):

Screen Shot 2023-05-12 at 12.11.33 PM.png (986×860 px, 413 KB)

Screen Shot 2023-05-12 at 12.11.51 PM.png (1×808 px, 428 KB)

	F36994549: Screen Shot 2023-05-12 at 12.11.51 PM.png
	May 12 2023, 7:14 PM

	F36994547: Screen Shot 2023-05-12 at 12.11.33 PM.png
	May 12 2023, 7:14 PM

	F36783093: close button spacing issue.png
	Feb 7 2023, 3:21 PM

	F36783084: Close button spacing issue.png
	Feb 7 2023, 3:20 PM

[XS] Search preview desktop: the spacing around the close button is not consistentClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

[XS] Search preview desktop: the spacing around the close button is not consistent
Closed, ResolvedPublicBUG REPORT
Actions