Page MenuHomePhabricator
Create Task
Maniphest T329127

Remove remaining SVG fallback hacks in MediaWiki core
Closed, ResolvedPublic
Actions

Description

Follow-up to T248062. The same technique has made its way into our PHP code.

Details

SubjectRepoBranchLines +/-
ResourceLoader: Remove SVG fallback hack from SkinModulemediawiki/coremaster+10 -18
ResourceLoader: Remove unused rasterized URL in ImageModule::getCssDeclarationsmediawiki/coremaster+5 -8
Remove remaining SVG fallback hacksmediawiki/coremaster+6 -18
ResourceLoader: Remove SVG fallback hack from ImageModulemediawiki/coremaster+8 -31
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Feb 7 2023, 11:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2023, 11:25 PM
gerritbot added a comment.Feb 7 2023, 11:43 PM

Change 887426 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Remove SVG fallback hack from ResourceLoader\ImageModule

https://gerrit.wikimedia.org/r/887426

gerritbot added a project: Patch-For-Review.Feb 7 2023, 11:43 PM

Change 887427 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Remove SVG fallback hack from ResourceLoader\SkinModule

https://gerrit.wikimedia.org/r/887427

gerritbot added a comment.Feb 7 2023, 11:43 PM

Change 887428 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Remove remaining SVG fallback hacks

https://gerrit.wikimedia.org/r/887428

matmarex added a comment.Feb 7 2023, 11:45 PM

That takes care of MediaWiki core. There's more in skins and extensions if anyone is feeling bored: https://codesearch-beta.wmcloud.org/search/?q=linear-gradient%5C(%5Cs*transparent%5Cs*%2C%5Cs*transparent

Lucas_Werkmeister_WMDE subscribed.Feb 8 2023, 9:38 AM

Isn’t this a duplicate of T328144: Drop PNG fallback for SVG icons / etc. across all Wikimedia products?

Jdforrester-WMF subscribed.Feb 8 2023, 12:56 PM
In T329127#8596827, @Lucas_Werkmeister_WMDE wrote:

Isn’t this a duplicate of T328144: Drop PNG fallback for SVG icons / etc. across all Wikimedia products?

Yes. I'll re-title this to be about MW core and make it a sub-task.

Jdforrester-WMF renamed this task from Remove remaining SVG fallback hacks to Remove remaining SVG fallback hacks in MediaWiki core.Feb 8 2023, 12:56 PM
Jdforrester-WMF added a parent task: T328144: Drop PNG fallback for SVG icons / etc. across all Wikimedia products.
gerritbot added a comment.Feb 8 2023, 1:13 PM

Change 887426 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Remove SVG fallback hack from ImageModule

https://gerrit.wikimedia.org/r/887426

gerritbot added a comment.Feb 8 2023, 1:14 PM

Change 887427 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Remove SVG fallback hack from SkinModule

https://gerrit.wikimedia.org/r/887427

gerritbot added a comment.Feb 8 2023, 1:14 PM

Change 887428 merged by jenkins-bot:

[mediawiki/core@master] Remove remaining SVG fallback hacks

https://gerrit.wikimedia.org/r/887428

Jdforrester-WMF closed this task as Resolved.Feb 8 2023, 1:15 PM

Provisionally done?

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2023, 1:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 8 2023, 2:00 PM
gerritbot added a comment.Jul 13 2023, 1:42 AM

Change 937561 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Remove unused rasterized URL in ImageModule::getCssDeclarations

https://gerrit.wikimedia.org/r/937561

gerritbot added a project: Patch-For-Review.Jul 13 2023, 1:42 AM
gerritbot added a comment.Jul 13 2023, 12:41 PM

Change 937561 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Remove unused rasterized URL in ImageModule::getCssDeclarations

https://gerrit.wikimedia.org/r/937561

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2023, 1:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL