Page MenuHomePhabricator
Create Task
Maniphest T329154

Content Translation is broken in test wiki
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  1. Visit Content Translation in test wiki and start a translation:

e.g. https://test.wikipedia.org/w/index.php?title=Special:ContentTranslation&from=en&to=el&page=Eric%20Roberts

What happens?:
The source article doesn't load and the tool is broken.

Note: The issue is a regression caused by this patch, that was trying to adjust the code following the latest changes in Visual Editor extension.

Other information (browser name/version, screenshots, etc.):
Screencast of the issue:

Details

SubjectRepoBranchLines +/-
CX: Provide the appropriate arguments to ve.ui.CXSurface constructormediawiki/extensions/ContentTranslationwmf/1.40.0-wmf.22+1 -1
CX: Provide the appropriate arguments to ve.ui.CXSurface constructormediawiki/extensions/ContentTranslationmaster+1 -1
Customize query in gerrit

Event Timeline

ngkountas created this task.Feb 8 2023, 10:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2023, 10:41 AM
ngkountas claimed this task.Feb 8 2023, 10:41 AM
ngkountas triaged this task as Unbreak Now! priority.
ngkountas added a project: ContentTranslation.
ngkountas updated the task description. (Show Details)Feb 8 2023, 10:44 AM
ngkountas moved this task from Priority: Unified Content & Section Translation to In Progress on the Language-Team (Language-2023-January-March) board.
ngkountas added a comment.Feb 8 2023, 11:27 AM

Screencast from my local installation before fix:

gerritbot added a comment.Feb 8 2023, 11:30 AM

Change 887768 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Provide the appropriate arguments to ve.ui.CXSurface constructor

https://gerrit.wikimedia.org/r/887768

gerritbot added a project: Patch-For-Review.Feb 8 2023, 11:30 AM
ngkountas added a comment.Feb 8 2023, 11:34 AM

Screencast after fix:

ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2023-January-March) board.Feb 8 2023, 6:52 PM
• santhosh added subscribers: KartikMistry, • santhosh.Feb 9 2023, 4:31 AM

@KartikMistry Need to backport this fix

gerritbot added a comment.Feb 9 2023, 4:44 AM

Change 887847 had a related patch set uploaded (by KartikMistry; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@wmf/1.40.0-wmf.22] CX: Provide the appropriate arguments to ve.ui.CXSurface constructor

https://gerrit.wikimedia.org/r/887847

gerritbot added a comment.Feb 9 2023, 4:47 AM

Change 887768 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Provide the appropriate arguments to ve.ui.CXSurface constructor

https://gerrit.wikimedia.org/r/887768

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 9 2023, 5:00 AM
gerritbot added a comment.Feb 9 2023, 8:18 AM

Change 887847 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.40.0-wmf.22] CX: Provide the appropriate arguments to ve.ui.CXSurface constructor

https://gerrit.wikimedia.org/r/887847

Stashbot added a comment.Feb 9 2023, 8:19 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-09T08:19:04Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:887847|CX: Provide the appropriate arguments to ve.ui.CXSurface constructor (T329154)]]

Stashbot added a comment.Feb 9 2023, 8:21 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-09T08:20:59Z] <kartik@deploy1002> kartik: Backport for [[gerrit:887847|CX: Provide the appropriate arguments to ve.ui.CXSurface constructor (T329154)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Maintenance_bot removed a project: Patch-For-Review.Feb 9 2023, 8:30 AM
Stashbot added a comment.Feb 9 2023, 8:32 AM

Mentioned in SAL (#wikimedia-operations) [2023-02-09T08:32:14Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:887847|CX: Provide the appropriate arguments to ve.ui.CXSurface constructor (T329154)]] (duration: 13m 10s)

KartikMistry moved this task from In Review to Done on the Language-Team (Language-2023-January-March) board.Feb 9 2023, 8:44 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 9 2023, 9:00 AM
Nikerabbit closed this task as Resolved.Feb 23 2023, 8:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL