In rEGRE6ad99ddd7f98: Declare VisualEditor a hard dependency we made VisualEditor a hard dependency for GrowthExperiments. But the phpbench job for GrowthExperiments doesn't clone VisualEditor, which means the job fails as soon as we try to load GrowthExperiments.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T340453 [Epic] FY 2023-24 Growth Maintenance Work | |||
| Open | None | T329280 phpbench job for GrowthExperiments fails due to missing dependency |
Event Timeline
Comment Actions
I don't think so, because that is for phan, while this is for the new-ish (T291549) phpbench job. For phan jobs, we have a way to define dependencies, but no simple mechanism exists for phpbench. I guess we could say that phpbench jobs for extensions should set up the same dependencies defined in the phan dependency list?
Comment Actions
I don't think so, because that is for phan, while this is for the new-ish (T291549) phpbench job.
Oh, right.
I guess we could say that phpbench jobs for extensions should set up the same dependencies defined in the phan dependency list?
I think by default phpbench only needs the dependencies specified in extension.json. Phan might need more because a construct like if ( $extensionRegistry->isLoaded(...) ) { OtherExtension::someMethod() } can be executed successfully without the other extension being installed, but phan would still error out. But then there is no harm in installing some extra extensions if that means less configuration.