@S_Mukuti One issue that popped up so far is when you don't have a wikidata no associated with the article, if you keep on clicking on the AutosuggestSiteLink in the side toolbar, multiple popups occur as seen in the screenshot below.

OS: macOS 13.2
Browser: Chrome 111
Skins: Vector 2022
Test Link: https://test.wikipedia.org/wiki/Page612

@GMikesell-WMF The multiple popups issue has been resolved in the latest patch.

@S_Mukuti The first screenshot, after the AutosuggestSiteLink pops up when you click on it, the popup stays open for like 25 seconds. When it disappears and you try to click on the link again, it does not pop up anymore. As for the 2nd screenshot, this could be as designed but just making sure since all the other skins pop up the same way except for the Minerva skin. This pops up at the bottom in a black bar.

OS: macOS 13.2, Windows 11
Browser: Chrome 112, Edge 112, Firefox 111, Safari 16.3
Skins: Vector 2022, Vector 2010, Minerva, Timeless, Monobook
Test Link: https://test.wikipedia.org/wiki/Page612

AutosuggestSiteLink Popups Stop

Minerva Skin

@GMikesell-WMF I think this patch https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/32/diffs?commit_id=4e99598e214e9a4ed743f5cb742be4973ecbcfd9 solved the issue by having a tag for each popup so that it is displayed independently whenever the AutoSuggestSitelink button is clicked.

@S_Mukuti Actually the latest code is not having the Autosuggest link pop up at all right now as seen https://phabricator.wikimedia.org/T330972#8787473. I can test this after when this has been resolved. Thanks!

s-mukuti opened https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/33

AutosuggestSitelink.js: Resolve search entire DOM error

samtar merged https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/33

AutosuggestSitelink.js: Resolve search entire DOM error

@S_Mukuti - Please check out some of the results below. I'm not sure why the Rose link doesn't do anything when you click on the Autosuggest link.

OS: macOS 13.3, Windows 11
Browser: Chrome 114, Edge 113, Firefox 113, Safari 16.4
Skins: Vector 2022, Vector 2010, Minerva, Timeless, Monobook

Site with no Autosuggest Link (Test Link: https://test.wikipedia.org/wiki/Page612 )- @JSengupta-WMF What do you think of this design when you click on it multiple times? Did you want it just to stick or have the autosuggest link removed when you click on it again? It also seems the only way to get out of the Autosuggest link is to click refresh. If you click anywhere on the outside, it doesn't do anything and stays.

https://test.wikipedia.org/wiki/Rose- For some reason, nothing happened when you click on the Autosuggest link

https://test.wikipedia.org/wiki/Dog - Good

s-mukuti opened https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/36

AutosuggestSitelink.js: Notify when an a page is already linked to wikidata item.

samtar merged https://gitlab.wikimedia.org/repos/commtech/autosuggest-sitelink/-/merge_requests/36

AutosuggestSitelink.js: Notify when an a page is already linked to wikidata item.

Site with no Autosuggest Link (Test Link: https://test.wikipedia.org/wiki/Page612 )- @JSengupta-WMF What do you think of this design when you click on it multiple times? Did you want it just to stick or have the autosuggest link removed when you click on it again? It also seems the only way to get out of the Autosuggest link is to click refresh. If you click anywhere on the outside, it doesn't do anything and stays.

@GMikesell-WMF The sliding up animation when you click on the auto suggest link multiple times could be quite disturbing to the user and give a wrong impression that every pop up contains some new information, so I would definitely recommend that it should just stick to it's original state even if the ink is clicked multiple times. I would also suggest there should be a way to dismiss it. Could be with a close button (X) on the pop up or clicking anywhere on the page or even clicking on the pop up itself. I guess the long timeout of 25 seconds is due to the fact that it has an actionable link.

@JSengupta-WMF - Thanks for the info!

@S_Mukuti - If you need me to create any separate tasks or if you are just going to work off this task, please keep me posted. Thanks!

@S_Mukuti Since I no longer come across the Rose article issue and I created T339169: Autosuggest sliding up animation and closing it out for the previous issues above, I will move this to Done. Thanks!