Page MenuHomePhabricator
Create Task
Maniphest T329643

CommTech - Remove unnecessary targets definitions
Closed, ResolvedPublic
Actions

Description

In https://gerrit.wikimedia.org/r/c/mediawiki/core/+/865811 we updated the default for targets to be ["desktop", "mobile"]. This means that any extensions/skins defining this are now redundant and can remove these definitions,

The following query marks some of the offenders (regex to be improved later):
https://codesearch.wmcloud.org/search/?q=%22targets%22&i=nope&files=(extension%7Cskin).json&excludeFiles=&repos=

TODO

  • Remove the lines
  • Bump the MediaWiki required version to 1.40

Details

SubjectRepoBranchLines +/-
extension.json: Remove unnecessary targets definitionsmediawiki/extensions/TemplateWizardmaster+1 -2
extension.json: remove unnecessary target definitionsmediawiki/extensions/CodeMirrormaster+1 -18
extension.json: Update minimum mediawiki versionmediawiki/extensions/Phonosmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

KSiebert created this task.Feb 14 2023, 4:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2023, 4:53 PM
Aklapper removed a project: MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 15 2023, 9:57 AM
TheresNoTime subscribed.Mar 27 2023, 9:16 AM

Phonos

• S_Mukuti claimed this task.Mar 27 2023, 10:15 AM
KSiebert edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.Mar 27 2023, 10:37 AM
Restricted Application edited projects, added Community-Tech; removed Community-Tech (CommTech-Kanban). · View Herald TranscriptMar 27 2023, 10:37 AM
gerritbot added a comment.Mar 27 2023, 10:52 AM

Change 902615 had a related patch set uploaded (by Sarah Mukuti; author: Sarah Mukuti):

[mediawiki/extensions/Phonos@master] Bug: T329643

https://gerrit.wikimedia.org/r/902615

gerritbot added a project: Patch-For-Review.Mar 27 2023, 10:52 AM
gerritbot added a comment.Mar 27 2023, 12:07 PM

Change 902616 had a related patch set uploaded (by Samtar; author: Sarah Mukuti):

[mediawiki/extensions/Phonos@master] extension.json: Update minimum mediawiki version

https://gerrit.wikimedia.org/r/902616

• S_Mukuti mentioned this in rEPHNa71fc96c4871: extension.json: Remove unnecessary targets definitions.Mar 27 2023, 12:09 PM
gerritbot added a comment.Mar 27 2023, 12:11 PM

Change 902616 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] extension.json: Update minimum mediawiki version

https://gerrit.wikimedia.org/r/902616

TheresNoTime mentioned this in rEPHN6b235c62711e: extension.json: Update minimum mediawiki version.Mar 27 2023, 12:12 PM
TheresNoTime added a comment.EditedMar 27 2023, 12:17 PM

TemplateWizard

(nb. passive maintenance)

CodeMirror

TheresNoTime added a project: Essential-Work.Mar 27 2023, 12:22 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 27 2023, 1:00 PM
TheresNoTime edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.Mar 28 2023, 11:09 AM
TheresNoTime moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.Mar 28 2023, 11:12 AM
gerritbot added a comment.Mar 31 2023, 7:27 AM

Change 904673 had a related patch set uploaded (by Sarah Mukuti; author: Sarah Mukuti):

[mediawiki/extensions/CodeMirror@master] extension.json: remove unnecessary target definitions

https://gerrit.wikimedia.org/r/904673

gerritbot added a comment.Apr 4 2023, 2:21 PM

Change 904673 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] extension.json: remove unnecessary target definitions

https://gerrit.wikimedia.org/r/904673

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.4; 2023-04-10); removed MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Apr 4 2023, 3:00 PM
• S_Mukuti moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Apr 13 2023, 10:47 AM

I think this is all done.

gerritbot added a comment.Apr 13 2023, 12:58 PM

Change 908540 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/TemplateWizard@master] extension.json: Remove unnecessary targets definitions

https://gerrit.wikimedia.org/r/908540

TheresNoTime added a comment.Apr 13 2023, 1:00 PM
In T329643#8778655, @S_Mukuti wrote:

I think this is all done.

We both missed one in TemplateWizard! Submitted a quick patch, then this task is definitely done 😄

gerritbot added a comment.Apr 14 2023, 6:53 AM

Change 908540 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] extension.json: Remove unnecessary targets definitions

https://gerrit.wikimedia.org/r/908540

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.5; 2023-04-17); removed MW-1.41-notes (1.41.0-wmf.4; 2023-04-10).Apr 14 2023, 7:00 AM
MusikAnimal removed a project: AbuseFilter.Apr 14 2023, 7:08 PM
MusikAnimal subscribed.

Removing AbuseFilter assuming that was added by mistake, given we don't maintain it.

TheresNoTime moved this task from Review/Feedback 💬 to Product sign-off 🤘 on the Community-Tech (CommTech-Kanban) board.Apr 18 2023, 1:19 PM
TheresNoTime closed this task as Resolved.May 16 2023, 8:53 AM
TheresNoTime moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.
MusikAnimal moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Jul 27 2023, 3:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL