Page MenuHomePhabricator

Treating repeated text on wikistories
Closed, ResolvedPublic

Description

Background

Cases of captions being repeated across multiple frames can be seen in the examples below:

Description/User story

As a Wikistory editor,
I want to be shown if the text on my stories are duplicated,
so that I can prevent potential editorial burden for stories.

Design
Duplicate text iconMessage on first story pageMessage on second story page
01.png (780×360 px, 303 KB)
2.png (780×360 px, 305 KB)
3.png (780×360 px, 203 KB)

01. Identify Duplicate Text: Detect duplicate text across story pages in real-time.
02. Thumbnail Warning Icon: Display a warning icon on the story page thumbnail when duplicate text is present. Place the icon in the bottom right corner to make it noticeable without obstructing the content.
03. Textbox Warning Message: When the user taps on the thumbnail and navigates to the story page, display a concise warning message "Duplicate text detected, replace? below the textbox, indicating that the text is duplicate to other story pages.
04. Tap on "Replace": If the user taps on the word "Replace" (the hyperlink in the warning message), they will be taken to the article text selection screen. Here, they can select a different part of the article to replace the duplicate text in the story page. Once they select the new text, it will replace the duplicate text in the story page, and the warning message and icon will be removed.
05. Tap on Textbox: If the user taps on the textbox itself (outside of the "Replace" hyperlink), the textbox will open in editing mode. This allows the user to manually edit the text within the textbox, giving them the flexibility to make minor changes without having to replace the entire text. Once they finish editing and the text is no longer a duplicate, the warning message and icon will be removed.
06. Address or Ignore: Allow the user to either address the duplicate text issue by modifying the text or ignore the warning and continue editing other parts of the story.
07. Warning Persistence: Keep the warning icon on the thumbnail and the warning message below the textbox until the user addresses the issue or saves the story with the duplicate text.
08. Prioritize Warnings: If there are multiple warnings (e.g., when the story is opened again for editing), prioritize the "Outdated story text" message over the "Duplicate text" message. If the "Outdated story text" condition is not met, continue showing the "Duplicate text" message.
09. Acknowledge Resolution:
a. If duplicate text exists on only 2 pages:


  • When the user modifies the duplicate text on one page, automatically update the other page as well, removing the duplicate text warning.
  • Remove the warning icon and message from both thumbnails and text boxes.

b. If duplicate text exists on more than 2 pages:


  • Remove the warning icon from the corrected story page thumbnail.

  • Keep the warning icon and message on other pages until user resolves the duplicate text issue on each of the remaining pages.

Design file

Acceptance Criteria
  • Visible notice during publishing step indicating repeated captions in some/all frames for the editor to consider.
Test Scenarios
  • repeated text that are not part of the article
  • repeated text that are copied from the article
  • repeated text on subsequent frames
  • repeated text on alternate frames
  • repeated text but with additional symbols (.,/?)
Open questions
  • Detecting and handling repeated texts across frames in the story builder:

repeated captions that are not part of the article
repeated captions that are copied from the article

  • Editorial interventions after publishing:

adding abuse filters for stories with repeated captions

Event Timeline

PWaigi-WMF triaged this task as Medium priority.Feb 20 2023, 1:59 PM
PWaigi-WMF moved this task from Definition to Backlog on the Inuka-Team (Kanban) board.
SBisson renamed this task from Treating repeated text/ captions on wikistories to Treating repeated text on wikistories .Mar 21 2023, 7:56 PM
SBisson updated the task description. (Show Details)

Change 919782 had a related patch set uploaded (by Huei Tan; author: Huei Tan):

[mediawiki/extensions/Wikistories@master] Treating repeated text on wikistories

https://gerrit.wikimedia.org/r/919782

Hi @SGautam_WMF

There is the UI inconsistency from the duplicate message and edit suggestion message

duplicate message always show the icon next to thumbnail, and always show the duplicate message on the page;

while edit suggestion message doesn't show the icon next to thumbnail, and only show the edit message when user edit the text;

image.png (297×477 px, 68 KB)

image.png (421×445 px, 112 KB)

Change 919782 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Treating repeated text on wikistories

https://gerrit.wikimedia.org/r/919782

@hueitan Only a couple of things that I noticed. The first one has not considered real-time since the message only updates when you click on Done in "Edit text" as seen in the first fail with the gif. Also if you don't mind check out the Possible Issues section too before I can move this to sign-off.

01. Identify Duplicate Text in real-time: ❌ =  FAIL

2023-08-22_12-29-41.mp4.gif (754×768 px, 720 KB)

02. Thumbnail Warning Icon: ✅ = PASS
03. Textbox Warning Message: ✅ = PASS
04. Tap on "Replace”: ✅ = PASS
05. Tap on Textbox: ✅ = PASS
06. Address or Ignore: ✅ = PASS
07. Warning Persistence: ✅ = PASS
08. Prioritize Warnings: ✅ = PASS
2023-08-22_12-13-36.mp4.gif (740×728 px, 609 KB)

09. Acknowledge Resolution: ✅ = PASS
a. If duplicate text exists on only 2 pages: ✅ = PASS
b. If duplicate text exists on more than 2 pages: ✅ = PASS

Possible Issues:
Test link: https://en.m.wikipedia.beta.wmflabs.org/wiki/Story:Universal_Studios
Should a duplicate message be in Story Url mode as seen in the gif and screenshot if anything in the Edit mode?

2023-08-22_11-43-06.mp4.gif (716×1 px, 1 MB)
2023-08-22_11-44-09.png (1×1 px, 1 MB)

You get a "duplicate text detected, replace" as seen in each slide as it should be but when you click on the slide like the 3rd slide, you get a "Please avoid removing too much text before you" even when you didn't do anything yet as seen in the gif

2023-08-22_12-21-32.mp4.gif (780×1 px, 738 KB)

Test Scenarios (chrome devtools iPhone SE emulation):

❌ repeated text that are not part of the article

  • When repeating text that is not part of the article, a warning is given to Please avoid removing too much text but no text was actually removed. There is also no warning given that text is repeated. See gif below:

Screen Recording 2023-08-22 at 5.30.47 PM.gif (1×724 px, 245 KB)


❌ repeated text that are copied from the article

  • Copied text is from article is repeated and no warning is given.

Screenshot 2023-08-22 at 6.01.50 PM.png (1×738 px, 793 KB)


✅ repeated text on subsequent frames

  • repeated text on subsequent frames correctly displays a warning
not part of the articlecopied from article
Screenshot 2023-08-22 at 4.36.00 PM.png (1×742 px, 1 MB)
Screenshot 2023-08-22 at 4.36.42 PM.png (1×722 px, 979 KB)

✅ repeated text on alternate frames

  • repeated text on subsequent frames correctly displays a warning
not part of the articlecopied from article
Screenshot 2023-08-22 at 6.12.07 PM.png (1×746 px, 1 MB)
Screenshot 2023-08-22 at 6.09.29 PM.png (1×748 px, 998 KB)

❓ repeated text but with additional symbols (.,/?)

  • When an additional symbol is added, then the repeated text warning is not shown. Was unsure from the test scenario if this is expected or not?
not part of the articlecopied from article
Screen Recording 2023-08-22 at 6.23.28 PM.gif (1×724 px, 1 MB)
Screen Recording 2023-08-22 at 6.25.50 PM.gif (1×724 px, 1 MB)

One additional note which is not an a bug, but a suggestion. When removing all the text in the story, the Select story text from Wikipedia link should display again as soon as the last character is deleted. As it is currently, once all text has been deleted the user has to click the Done button to get back to the Select story text from Wikipedia link which was not intuitive for me. See gif below:

Screen Recording 2023-08-22 at 6.50.44 PM.gif (1×724 px, 931 KB)

❓duplicate text (repeated text) not shown in real time when editing the text

This has been raised several times in this ticket and also T340662: Update warning message in Wikistories text editing mode. , this is expected and we only show the repeated text message in non-editing mode. We will create another ticket if necessary in the future.

❓ repeated text but with additional symbols (.,/?)

This is fine.

When removing all the text in the story, the Select story text from Wikipedia link should display again as soon as the last character is deleted.

Yes, this also raised by other qa and here's the new ticket T343553: Improve UX for empty text box after user removes selected story text


I can see all the questions are answered, moving this out from the qa column, feel free to move it back if you have more questions.

Test Scenarios (chrome devtools iPhone SE emulation):

Thanks @vaughnwalters! I have those issues mentioned on other tickets that they created so we should be good.